devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	linux-watchdog@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v3] dt-bindings: watchdog: gpio: Convert bindings to YAML
Date: Thu, 15 Dec 2022 23:46:15 +0100	[thread overview]
Message-ID: <f37d35a1-ca1a-a7bc-9a9c-83b684942447@denx.de> (raw)
In-Reply-To: <aa28894d-86e0-dc50-4d23-f5c469ecd27d@denx.de>

On 12/15/22 23:45, Marek Vasut wrote:
> On 12/15/22 21:37, Rob Herring wrote:
>>
>> On Mon, 07 Nov 2022 17:03:38 +0100, Marek Vasut wrote:
>>> Convert the gpio-wdt bindings from text to YAML ones, to permit DT 
>>> validation.
>>>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> Cc: Guenter Roeck <linux@roeck-us.net>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
>>> Cc: linux-watchdog@vger.kernel.org
>>> To: devicetree@vger.kernel.org
>>> ---
>>> V2: - Add missing required: properties
>>>      - Drop quotes around ref: referenced schema file name
>>> V3: - Add Guenter as maintainer of the bindings
>>>      - Add RB from Rob
>>> ---
>>>   .../devicetree/bindings/watchdog/gpio-wdt.txt | 28 -----------
>>>   .../bindings/watchdog/linux,wdt-gpio.yaml     | 47 +++++++++++++++++++
>>>   2 files changed, 47 insertions(+), 28 deletions(-)
>>>   delete mode 100644 
>>> Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
>>>
>>
>> Looks like this was missed. Applied, thanks! You missed
>> 'always-running', so I added it from the other conversion that was
>> done[1].
>>
>> Rob
>>
>> [1] 
>> https://lore.kernel.org/all/20221125112904.48652-1-robert.marko@sartura.hr/
> 
> There is no 'always-enabled' DT property used anywhere in the Linux 
> kernel, at least 'git grep' in latest next-20221215 indicates so. Shall 
> we really add it in the bindings ?

Please ignore what I wrote, always-running was indeed missed.

      reply	other threads:[~2022-12-15 22:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-07 16:03 [PATCH v3] dt-bindings: watchdog: gpio: Convert bindings to YAML Marek Vasut
2022-11-15 13:29 ` Guenter Roeck
2022-12-15 20:37 ` Rob Herring
2022-12-15 22:45   ` Marek Vasut
2022-12-15 22:46     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f37d35a1-ca1a-a7bc-9a9c-83b684942447@denx.de \
    --to=marex@denx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).