From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B81AC77B7D for ; Wed, 10 May 2023 07:52:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236338AbjEJHwF (ORCPT ); Wed, 10 May 2023 03:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236355AbjEJHwC (ORCPT ); Wed, 10 May 2023 03:52:02 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DA771729 for ; Wed, 10 May 2023 00:51:55 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-965ab8ed1c0so1120375566b.2 for ; Wed, 10 May 2023 00:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683705114; x=1686297114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9sZ0/8EovSIVbd5AFaZe/dkBXV3RZ8rTX6k+VIL7rd4=; b=e8aIWPr+BEmBTl5Ja69WLppVzCkVAIOoaeeLgvNObfsN5wQLd0YAml7nw0+qZZ1PL0 UhF4FR8wKNwb5HXVNUyseHYPaBkEAeO7I/Fxw6hZUFeJpydOvePJPb3ohp35suuHDCDw QvriOZSDJQisEEvPVNim3W3+0bbGHdkjYz7Ow/qbIRoNUY9s/D0K37beZDaxvOGvSe2Z d/uMqO1NFUBNKT78u0Pa0RhJVplJ9pAEbSvb2QFXSUf80a/FgeoIAnjNOYIFhaQzEXyI 9FMCHwN/C7evyXJOj0YgwPkbIythdN5/kPMzgqqhpY33OCfXu/NL8PDj+89GRNQPZNbO Zi6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683705114; x=1686297114; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9sZ0/8EovSIVbd5AFaZe/dkBXV3RZ8rTX6k+VIL7rd4=; b=HL9z/IZUWlxFKNKe2nqT8cI9uaNq5btvhndS4uRVKRiuTQtle7U2+uLylBGg4q9xSb TAfPAj+1kr4TM1IqzvZv4ohR4y+TSBzYhCPPevBJCBPrWNZgu6XQWTgBYYvzMI8caJE0 UyA3Q/azhIz5qeaCH7n+Acg4zqs/3WOTzcrmoWmBqBwyatFApnwOy3Y32hjXV13S9xYW nhU+uDyhQ7+OR3MwZIoVXc2iwsrGNlq5HSflQkhGgB3miUTIX+Rq2Lyj4Ob8dQMMwVrO ql6rR7dU2lrblulPQDIaf8PAIS//msoqIhu95BPtAFI4p3Xe8sAWASRl40jg9+i/9bJ+ yZ9Q== X-Gm-Message-State: AC+VfDyzu/CiJuFBxA7EZcX5FWgZhXESjpFZewaXhEEVn3kFV2VC9e6f 48YDhvvTGzggqd6AA1qkwKopgA== X-Google-Smtp-Source: ACHHUZ6exavcj5UmA9VcbxCwK35ZHL+3F10nUmd/jcwMNBcB51eEB2rJ74He9CSe0YwNB+NB6rHmmA== X-Received: by 2002:a17:907:8694:b0:96a:1c2a:5a38 with SMTP id qa20-20020a170907869400b0096a1c2a5a38mr1858388ejc.11.1683705113851; Wed, 10 May 2023 00:51:53 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:c175:a0f9:6928:8c9d? ([2a02:810d:15c0:828:c175:a0f9:6928:8c9d]) by smtp.gmail.com with ESMTPSA id lf23-20020a170906ae5700b0094ee700d8e4sm2309055ejb.44.2023.05.10.00.51.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 00:51:52 -0700 (PDT) Message-ID: Date: Wed, 10 May 2023 09:51:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add adi,ssm3515 amp schema Content-Language: en-US To: Conor Dooley , =?UTF-8?Q?Martin_Povi=c5=a1er?= Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Lars-Peter Clausen , =?UTF-8?Q?Nuno_S=c3=a1?= , asahi@lists.linux.dev, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230509163828.86003-1-povik+lin@cutebit.org> <20230509-marxism-plug-759c99ac601c@spud> From: Krzysztof Kozlowski In-Reply-To: <20230509-marxism-plug-759c99ac601c@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2023 20:25, Conor Dooley wrote: > Hey Martin, > > On Tue, May 09, 2023 at 06:38:27PM +0200, Martin Povišer wrote: >> Add a DT schema for the SSM3515 amp by Analog Devices. It's a simple >> mono amplifier with digital input. >> >> Signed-off-by: Martin Povišer >> --- >> .../bindings/sound/adi,ssm3515.yaml | 66 +++++++++++++++++++ >> 1 file changed, 66 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm3515.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml >> new file mode 100644 >> index 000000000000..19b7185ae8e2 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/adi,ssm3515.yaml >> @@ -0,0 +1,66 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2019-20 Texas Instruments Incorporated > > Copyright here looks a little odd, copy & paste from the TI bindings you > send patches for earlier, or intended? > >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/sound/adi,ssm3515.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > Drop the quotes on these please. > >> + >> +title: Analog Devices SSM3515 Audio Amplifier >> + >> +maintainers: >> + - Martin Povišer >> + >> +description: | >> + SSM3515 is a mono Class-D audio amplifier with digital input. >> + >> + https://www.analog.com/media/en/technical-documentation/data-sheets/SSM3515.pdf >> + >> +allOf: >> + - $ref: dai-common.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - adi,ssm3515 >> + >> + reg: >> + maxItems: 1 >> + >> + adi,ana-gain: >> + $ref: /schemas/types.yaml#/definitions/uint32 >> + enum: [0, 1, 2, 3] >> + description: | >> + The value to be set in the ANA_GAIN register field on the codec. This determines >> + the full voltage span of the codec's analog output. >> + >> + To quote the datasheet on the available options: >> + >> + 00: 8.4 V Full-Scale Gain Mapping >> + 01: 12.6 V Full-Scale Gain Mapping >> + 10: 14 V Full-Scale Gain Mapping >> + 11: 15 V Full-Scale Gain Mapping > > Putting register values into the DT does not seem correct, although > I know nothing about sound and will have to defer to Krzysztof & Co. on > that front. Depends whether these are really voltages or something else (e.g. gain) just related to voltage. Best regards, Krzysztof