From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C40CC4332F for ; Sat, 10 Dec 2022 12:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229723AbiLJM37 (ORCPT ); Sat, 10 Dec 2022 07:29:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbiLJM35 (ORCPT ); Sat, 10 Dec 2022 07:29:57 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A10A1C413 for ; Sat, 10 Dec 2022 04:29:56 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id p8so11117421lfu.11 for ; Sat, 10 Dec 2022 04:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/S/tLvSZxZXHVY0JERCLfAZM29sEkAUhJTgc/unddeg=; b=iauLDumAo/9BqlF8TA/G/2S9JBoyEusl15pJ3gg50C7J1fSv78be/eFAcJG5O8QWdq sod5RBsIA4OB0yMwgVeMMKLIq6LhmVWFCV2YnEbs9C5UOzpPf2y4WIqjlbnVeKlPJ24C dTYJzQ8WzqoBF/u4WUbAcJh5OisyalfDe836QklvQkxCRwDm1Nv50lUopRhGPkPARFxc /Uk1vZS8v7YRiptj403pTlzV6UBhmkfhE1Vzw/zUUBT4JRCxA9I7n5B3Alw6I2zYFDKJ FvZGBc76v/FqLSZBgIkpCSc83KR4yZChsLjOozyL/IYzB4CvV+mBrCmYNMucyNODIQOB qY1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/S/tLvSZxZXHVY0JERCLfAZM29sEkAUhJTgc/unddeg=; b=f8I1HdZ6Om9cHhwW8NIrY+rFtmalVxlyjobkEDVgL6XMrtosyyzk6yZD17GUH3To8f nw4jOyDN6kzViowubqGJOz7IBiNVoSM9uKgAwOMLfLLEjLT+55l+WKTn3RoPsA77ZWxP TFhS7LkED61G1NzURYdNBiqbNhoycwUlnniy1RDMwdqDPReJupcvZKOSZ2iuTeehNoto f9rNCJTdwHhkVz/X3STaj7ar4cpdHowfhSGHub/Nov7A64XgRq9yeMDIuo8R+B01pzYk PK9h7jV9ABnCQly2JBwu3eCZG9sT0siVakB8k2Mo4aHiO99hHBpjqyPPNIXy4ujexK5V uEUQ== X-Gm-Message-State: ANoB5pls3Y0sv4TQnLMprzXvoOa4syqV9wRMpYPfSHKHbS70iNpp/7mh hkAS5yJr2C10HbY7qPrGy7wyrA== X-Google-Smtp-Source: AA0mqf7FHhmSa/SqG52Sj+exHj3rmyDJ05oDcK2GL1lNSyKRfWlYtiG1fw09Kd331nbceG3Zho5QDg== X-Received: by 2002:a05:6512:6d1:b0:4b1:8830:85e8 with SMTP id u17-20020a05651206d100b004b1883085e8mr3247569lff.26.1670675394733; Sat, 10 Dec 2022 04:29:54 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id v17-20020ac25b11000000b004a2550db9ddsm706160lfn.245.2022.12.10.04.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Dec 2022 04:29:54 -0800 (PST) Message-ID: Date: Sat, 10 Dec 2022 13:29:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc7180: move QUP and QSPI opp tables out of SoC node Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221210115704.97614-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10.12.2022 12:57, Krzysztof Kozlowski wrote: > The SoC node is a simple-bus and its schema expect to have nodes only > with unit addresses: > > sc7180-trogdor-lazor-r3.dtb: soc@0: opp-table-qspi: {'compatible': ['operating-points-v2'], 'phandle': [[186]], 'opp-75000000': > ... 'required-opps': [[47]]}} should not be valid under {'type': 'object'} > > Move to top-level OPP tables: > - QUP which is shared between multiple nodes, > - QSPI which cannot be placed in its node due to address/size cells. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 76 ++++++++++++++-------------- > 1 file changed, 38 insertions(+), 38 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index ea886cf08b4d..735581097295 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -538,6 +538,44 @@ cpu6_opp16: opp-2553600000 { > }; > }; > > + qspi_opp_table: opp-table-qspi { > + compatible = "operating-points-v2"; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-150000000 { > + opp-hz = /bits/ 64 <150000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + }; > + > + qup_opp_table: opp-table-qup { > + compatible = "operating-points-v2"; > + > + opp-75000000 { > + opp-hz = /bits/ 64 <75000000>; > + required-opps = <&rpmhpd_opp_low_svs>; > + }; > + > + opp-100000000 { > + opp-hz = /bits/ 64 <100000000>; > + required-opps = <&rpmhpd_opp_svs>; > + }; > + > + opp-128000000 { > + opp-hz = /bits/ 64 <128000000>; > + required-opps = <&rpmhpd_opp_nom>; > + }; > + }; > + > memory@80000000 { Sidenote: memory@ should be moved above opp-*, alphabetically For this: Reviewed-by: Konrad Dybcio Konrad > device_type = "memory"; > /* We expect the bootloader to fill in the size */ > @@ -739,25 +777,6 @@ opp-384000000 { > }; > }; > > - qup_opp_table: opp-table-qup { > - compatible = "operating-points-v2"; > - > - opp-75000000 { > - opp-hz = /bits/ 64 <75000000>; > - required-opps = <&rpmhpd_opp_low_svs>; > - }; > - > - opp-100000000 { > - opp-hz = /bits/ 64 <100000000>; > - required-opps = <&rpmhpd_opp_svs>; > - }; > - > - opp-128000000 { > - opp-hz = /bits/ 64 <128000000>; > - required-opps = <&rpmhpd_opp_nom>; > - }; > - }; > - > qupv3_id_0: geniqup@8c0000 { > compatible = "qcom,geni-se-qup"; > reg = <0 0x008c0000 0 0x6000>; > @@ -2655,25 +2674,6 @@ opp-202000000 { > }; > }; > > - qspi_opp_table: opp-table-qspi { > - compatible = "operating-points-v2"; > - > - opp-75000000 { > - opp-hz = /bits/ 64 <75000000>; > - required-opps = <&rpmhpd_opp_low_svs>; > - }; > - > - opp-150000000 { > - opp-hz = /bits/ 64 <150000000>; > - required-opps = <&rpmhpd_opp_svs>; > - }; > - > - opp-300000000 { > - opp-hz = /bits/ 64 <300000000>; > - required-opps = <&rpmhpd_opp_nom>; > - }; > - }; > - > qspi: spi@88dc000 { > compatible = "qcom,sc7180-qspi", "qcom,qspi-v1"; > reg = <0 0x088dc000 0 0x600>;