From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C208C678D4 for ; Thu, 2 Mar 2023 12:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229674AbjCBM2j (ORCPT ); Thu, 2 Mar 2023 07:28:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjCBM2i (ORCPT ); Thu, 2 Mar 2023 07:28:38 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9DDE7283 for ; Thu, 2 Mar 2023 04:28:32 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id h9so17435731ljq.2 for ; Thu, 02 Mar 2023 04:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1677760111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QM9EzJ59d7bm12hYRBG6XOMDXAxFr+3VVIYgcW52hKU=; b=lZIUY2xO9crjBnBglCG+jmfXGploPGWLi1NjlFyOGpVzQWKyDoe2m9nYrRtGHt/MwU dGInHAH7wJx4Moi5TU1b0FoUn/6CpIc5ps0vqd+x3ta3xLYndI6VZoplvuQS6LfAo0mZ 8oYOb87lL2GqISnfyNi+xK7+ocr6kLZQ0Ha59By7OexU2iweDROpWTcXfwq7ss5VDaJk +6GPno+LQxqgemVcxPHFMWOCCYQ2D82FDhf3ug6ZmB4eVC4BeN+7xGCyZ/DLxXTedkb1 1fGVnf8vxxlOdxy0QXukySqts6C+/0m/EzEArj75MDF4LGwgoJkn+/p982GXyAudP/7o rTgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677760111; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QM9EzJ59d7bm12hYRBG6XOMDXAxFr+3VVIYgcW52hKU=; b=5szZmcGx493jaIgzRlIBbD9VRFI0iM6rjVocadPb6iydr1Q+bQjurH+FX4rt8cWMz7 kJr7NgnzdztUtcaVhtC39CT9/ZcgJ/2MWOFIlfesz8UHhkzy37z3vZ+YAASO2fxaD5v5 L4TGuuw2bkC90W7UEZu+sp6BRjb5Jqr2BnKTyVxONMRikMBearII7iFSHiKI4OYaWrbK Cc3PyR4R9GAgY2L1cGd74mPiXVjXiTfhBjrY8Uum5ydzFwG/Bqabd7ehYjNY3yizO5QO QyACAdKSVRUziCySPJQfIvK7RKGlDCpAWvRoLFLOEGmG60Ma+SqtKXImne6MXtg7Xulf 0e3A== X-Gm-Message-State: AO0yUKVtZnCXyUGZvk96GC2b9fdU5+2zbJ/S18qaAP63yyPg3OLfbjMx fVxBFVODDyd6x4WUMFGtvacpiw== X-Google-Smtp-Source: AK7set/X14A60bT9t4QpESXUrKarmtui6NVnUQo6yUQoVYeTRj2Pq03+cx5bPgVW7QJbidOyAsln/g== X-Received: by 2002:a2e:9b49:0:b0:293:4b61:265a with SMTP id o9-20020a2e9b49000000b002934b61265amr3040517ljj.49.1677760111243; Thu, 02 Mar 2023 04:28:31 -0800 (PST) Received: from [192.168.1.101] (abym99.neoplus.adsl.tpnet.pl. [83.9.32.99]) by smtp.gmail.com with ESMTPSA id g7-20020a2eb5c7000000b002946be8475esm2079985ljn.135.2023.03.02.04.28.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 04:28:30 -0800 (PST) Message-ID: Date: Thu, 2 Mar 2023 13:28:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: fix va dmic dai links and routing Content-Language: en-US To: Srinivas Kandagatla , agross@kernel.org, andersson@kernel.org Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230302115741.7726-1-srinivas.kandagatla@linaro.org> <20230302115741.7726-5-srinivas.kandagatla@linaro.org> From: Konrad Dybcio In-Reply-To: <20230302115741.7726-5-srinivas.kandagatla@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2.03.2023 12:57, Srinivas Kandagatla wrote: > VA dmics 0, 1, 2 micbias on X13s are connected to WCD MICBIAS1, WCD MICBIAS1 > and WCD MICBIAS3 respectively. Reflect this in dt to get dmics working. I'm far from good when it comes to sound, but is it expected that (VA DMICn) are are connected to both (MIC BIASn) and (VA MIC BIAS{1, 1, 3})? > Also fix dmics to go via VA Macro instead of TX macro to fix device switching. > > Fixes: 8c1ea87e80b4 ("arm64: dts: qcom: sc8280xp-x13s: Add soundcard support") If that doesn't depend on any driver changes, please Cc stable so that distros will pick this up. Konrad > Signed-off-by: Srinivas Kandagatla > --- > .../arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index d18d405d1776..89230112e288 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -933,9 +933,9 @@ > "VA DMIC0", "MIC BIAS1", > "VA DMIC1", "MIC BIAS1", > "VA DMIC2", "MIC BIAS3", > - "TX DMIC0", "MIC BIAS1", > - "TX DMIC1", "MIC BIAS2", > - "TX DMIC2", "MIC BIAS3", > + "VA DMIC0", "VA MIC BIAS1", > + "VA DMIC1", "VA MIC BIAS1", > + "VA DMIC2", "VA MIC BIAS3", > "TX SWR_ADC1", "ADC2_OUTPUT"; > > wcd-playback-dai-link { > @@ -986,7 +986,7 @@ > va-dai-link { > link-name = "VA Capture"; > cpu { > - sound-dai = <&q6apmbedai TX_CODEC_DMA_TX_3>; > + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; > }; > > platform {