From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C792C433FE for ; Tue, 22 Nov 2022 23:54:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235059AbiKVXyN (ORCPT ); Tue, 22 Nov 2022 18:54:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234817AbiKVXyL (ORCPT ); Tue, 22 Nov 2022 18:54:11 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98CE2BEB55 for ; Tue, 22 Nov 2022 15:54:09 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id b9so19676411ljr.5 for ; Tue, 22 Nov 2022 15:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vSQxsfoYnD2A3tH+O3pkstLuZIwU+jkrLdSB14gdhug=; b=vBWoS7NGEmZ4M8NUTF4f50mMJ+CyxMmbJWmVfdhdi/wQYco0DXDHWbkO+kq5K7tbfl dSpgdY1eGcCZ3wmETUxnjEVWKJsvzMefqQktCpYXzKBshcAUdKPXNSeinyxRWjyLtb37 elrtpxMEA88/Sp5Oh64GPVBahbh4PsS0mmS68O/krFQhSTIXOrq/pSfWjwi29l8r2fpI kkngvioKMztgCcyDN1NStajFyOmsnh3r/mGcNKaPR4mUqMe+vZnqVLaeyHJtbrHQGiVK 7CIx6R0Grk/B7CkoxN25PHIonDDP6SYQDunqvK/4damSUlCizO2yQV5xaS+TRcPDn0r8 dCOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vSQxsfoYnD2A3tH+O3pkstLuZIwU+jkrLdSB14gdhug=; b=ZkVy5qGI8uzdoR+2b4TE6kL1VNPmAPR6v6Noj2ZXOAp9OlGtohHeQzX/LLsvjNQBSH /5DAf1Idi2JFJ0IHLL0eBzOTxXWzlsn6vD1XWVmEvo2Jyp3XpklyIgQeK1dxDRfcLlKG 2D65cv6pshui0FjukTwpN3nPsvaiBTmqeIKvCnaTT6xOnAUq6jmO3XlLUuZXtNG2jmgG XGMprQJDVJ/PlxNDQyTUlGA9BB6PaU5jxpIX49S0zO0gjV2cCQkF8CwTxsQ/VIXJ8Jk/ 34DIoPYoaqlM8vvK83VUonScHO2EntD19lbV+E4ISR7uForDEgT+zJ4aVjrpCDCr/Zwy rK8Q== X-Gm-Message-State: ANoB5pl9R8hnoF6o2XYXimbdv+zbkDeDWPJ3/2+W/nW83fMLXjkLgKrP g6hdIM5WGwXedOF6rOx0P+0U6w== X-Google-Smtp-Source: AA0mqf6qg6QL8mtw0Y4ZgkbmPG9ZL4mch+rv29n4tkp7iw2Xw+a/UuSczczoRzzpOUoRBvOKd8bU1w== X-Received: by 2002:a05:651c:158c:b0:26c:90f:f8fe with SMTP id h12-20020a05651c158c00b0026c090ff8femr8807484ljq.2.1669161247954; Tue, 22 Nov 2022 15:54:07 -0800 (PST) Received: from ?IPV6:2001:14ba:a302:8a1a::1? (dzpbkzhtyyyyyyyyyyyyt-3.rev.dnainternet.fi. [2001:14ba:a302:8a1a::1]) by smtp.gmail.com with ESMTPSA id o19-20020ac24e93000000b004acd6e441cesm2663361lfr.205.2022.11.22.15.54.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 15:54:07 -0800 (PST) Message-ID: Date: Wed, 23 Nov 2022 01:54:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] drm/msm/disp/dpu1: add support for display on SM6115 Content-Language: en-GB To: Adam Skladowski Cc: phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Kalyan Thota , Jessica Zhang , AngeloGioacchino Del Regno , Loic Poulain , Adam Skladowski , Stephen Boyd , Jason Wang , Vinod Polimera , Vinod Koul , Douglas Anderson , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221120133744.24808-1-a39.skl@gmail.com> <20221120133744.24808-3-a39.skl@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20221120133744.24808-3-a39.skl@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/11/2022 15:37, Adam Skladowski wrote: > Add required display hw catalog changes for SM6115. > > Signed-off-by: Adam Skladowski > --- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 87 +++++++++++++++++++ > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + > drivers/gpu/drm/msm/msm_mdss.c | 5 ++ > 4 files changed, 94 insertions(+) > [skipped] > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 6a4549ef34d4..86b28add1fff 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -280,6 +280,10 @@ static int msm_mdss_enable(struct msm_mdss *msm_mdss) > /* UBWC_2_0 */ > msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x1e); > break; > + case DPU_HW_VER_630: > + /* UBWC_2_0 */ > + msm_mdss_setup_ubwc_dec_20(msm_mdss, 0x11f); > + break; According to the vendor dtsi the sm6115 is UBWC 1.0, not 2.0 Could you please doublecheck? Looks good to me otherwise. > case DPU_HW_VER_720: > msm_mdss_setup_ubwc_dec_40(msm_mdss, UBWC_3_0, 6, 1, 1, 1); > break; > @@ -509,6 +513,7 @@ static const struct of_device_id mdss_dt_match[] = { > { .compatible = "qcom,sc7180-mdss" }, > { .compatible = "qcom,sc7280-mdss" }, > { .compatible = "qcom,sc8180x-mdss" }, > + { .compatible = "qcom,sm6115-mdss" }, > { .compatible = "qcom,sm8150-mdss" }, > { .compatible = "qcom,sm8250-mdss" }, > {} -- With best wishes Dmitry