From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA00C433F5 for ; Tue, 19 Apr 2022 07:37:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349456AbiDSHka (ORCPT ); Tue, 19 Apr 2022 03:40:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349451AbiDSHka (ORCPT ); Tue, 19 Apr 2022 03:40:30 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1694223155 for ; Tue, 19 Apr 2022 00:37:48 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id v4so20115065edl.7 for ; Tue, 19 Apr 2022 00:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yT6EUKmSqiEGrbP4N0bYTSlk6uDr2husvMlBwTarc14=; b=oESzlwMe4qJx6PkKZ8Nr+xaGNaoz0I1C/zQz/+xq821OHmUr0SaaZZYBTTyunOkwTf FMD1/pwAG6bCuMJat+zkSPg5n5OVeYft77CqsYYaohcX4wuxJaFls8bP6DOskSBd/fQA EVeIcNRNYTjgYkbcLFygXB8RQaBvBgwrqEm2VDyt59c78dNJsF2O9qpzJdvFSrfnMZ6L QTEnnrlXdHHRQW33Aw0QOVdi8vy6btUL6pRtpxAWDQ6dGddxMT9zlCez7AzH3s0ikbcu ssN3mZzkc4+KQcfF+W6IcUKdJZJxr0CI799y4L382EUwf50g+eoVnxNoxI/PiCKyJhOk hb8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yT6EUKmSqiEGrbP4N0bYTSlk6uDr2husvMlBwTarc14=; b=XwjCWvA0JWusdW70HYVd/bBOI+TJlNqDKqxljId/PAUq4wNAexCCReW4nHO9TSS3sP /L0WWnGoZYT0y0K2bMAKptMc5bLysZxy86IxYLh9+YGJ3XzJwBcOmJPso6bGErDyB5p7 KfcnEKoXM/HzmCz9lTe0tom0SeIxlZ/2SJggAzY4jg1odeQkDtF3BZAhbOxSyKY7Qrms WXVhvrRyQG6yQ9itYQ1vV7GQkGLoZ7PFbpgSI4nV6u8qCJlG0GLv+hue5UyGktvcdd1V Vy5BoS1sREc0zLxvPVnjzed/Bah/fqFFEPhmElB0wuPK9Ji77dMezOthje27S1xHlfLa lTeQ== X-Gm-Message-State: AOAM530p9oipe0XGnZegCUs7a87dFXfkkwdPiYHH3sJIgHOpXh+Jzs6f 2sKqwb0m6mcPpsOtj1JisdDVBw== X-Google-Smtp-Source: ABdhPJy0UNi3XUJDgMW4NFNxXJ9DvThqGjEAKp4ZhYCkikzz8jJsqBSmHmpWm6hNq/7FqpUSfkaD1g== X-Received: by 2002:a05:6402:1cc1:b0:413:2cfb:b6ca with SMTP id ds1-20020a0564021cc100b004132cfbb6camr15695999edb.265.1650353866638; Tue, 19 Apr 2022 00:37:46 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id el14-20020a056402360e00b0042121aee887sm7423177edb.77.2022.04.19.00.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Apr 2022 00:37:46 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 09:37:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] arm64: dts: qcom: db845c: Add support for MCP2517FD Content-Language: en-US To: Vinod Koul , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam References: <20220419043348.1483625-1-vkoul@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220419043348.1483625-1-vkoul@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/04/2022 06:33, Vinod Koul wrote: > Add support for onboard MCP2517FD SPI CAN transceiver attached to > SPI0 of RB3. > > Signed-off-by: Vinod Koul > --- > Changes in v2: > - add cs and pinctrl config > - remove misleading comment > > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index 28fe45c5d516..4f4d45be93e3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -28,6 +28,13 @@ chosen { > stdout-path = "serial0:115200n8"; > }; > > + /* Fixed crystal oscillator dedicated to MCP2517FD */ > + clk40M: can_clock { No underscores in node names. > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <40000000>; > + }; > + > dc12v: dc12v-regulator { > compatible = "regulator-fixed"; > regulator-name = "DC12V"; > @@ -746,6 +753,24 @@ codec { > }; > }; > > +&spi0 { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&qup_spi0_default>; > + cs-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; > + > + can@0 { > + compatible = "microchip,mcp2517fd"; > + reg = <0>; > + clocks = <&clk40M>; > + interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>; > + spi-max-frequency = <10000000>; > + vdd-supply = <&vdc_5v>; > + xceiver-supply = <&vdc_5v>; > + status = "okay"; No need for status for new nodes (unless it is an extension of existing node?), it is okay by default. Best regards, Krzysztof