From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4341C4332F for ; Sat, 12 Nov 2022 11:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234758AbiKLLbd (ORCPT ); Sat, 12 Nov 2022 06:31:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233947AbiKLLbb (ORCPT ); Sat, 12 Nov 2022 06:31:31 -0500 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05D8D12D2E for ; Sat, 12 Nov 2022 03:31:29 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id bp15so11898393lfb.13 for ; Sat, 12 Nov 2022 03:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hyF6FkyUHkukwBAE9GVV4YhjtohoXdGwlx3Dp0iejE4=; b=ArCIX/n5Z4pVv90yyrB/6VQHqH5YHooQEMvqH4IE7TAcy9/vtmzrMPQqFpy4yWy3B3 d1Fv737eu2hRTFl8AMHvO045l+APx469fYZcUoflKRJ08SRWz44p140uu3RrZUay6ttN l2skMtTnSCLQ484x8V8wMaD+HiJKwhUyFOXAKQQJQCetFvR7ibCnNf+Oz6xqxToQWMJn 7HQdmHMM+5gk0agt+OZCJ/vOlc5iUUaDo1f+L3daYskuDOnckKAVY/2apY1trDFqWp1+ t/SoazbX5YhHrbS7Ef31WXnJBbPUBNdiOdbIDWCS+4dX/eos4Y/sQXR39f+ehySifluq i00A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hyF6FkyUHkukwBAE9GVV4YhjtohoXdGwlx3Dp0iejE4=; b=d16YN/QAqtV+oAzq9djdxBM2gkqcme8tvMOLGzg8KRAvx/lZLxS7utyZ6FlDtuK+3C L85xb3jnWMWrwZWCelS8K8TVDXExTl4FqA3Rp5+WYR7PKWiqhsW4uI2GzrCYjujjXWbA ywNVd1FGR9T26/hAhEAdv04a7L9EOewmdxj27LqpUOoVSh3jDBAwASATX4JEbqS2R8ro Loc+DpTk9C/bSvvOb2vfXYITfnDC7Ebcn087HthfCRBN9gNR4f1Kj2Xy10dOXdFx5l+3 GxPKR2gbKXS3XPA0aGjtx80r1kxV+XgVyaiQcCWCaTQZRxljIVEOBywprYQsDch4iho2 ImmA== X-Gm-Message-State: ANoB5pnDZYWfcpdUINIDyHPHjIYOd4m5Wv42RWacsFjwoIU96t9cwMPK JxNpFW7tlERUu8AK5tU+Xhf1kQ== X-Google-Smtp-Source: AA0mqf74V0/CUUWbv/npiqfkUCReOUvxvwo/eAL5/b6e4Nh/H+ULAIDj4T6zihNXsIEojUo9x56x+g== X-Received: by 2002:a19:e30e:0:b0:4a2:5163:f61b with SMTP id a14-20020a19e30e000000b004a25163f61bmr1894854lfh.177.1668252688147; Sat, 12 Nov 2022 03:31:28 -0800 (PST) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id s8-20020ac25fe8000000b00492b0d23d24sm824305lfg.247.2022.11.12.03.31.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 12 Nov 2022 03:31:27 -0800 (PST) Message-ID: Date: Sat, 12 Nov 2022 14:31:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 12/14] phy: qcom-qmp-combo: rename common-register pointers Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221111092457.10546-1-johan+linaro@kernel.org> <20221111092457.10546-13-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20221111092457.10546-13-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/11/2022 12:24, Johan Hovold wrote: > The common registers are shared by the USB and DP parts of the PHY so > drop the misleading "dp" prefix from the corresponding pointers. > > Note that the "DP" prefix could also be dropped from the corresponding > defines, but leave that in place for now. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 24 +++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) Reviewed-by: Dmitry Baryshkov Note regarding the last phrase: I'd suggest leaving the DP prefix in register names, it makes it easier to visually note & verify the register block. -- With best wishes Dmitry