From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE26B250FA for ; Tue, 9 Jan 2024 08:16:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hcrHFj2c" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-50e835800adso2531050e87.0 for ; Tue, 09 Jan 2024 00:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704788196; x=1705392996; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=VD6B+yT3ciRKIeNf/3WdzDYAUV+xbE1GcYHIb3TE3x0=; b=hcrHFj2cNBYH3S118ifCgpg+NhZE8nBQbWuGKw89wLVUCYPV3gRnwcAjO2M6y0UMqu zu9epJXYas8VLRUgM/PsLFp2pxCFILf+v7fN6dlpxM0BBJTrAn3H7fj7HSI+bYHJrx1P eyXjDd7ECLo9kQPmF6OJqF3Cp8ejXDOgV4Evqf2XcPyztAzNqRcbbt6dcvpAymuSlKwA cWtvDOK2LHsmkHawGB2izWikEVwmDoPcOF0Xg0ShfM4p6uGWR8Cid1jOmanvEYxZhlSx ZrI7GLn1cur9Go4GQFuIfDYioMPYQD7zivtjjBseVVznn/w+xdx4kBNP5PvdkH08V3sm rEvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704788196; x=1705392996; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VD6B+yT3ciRKIeNf/3WdzDYAUV+xbE1GcYHIb3TE3x0=; b=SZyrAdV/Mpg47kXxdOb014bYEsvMAeBIP8WYY6pKJf07lymH7mOCZcbrrKysPYcY9b PLXEBJF3VRc8xaExaH3lasNDK9g3wMYDb74JEAS1mMEUrHqbldPxL8+ODvDYeTTm+ijg x5VMYtM6/Ne+OuCOBzChzU3qp+yPbyeRcijJibOTHMMxMLmj5l02dPjLHXriL//RsRhY l8CM8QyIImobOxsFyRYUhW7fbda4sHpd15NrjgLGiqtzb/F0rkK6phqw0w6xyDe149dy xaUkD7bdfm3DJqDK6EsAxdDXDyBeoDyyG0A9d4MAHf6GBc8e+ixgHf4UI0BOtUFp7hEl A+Hg== X-Gm-Message-State: AOJu0YzSVJfdQJkyA7/x4W8iX0tTg/mzeMk+dbE0G466txUkp9wJFETH EmiqsWO6bkDA4vKzNIEwP/dXMebPMcGE7vZGr/S5WrnH6D0= X-Google-Smtp-Source: AGHT+IH1kQbKvelJl1RbBn0+788bc1GRqub5boCcIDxig0ggnJvJV85TskPvwQte0XucnhFeMVb3QQ== X-Received: by 2002:a05:6512:3b9c:b0:50e:b1fa:8645 with SMTP id g28-20020a0565123b9c00b0050eb1fa8645mr1596919lfv.109.1704788195701; Tue, 09 Jan 2024 00:16:35 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id h15-20020aa7c94f000000b00557c6778b88sm676290edt.53.2024.01.09.00.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jan 2024 00:16:34 -0800 (PST) Message-ID: Date: Tue, 9 Jan 2024 09:16:33 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: fpga: Convert bridge binding to yaml Content-Language: en-US From: Krzysztof Kozlowski To: Michal Simek , Xu Yilun Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com, git@xilinx.com, Conor Dooley , Krzysztof Kozlowski , Moritz Fischer , Rob Herring , Tom Rix , Wu Hao , Xu Yilun , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , kishore Manne , "open list:FPGA MANAGER FRAMEWORK" References: <3100bbc4723643ec1ec7d4548e9ab353c856b564.1704470663.git.michal.simek@amd.com> <4bcac34b-72a0-464e-91cd-d9e924073619@amd.com> <3bfaab38-6831-41f8-8a7b-9f1f434e0f9c@amd.com> Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/01/2024 09:15, Krzysztof Kozlowski wrote: >>>>>>> +properties: >>>>>>> + $nodename: >>>>>>> + pattern: "^fpga-bridge(@.*)?$" >>>>>> >>>>>> Not sure, but maybe we need to allow fpga-bridge-1? Could we have more >>>>>> than one bridge on given system? >>>>> >>>>> Yilun: Any comment on this? >>>> >>>> We can have more bridges, but IIUC people use fpga-bridge@0, fpga-bridge@0 >>>> to identify them. So the expression is OK to me. >>> >>> So you claim unit address thus reg with some sort of bus address is a >>> requirement? Then "?" is not correct in that pattern. >> >> I expect it is about that people are using fpga-bridge@0 but bridge is not on >> the bus. Yilun said that reg property in altr,socfpga-fpga2sdram-bridge.yaml is >> optional which means no reg property no @XXX in node name. >> That's why I think that expression is correct. If there are more bridges without >> reg property then I expect we need to get more examples to align expression. > > If we allow node name without unit address, thus not being part of any > bus, then the only question is whether it is possible to have system > with more than two FPGA bridges. If the answer is "yes", which I think > is the case, then the pattern should already allow it: > > (@[0-9a-f]+|-[0-9]+)? Or better go with what I used recently for narrowed choices: (@.*|-([0-9]|[1-9][0-9]+))? Best regards, Krzysztof