From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Guk+6gL5" Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 976C1126 for ; Thu, 14 Dec 2023 08:01:23 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-54c79968ffbso10447459a12.3 for ; Thu, 14 Dec 2023 08:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702569682; x=1703174482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+VFIozAF30zEgKKxFDP3drI06z9zzmO3HV6m4SuiwQ=; b=Guk+6gL5FvgbClXZhAqmyYzGq5UH6OfIyUvODkVmFf4vSY3etzuNxe3FtrN7amNL04 iJbmutKwh+6hUZ7JmeXeaqXqTI8sdd2Bj6lpYFplcA5aJFuSnWQk0ii/jrfMdbifEcnX MJMuT8B9XAOKq77C1E6lcI3zFiUh/anFfrNMt6sj7FdMIEvtpdw8zM9w7Cwej01TVWFS Et7KTSugVOS4dY8Rwiadpp2X62ezw1yHN9/B1Hp5Ahy2iuMdlah+kQ1BzrZ2OyOZT1Jz TKZF2a7uh/FelkBbsieLNB52aPJZdhETqALxPQYlRgUwfsoUkvo1bDNnlomKJ3QeEuXc HtAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702569682; x=1703174482; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D+VFIozAF30zEgKKxFDP3drI06z9zzmO3HV6m4SuiwQ=; b=xEzB/6VH2EGCRcjLf1G04ZRXVQqR/aitDUbrNZouxv0Sn5GO/z8cGFAUqVnUTc+e5e cT8M8d7Jmhu0lhhsDh9kBczFC/+P9akHVVqtv69/Y8BJDmTe+tWTdGFxtLnM97I7zdwC FeVc97QoFIbQ82Fj2WI2tAZEnpmCHQckOiPa3CK6P44MuwfmaAkTmFUCCB6By+fid0jf ZFecAcvMRzXy43sQHgm2JiTf4LCYv2SwMr0FXeY4CB0sQQlehDHyqNMeCTwDz31GYHZI T80cg6GM+clFPR1me99rPbCBt5PkTQppgl5o7agQ4VCVZDEWMPDLocF80pn+0DsnBgMa G9Kg== X-Gm-Message-State: AOJu0Yy+SAAtgD71eJo55Rj8CHuVF3kXJFdHfjy2PMyy5XocEfWlS4Wx ZIzxVbqYhbxPg5u4ebIDfyH31w== X-Google-Smtp-Source: AGHT+IEMYj7NZTyAlbSayhibN+bIajeem6cYXSSO7+k3rveUzLz3uWXFda+obxiUgnN1c1X2yJymPw== X-Received: by 2002:a17:907:7ea1:b0:a1e:9d8b:1e7b with SMTP id qb33-20020a1709077ea100b00a1e9d8b1e7bmr6017626ejc.69.1702569682045; Thu, 14 Dec 2023 08:01:22 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id ld4-20020a1709079c0400b00a1df88cc7c0sm9445638ejc.182.2023.12.14.08.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Dec 2023 08:01:21 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 16:01:18 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] clk: samsung: gs101: mark PERIC0 IP TOP gate clock as critical Content-Language: en-US To: Sam Protsenko Cc: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, catalin.marinas@arm.com, will@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org References: <20231214105243.3707730-1-tudor.ambarus@linaro.org> <20231214105243.3707730-8-tudor.ambarus@linaro.org> From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 12/14/23 15:37, Sam Protsenko wrote: > On Thu, Dec 14, 2023 at 4:52 AM Tudor Ambarus wrote: >> >> Testing USI8 I2C with an eeprom revealed that when the USI8 leaf clock >> is disabled it leads to the CMU_TOP PERIC0 IP gate clock disablement, >> which then makes the system hang. To prevent this, mark >> CLK_GOUT_CMU_PERIC0_IP as critical. Other clocks will be marked >> accordingly when tested. >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/clk/samsung/clk-gs101.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c >> index 3d194520b05e..08d80fca9cd6 100644 >> --- a/drivers/clk/samsung/clk-gs101.c >> +++ b/drivers/clk/samsung/clk-gs101.c >> @@ -1402,7 +1402,7 @@ static const struct samsung_gate_clock cmu_top_gate_clks[] __initconst = { >> "mout_cmu_peric0_bus", CLK_CON_GAT_GATE_CLKCMU_PERIC0_BUS, >> 21, 0, 0), >> GATE(CLK_GOUT_CMU_PERIC0_IP, "gout_cmu_peric0_ip", "mout_cmu_peric0_ip", >> - CLK_CON_GAT_GATE_CLKCMU_PERIC0_IP, 21, 0, 0), >> + CLK_CON_GAT_GATE_CLKCMU_PERIC0_IP, 21, CLK_IS_CRITICAL, 0), > > This clock doesn't seem like a leaf clock. It's also not a bus clock. > Leaving it always running makes the whole PERIC0 CMU clocked, which > usually should be avoided. Is it possible that the system freezes > because some other clock (which depends on peric0_ip) gets disabled as > a consequence of disabling peric0_ip? Maybe it's some leaf clock which > is not implemented yet in the clock driver? Just looks weird to me > that the system hangs because of CMU IP clock disablement. It's > usually something much more specific. The system hang happened when I tested USI8 in I2C configuration with an eeprom. After the eeprom is read the leaf gate clock that gets disabled is the one on PERIC0 (CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK). I assume this leads to the CMU_TOP gate (CLK_CON_GAT_GATE_CLKCMU_PERIC0_IP) disablement which makes the system hang. Either marking the CMU_TOP gate clock as critical (as I did in this patch) or marking the leaf PERIC0 gate clock as critical, gets rid of the system hang. Did I choose wrong? Thanks, ta > >> GATE(CLK_GOUT_CMU_PERIC1_BUS, "gout_cmu_peric1_bus", >> "mout_cmu_peric1_bus", CLK_CON_GAT_GATE_CLKCMU_PERIC1_BUS, >> 21, 0, 0), >> -- >> 2.43.0.472.g3155946c3a-goog >>