From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBDD37BE84 for ; Mon, 27 Apr 2026 07:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274450; cv=none; b=IYQqM8qklOvCvfFStP3bW3pARJVpBH02LCdwOVqx4YhS5CxHm48MK3JbgMIN0UHkBl/BLTBHeo/hxwn+xZokbG80u9Ae9CRFRKXWHkmEdfc82PgG0Si3xoLKO3n2u9XIGNcPs2OHc2JaYTa9E9Pqi8B6NyXTvIaYw3lhzq55Xzg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274450; c=relaxed/simple; bh=o9f762Gf9TU4Xcf3RUmv4xe1w+G1LPDPNbt+IgF6tjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uGFrAzwiALB2eptpP9rLlKz1YJzRlSw0Bb6zitUtmiTzRO95IRP5oF4cnxGxp5C/vCrX/o3Pd4I5yB5IMcNMll73bOQWLi5dSHkie97yd2rcxHhLjsUeZ8BkYaX+6g9aW70YwYsJHiM/6jy5vFLkBIl6hySOetOFNT5bRkDqmi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KIMErKLP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OyW2NfiY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KIMErKLP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OyW2NfiY" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63QNgrh42540636 for ; Mon, 27 Apr 2026 07:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=KIMErKLPlETn3HjY tQNcunp5B8oH67/o/f6xIg/G0QtRFQCrR5oyZ3PL5CFl+rTr0D2tLnMLC16sMPGB TcrdJufvPgRux5+3PqPGblfGIY9yXhqVvpUTcqO/UkK1/5KGd4gBUZWxY92V8cVj G0lSN4MNK5jRDNkHekrNFvfpt3bdMMUZDgNCpz2cnJ3v7L3r9aQrbM2YXYDyAodP efIfc/YutxSBHG9x49MFtCTCGtZCdhhiioMvnPBpaFG8ZuX98H/lUJCgrqepcu3t Q1m/ran42opvHcDWAiR/y3V9J0xeDgfB6nDugHQL6gcouk0DdZ34uOjkgb9zhxnz M+LLeA== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drnmr4vkh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 07:20:47 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b454cac322so93323765ad.2 for ; Mon, 27 Apr 2026 00:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777274446; x=1777879246; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=OyW2NfiYPNKpY9nYPKXpfkmaaRwj1DAZSqfmXlkSo5MwpLvbPJIHCBb54DFkCeMkWp 4Po57h6UKsufMHsyMKcW+0oBuU/6zV+Vxn7eTH9TJywnP1OU8tEgbwVYULkGKavsn0cp uL+nllcWiHhHEuiH3CQlJ9m8SrYj+d+GTj0GUnENf9HvmKwGdin/q5OQtHuCpe22yc38 egubWOiM5GVAdm1c7frp6RThaQZNR7nblj1Hu+nvwRSJNFat9gZcVTnVKBytWWeE6mvN 07Ct6rwUtwuyrmp1rxdC5E8K5jua16a71AwD0GU8P5K+BDVU51rxiwqjLIs090SU5X0Y M55A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777274446; x=1777879246; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=TkWocppM8HDLStuUYodWzLKU9xPYwVpJlQRih7nazBeKUQvvPEvPCoIo3tTJ4JtURy t4KpDWDz9ZX+0hyOkeeUo9nTPOsNvO+QIkvebpNUCPewtUqkTgt2xub4a78adkdqr/nQ enlcCvhsm36aF0CVsIpnY996CGucEfWpHNCZBp0zIsHNeIi567lb+tsJF4NoUgTS5zxr 8qTESC6hPMuchXtnxcSFf0EaQmsXuuZFEK7/BSHBypCWh7ZinPTdNM7XqtSZc1bhCfmH 9CQ9RFx1mHcoGiZMwKPjq8wbESkrSw6q9AbAkavA84+HIk8cAC+nIwcJk2W71KcOgZb0 Q5og== X-Forwarded-Encrypted: i=1; AFNElJ8xwYBsOvMrUkvVlvPQr0C0SglUDWAQuMeAfqSVS251LeDGe2WPTwCnPneNeStTxMeF1KakMbgm6Yqd@vger.kernel.org X-Gm-Message-State: AOJu0YwLZgwN4ch/drLiYG2pbGixxWFh1suQGcMPHcUNp9h0im1bBAAy ASFWwIC1+3ifAJYafqTKLU03qArIqCuJ9eE75V5z/0nNSEcy7cwD7aaC2YNNEyJEoyHLjjfwRWg KqT1By1M42l3zEWNh1ocnyTfBhdU3aAq6mKIqurq4JD5w562uQgV44PgqsXfA95Lf X-Gm-Gg: AeBDietx3UEE4A+w7oX4e7yZzSxzN8hp1kh7Um33Yyith22/pvJoAAhPRFfjsbYGIFw 449vp2AF5b62yqUht+jc49txkOLjslQs0oU3HfDk8E+Jb9B6ksy8OB1IlLr3rQLD+h+tf0ZjFhH iqijhnzuyhn0Z4HkUZBWe5F9IULovJ/OUoandtpu5zZxe+hDXmwAxYcV/RjdDmRHEbm176gx/CW jNhFpT/kGpt4JyikWGu7mW9IL/4PlQvcy5ExfzUhvNmvlfKRmKcpp/Uu8rwbYiFWpGqJh6DEJ8e nCBI6KTbqUJSi+CISR2eAGIH9GSxxi8Dww149H+DYb5nGCv/VGLXt9moKbtJlnD00TNk0H1gGRZ 7XCNvGAw42KxK+bgGQP6wLeaCUqs74lFcuGpziENenVDbXwT30iYJia60FX/pQA== X-Received: by 2002:a17:903:8c6:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2b5f9eddc7emr446294685ad.16.1777274446571; Mon, 27 Apr 2026 00:20:46 -0700 (PDT) X-Received: by 2002:a17:903:8c6:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2b5f9eddc7emr446294365ad.16.1777274446032; Mon, 27 Apr 2026 00:20:46 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab3ac1fsm315877045ad.70.2026.04.27.00.20.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 00:20:45 -0700 (PDT) Message-ID: Date: Mon, 27 Apr 2026 12:50:40 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE To: Shawn Guo , Herbert Xu Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Bartosz Golaszewski , Deepti Jaggi , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260427010527.230473-1-shengchao.guo@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <20260427010527.230473-1-shengchao.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=aqCCzyZV c=1 sm=1 tr=0 ts=69ef0e4f cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=JrGBsv4J1yBW9PuSV2wA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-GUID: EXnye0zY19y8YQEg_Vb3MZhmqCLQRUfw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA3NyBTYWx0ZWRfX6CrWkLO++6XA rfz+zEII4QuSZKurGLoAqP7waRbxpw9TESPAcFR674hCe35Z7F3QA7s19bvMgNv2sKoGpRxnHbj UhIb1G4/cxtAEITk4kNZ68GmBIFc6jSw2i1j3y6H/8p+jtIpZBNq+qW5gncGYesdEjHUBe3FEF5 O8zM2VcJvb/D5DHskAx8930tsURfBy4F35gCE+TL2tJ0LMEHRPhEy+AVF8PTW+6twYde9TXUSXa JKS39pwLHQhHkn/n0AbjWbctZMYmd9pqE3PudMbZWwVaxRYBxyvwgz/GHuOsxTXRP13MNy0yV68 etTYFalj9oRNYO6XlrYHz0hf0CRMG/SOPQ7PKdIpy7z5gUMc4ALoYoa5OxBu/oHmQsFdVNp/qdk avizdvcU9dEtU2BOxooc2qTCgayRRtrGp5DVGy0da5NGLf3ya+yKcyLIM+i8eD8V4cMELbcffcY sg5o22FLCzQDL4jiC8Q== X-Proofpoint-ORIG-GUID: EXnye0zY19y8YQEg_Vb3MZhmqCLQRUfw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270077 Hi Shawn, On 4/27/2026 6:35 AM, Shawn Guo wrote: > Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC which is > compatible with 'qcom,inline-crypto-engine'. > > Signed-off-by: Shawn Guo > --- > Changes in v2: > - Improve commit log to make the compatibility explicit > - Link to v1: https://lore.kernel.org/all/20260420073301.1250197-1-shengchao.guo@oss.qualcomm.com/ > > .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > index 876bf90ed96e..9251db2b8fcd 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > @@ -16,6 +16,7 @@ properties: > - qcom,eliza-inline-crypto-engine > - qcom,kaanapali-inline-crypto-engine > - qcom,milos-inline-crypto-engine > + - qcom,nord-inline-crypto-engine Wanted to bring your attention to this patch we are hoping to send for 7.1 fixes window which mandates the iface clock and power-domain for ICE (from Eliza/Milos onwards) to avoid issues seen when these properties are missing: https://lore.kernel.org/all/20260416-qcom_ice_power_and_clk_vote-v5-1-5ccf5d7e2846@oss.qualcomm.com/ While I won't ask you to adjust your patch immediately, if our patch is merged, would request you to update this binding to comply with the newly introduced ones such that the iface clock and power-domain are made mandatory for Nord as well. Regards, Harshal