From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D294152E13 for ; Thu, 11 Jul 2024 09:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720691511; cv=none; b=Rf+5dFXYyzvPOoOhHTb6vk3bpHE7vhna/LoaesaG+7d13+bzmHbLGvlNLZSOjsvicmQuUAOWBCU7dWyU0jFqipikfQhIcAeabjgPaSm47NB5DgcJ5+REg0yCLO010oRwFGmCOWNXlHUe4iNM/SOJTt9Pqt1J23P8KEPlxfjIbQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720691511; c=relaxed/simple; bh=6W/qVczYJkuz3Z8DNHsspunOTZVIxcTUdrjw9u/h48E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kMt4zZc3YrG19uxvlmvkqUheZ4nSi3QcOMRQGTOqYN+ocGQv0D/uQ4ZTEvfQXAmkNmtjiqfx3o5e3U0GKHNAAIBpIFwhmYCyIzcuxRX2T/RTqzULQsAWEprmYCP7E6Ov/kgwM63ZP3GiNjSbBvC4gZXY0CvTKhE30+hybrYtYqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DANXKutz; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DANXKutz" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-42679f33fefso4518895e9.2 for ; Thu, 11 Jul 2024 02:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720691508; x=1721296308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p4smDoC8Q8mWiYpTnz73mXw1qS9kVwzA6CajD1cC+rw=; b=DANXKutzYjdK7YMIIU2/uRYJQOBKdH9z4XEXz3WWyFgEMmIr5YOHqNToBg+454eo3e IzptyStDAd9Z8sHwxecJuLsgtrNYwL+gh8aVy5fDXoDA8AeVAmQDPNTUt6Zp1rwf7wIo Ixaug0kgOmnW+AUaPar+u4QKrBPqvJzXf9+WIzfGtUANmILxxqyrOTAv39TyEZIpu5ZI SCLysRR7aOz8+8EfCi//XY+RBYYbZFIAY2+V4UjiLhWHZTX198XzD8E2gwxyS9vF/yOr QVXNStei7cHeffZbbagp7/L+R6uH5FDIWJskNTcD+1s3S61IWEJPIjvd5CyHtMK7FBfV ahDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720691508; x=1721296308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p4smDoC8Q8mWiYpTnz73mXw1qS9kVwzA6CajD1cC+rw=; b=ghaXubTxB+12Ph+IPEuZml9sQL+N7rwdd3nDGDAwUDu/iktHd/dg9/05pyQn+st+/L mmIdvlgsHwjwHBHVFqi6UMuEeOBC2snV57Wmp9sh2dK7ZBj4ZhzUr/oloB0WqsWH5W4B loymio44OUw+yqgazKjA9UXHbkiZTwejc6WWG0OnZV0PIAmlElpvh+n0ZbqOgRjlT1kt L7/w63LlTyIDUC2/EbgqagpYJvTdNO3vLOpP+ghryY4OwyJbzkO2DoTYkvbfAaUEI7Hj 89dB2qpJG0jULBeC878VyDPpswNTKcf+eeHkWGLJZzb+AvmEKdS50h5oxow0GEm3Zj4V vZaA== X-Forwarded-Encrypted: i=1; AJvYcCVPHiSyq9iCH0YHVNq/s2e05/ikFWEt1lzGgtYYzm6UJNlycIpoCo2s//OTyKMXCoZOFIsnMNUJVUDgv76pSsVbjdSbl70WWOEEWA== X-Gm-Message-State: AOJu0Yw70CxngB8/+qWUh4Y/lTOjZOpKBCu0JDo58ZxDGOgXqujPBBB6 4n+rtjfdyi/4T0SbOcK3uKyX0iflA8SYMCBvizDna3fpZEIdXCH8QyiUblugxZDABc7ApOSqx4P NOKE= X-Google-Smtp-Source: AGHT+IFtPH1XXTzpe+ZeiotMiBUKnIw0rtLtXdrEEVTNTDfCBJZjKL4CcUCeuZDut/QwViYvR4OaUg== X-Received: by 2002:adf:ea8d:0:b0:367:99fd:a9a8 with SMTP id ffacd0b85a97d-367cea73735mr5694718f8f.26.1720691507676; Thu, 11 Jul 2024 02:51:47 -0700 (PDT) Received: from [192.168.0.16] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-367cde7e19dsm7274556f8f.15.2024.07.11.02.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Jul 2024 02:51:47 -0700 (PDT) Message-ID: Date: Thu, 11 Jul 2024 10:51:48 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] clk: qcom: Add camera clock controller driver for SM8150 To: Dmitry Baryshkov , "Satya Priya Kakitapalli (Temp)" Cc: Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Abhishek Sahu , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Ajit Pandey , Imran Shaik , Taniya Das , Jagadeesh Kona References: <20240702-camcc-support-sm8150-v2-0-4baf54ec7333@quicinc.com> <20240702-camcc-support-sm8150-v2-5-4baf54ec7333@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/07/2024 23:10, Dmitry Baryshkov wrote: >>> - Why is cam_cc_gdsc_clk not modelled in the clock framework? >> >> This clock is kept enabled from probe, hence not required to be modelled >> explicitly. > Yes, I'm asking why it's kept up enabled from probe rather than via > clock framework? FWIW my preference is to do it as Dmitry is suggesting here. I'm not a big fan of hitting the register and leaving it as-is, would much prefer to move to the model of having the CCF do it - so that for example the clock appears in the /sys clock summary. --- bod