From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABDD6C7EE29 for ; Fri, 9 Jun 2023 09:24:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239234AbjFIJYO (ORCPT ); Fri, 9 Jun 2023 05:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240985AbjFIJXr (ORCPT ); Fri, 9 Jun 2023 05:23:47 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9A9549FA for ; Fri, 9 Jun 2023 02:18:04 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2b1b084620dso16563951fa.0 for ; Fri, 09 Jun 2023 02:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686302230; x=1688894230; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cdOMZOFFK46XMQWHJQR/JNKfoVWF5Xuwowhgn1zGCvg=; b=Mm8gNGYpStPF+iQ4QjxKSa39Z4C7KdUmTYszNraI0kz4arWFCaIRAnq3VhMvXAQ/0D PHhpTweQN70rwWxlAzsyhhnrIKryeGmB0ndZi7/9me0OYJO4oM3SdCMrSuiDNIQ7iUJs Gr3iDmjY03z8cErtzS8upas+avQS2iyGcw5iOP4FfbnICHGwCBIrFy6pE5vR+V5LYKtL 06mOqO4O56AA5UklVoDStlMbxqVsTBmIPRyD155Lyj8m0DLTya3JadOnuYbMKQfh3rI/ w4qRF1xkFRVa8olthy96IVSyUB1mDa+fTsnd7CEQZEHrWOqia4i8lIiTekY0mFEsuZxC Psmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686302230; x=1688894230; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdOMZOFFK46XMQWHJQR/JNKfoVWF5Xuwowhgn1zGCvg=; b=WcUkXdFzH95JZDdWDixlKlDHSSInWKWpYv5J6ktOL0ueTmXLhUepjWC6TBna3SfPZt ZWM/xp8TLqXLA4z/A8Qecjnbb7id5UpFjhGbRYVXDTxWd/f47de9dS3WCza7oaeIa4Wq w0cmeZwyxCZseLpyRbb0lNuL3l0XK0co96+4TG0wVa03r41ODov5HYvrBAoLHUMdPBe6 zBRPEVYzKb2O1rtJO11qbwyfetp95u6hCvsNqfce3uWCXgkZcnv+t3Tn+iGbeHzi9z3g klZtdV+6lxlOYNDi6f2umBb5HCzVVQJQOFyvKiU7SZ3zklxhfGpQsH3N+lFhpsT8oCA5 rRNw== X-Gm-Message-State: AC+VfDzTD2rZ8VKPWQHMSfR8sdLiclXiBiUGlua2T49Yv6bwVCVI5tjQ i6FEmMmPJbsTPUJGhixE8+ljXw== X-Google-Smtp-Source: ACHHUZ5z73R2zFNnCer+RMV1zZqn9H/fLIsIv+bZQWOcA7XTkZ3bXhfJq9Jda7zGqPuFoVUM9SDfNQ== X-Received: by 2002:a05:6512:521:b0:4f3:bbe1:34fc with SMTP id o1-20020a056512052100b004f3bbe134fcmr565962lfc.38.1686302230232; Fri, 09 Jun 2023 02:17:10 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id j8-20020ac25508000000b004eb44c2ab6bsm477216lfk.294.2023.06.09.02.17.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:17:09 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:17:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v3 4/5] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SDX75 compatible Content-Language: en-US To: Pavan Kondeti , Rohit Agarwal Cc: agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, rafael@kernel.org, viresh.kumar@linaro.org, tglx@linutronix.de, maz@kernel.org, mani@kernel.org, robimarko@gmail.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <1686138469-1464-1-git-send-email-quic_rohiagar@quicinc.com> <1686138469-1464-5-git-send-email-quic_rohiagar@quicinc.com> <20230609050052.GA472607@hu-pkondeti-hyd.qualcomm.com> From: Konrad Dybcio In-Reply-To: <20230609050052.GA472607@hu-pkondeti-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 9.06.2023 07:00, Pavan Kondeti wrote: > On Wed, Jun 07, 2023 at 05:17:48PM +0530, Rohit Agarwal wrote: >> Add compatible for EPSS CPUFREQ-HW on SDX75. >> >> Signed-off-by: Rohit Agarwal >> Acked-by: Viresh Kumar >> --- >> Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> index a6b3bb8..866ed2d 100644 >> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml >> @@ -36,6 +36,7 @@ properties: >> - qcom,sa8775p-cpufreq-epss >> - qcom,sc7280-cpufreq-epss >> - qcom,sc8280xp-cpufreq-epss >> + - qcom,sdx75-cpufreq-epss >> - qcom,sm6375-cpufreq-epss >> - qcom,sm8250-cpufreq-epss >> - qcom,sm8350-cpufreq-epss > > This is a very basic question, not completely related to this patch. > Apologies in advance. > > What is the rationale for adding a new soc string under compatible and > using it in the new soc device tree? Is it meant for documentation purpose? > i.e one know what all SoCs / boards supported by this device node. It's two-fold: 1. The device tree describes the hardware, and for lack of better terms (e.g. an SoC-specific version number of the block that is identical to all other implementations of that revision on all SoCs that use it), we tend to associate it with the SoC it's been (first) found on. 2. In case we ever needed to introduce a SoC-specific quirk, we can just add an of_is_compatible-sorta check to the driver and not have to update the device trees. This is very important for keeping backwards compatibility, as it's assumed that not everybody may be running the latest one. This means we have to avoid ABI breaks (unless we have *very* good reasons, like "this would have never worked anyway" or "it was not described properly and worked on this occasion by pure luck") Konrad > > I ask this because, we don't add these compatible strings in the driver > [1] which means there is not SoC specific handling and there is no > module load assist (module alias matching by user space based on device > presence). > > Thanks, > Pavan