From: Andrew Lunn <andrew@lunn.ch>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Wasim Nazir <quic_wasimn@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v5 5/6] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3
Date: Tue, 31 Dec 2024 06:10:15 +0100 [thread overview]
Message-ID: <f44b98c2-a0b5-4aec-a84e-683d4576a70e@lunn.ch> (raw)
In-Reply-To: <7de40e71-e2e5-49fd-93a3-245afdef8188@oss.qualcomm.com>
> > +ðernet0 {
> > + phy-mode = "2500base-x";
> > +};
> > +
> > +ðernet1 {
> > + phy-mode = "2500base-x";
> > +};
> > +
> > +&mdio {
> > + compatible = "snps,dwmac-mdio";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + sgmii_phy0: phy@8 {
> > + compatible = "ethernet-phy-id31c3.1c33";
> > + reg = <0x8>;
> > + device_type = "ethernet-phy";
> > + interrupts-extended = <&tlmm 7 IRQ_TYPE_EDGE_FALLING>;
> > + reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>;
> > + reset-assert-us = <11000>;
> > + reset-deassert-us = <70000>;
> > + };
> > +
> > + sgmii_phy1: phy@0 {
SGMII is 10/100/1000. You have a phy-mode of 2500base-x, which is only
2500. So calling this sgmii_phy is wrong. Just call it phy1: phy@0.
Andrew
next prev parent reply other threads:[~2024-12-31 5:10 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 15:23 [PATCH v5 0/6] arm64: qcom: Add support for QCS9075 boards Wasim Nazir
2024-12-29 15:23 ` [PATCH v5 1/6] dt-bindings: arm: qcom,ids: add SoC ID for QCS9075 Wasim Nazir
2024-12-29 15:23 ` [PATCH v5 2/6] soc: qcom: socinfo: add QCS9075 SoC ID Wasim Nazir
2024-12-29 15:23 ` [PATCH v5 3/6] dt-bindings: arm: qcom: Document rb8/ride/ride-r3 on QCS9075 Wasim Nazir
2024-12-29 15:23 ` [PATCH v5 4/6] arm64: dts: qcom: Add support for QCS9075 RB8 Wasim Nazir
2025-05-06 12:08 ` Dmitry Baryshkov
2025-05-06 12:29 ` Wasim Nazir
2025-05-06 12:30 ` Dmitry Baryshkov
2025-05-06 13:14 ` Wasim Nazir
2025-05-09 22:56 ` Konrad Dybcio
2024-12-29 15:23 ` [PATCH v5 5/6] arm64: dts: qcom: Add support for QCS9075 Ride & Ride-r3 Wasim Nazir
2024-12-30 15:32 ` Konrad Dybcio
2024-12-31 5:10 ` Andrew Lunn [this message]
2025-01-02 9:13 ` Wasim Nazir
2024-12-30 15:45 ` Dmitry Baryshkov
2025-01-02 9:07 ` Wasim Nazir
2025-01-03 5:50 ` Dmitry Baryshkov
2025-01-03 7:07 ` Wasim Nazir
2025-01-03 10:31 ` Dmitry Baryshkov
2025-01-03 18:59 ` Wasim Nazir
2025-01-03 19:58 ` Dmitry Baryshkov
2025-01-08 14:09 ` Krzysztof Kozlowski
2025-01-09 14:47 ` Wasim Nazir
2025-01-09 15:03 ` Wasim Nazir
2025-01-09 16:16 ` Krzysztof Kozlowski
2025-01-15 5:48 ` Wasim Nazir
2025-01-15 8:35 ` Krzysztof Kozlowski
2025-02-27 7:37 ` Wasim Nazir
2025-03-03 7:46 ` Krzysztof Kozlowski
2025-03-06 8:17 ` Wasim Nazir
2025-03-06 8:25 ` Wasim Nazir
2025-03-11 8:02 ` Krzysztof Kozlowski
2025-03-20 11:45 ` Wasim Nazir
2025-03-29 4:48 ` Krzysztof Kozlowski
2025-04-02 6:48 ` Wasim Nazir
2025-03-11 7:59 ` Krzysztof Kozlowski
2025-01-09 13:52 ` Wasim Nazir
2025-01-06 23:59 ` Bjorn Andersson
2025-01-09 13:36 ` Wasim Nazir
2024-12-29 15:23 ` [PATCH v5 6/6] arm64: dts: qcom: Enable cpu cooling devices for QCS9075 platforms Wasim Nazir
2024-12-30 6:02 ` Aiqun(Maria) Yu
2024-12-30 15:35 ` Konrad Dybcio
2024-12-31 11:05 ` Manaf Meethalavalappu Pallikunhi
2024-12-31 16:21 ` Konrad Dybcio
2025-01-08 12:10 ` Manaf Meethalavalappu Pallikunhi
2024-12-30 15:40 ` Dmitry Baryshkov
2024-12-31 12:01 ` Manaf Meethalavalappu Pallikunhi
2025-01-03 5:51 ` Dmitry Baryshkov
2025-01-08 12:27 ` Manaf Meethalavalappu Pallikunhi
2025-01-08 12:46 ` Dmitry Baryshkov
2025-01-08 16:08 ` Manaf Meethalavalappu Pallikunhi
2025-01-09 14:30 ` Konrad Dybcio
2025-01-09 23:54 ` Dmitry Baryshkov
2025-01-10 12:31 ` Konrad Dybcio
2025-01-13 8:43 ` Dmitry Baryshkov
2025-01-14 19:16 ` Manaf Meethalavalappu Pallikunhi
2025-01-15 8:54 ` Dmitry Baryshkov
2024-12-30 18:17 ` [PATCH v5 0/6] arm64: qcom: Add support for QCS9075 boards Rob Herring (Arm)
2025-01-07 16:38 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f44b98c2-a0b5-4aec-a84e-683d4576a70e@lunn.ch \
--to=andrew@lunn.ch \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_wasimn@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).