From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Sergio Pérez" <sergio@pereznus.es>, linux-iio@vger.kernel.org
Cc: tduszyns@gmail.com, jic23@kernel.org, lars@metafoo.de,
robh@kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] iio: light: bh1750: Add hardware reset support via GPIO
Date: Thu, 20 Mar 2025 08:18:48 +0100 [thread overview]
Message-ID: <f4556511-3123-4131-af2f-c4044302979e@kernel.org> (raw)
In-Reply-To: <4474831c-a8f6-496e-8348-a10e3fb7c798@pereznus.es>
On 19/03/2025 17:26, Sergio Pérez wrote:
>
> El 19/03/2025 a las 9:46, Krzysztof Kozlowski escribió:
>> On 18/03/2025 18:37, Krzysztof Kozlowski wrote:
>>>> I've now run the tool correctly on my patch file and have fixed the
>>>> identified issues:
>>>> - Removed trailing whitespace
>>>> - Fixed lines exceeding 79 characters
>>>> - Fixed the inconsistency between the description and example for
>>>> reset-gpios
>>>> - Modified the existing example instead of adding a new one
>>>> - Ensured proper line endings and formatting
>>>> - Used proper get_maintainers.pl to include all recipients
>>>>
>>> Please read the guides carefully. The process is extremely simple as:
>>>
>>> git add ...
>>> git commit --signed-off
>>> git format-patch -v3 -2
>>> scripts/chekpatch.pl v3*
>>> scripts/get_maintainers.pl --no-git-fallback v3*
>>> git send-email *
>> Please read this again. I gave you detailed instruction which you still
>> decided not to follow. The instructions are quite precise on purpose,
>> because other method leads to wrong patchset - broken that or other way.
>>
> I transcribe exactly the commands I have executed:
>
> $ git add Documentation/devicetree/bindings/iio/light/bh1750.yaml
>
> $ git commit --signed-off
>
> $ git add drivers/iio/light/bh1750.c
>
> $ git commit --signed-off
>
> $ git format-patch -v3 -2
So v3 or v4 or v5? After this email (dated 18th March), you sent v4, two
hours later not following mentioned process.
And then yesterday you sent v3 again, why this is supposed to be v5.
Read the help of these commands, instead of copying them blindly without
thinking. Every version is v3?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-20 7:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250316145514.627-1-sergio@pereznus.es>
[not found] ` <01f48f6d-55a4-4dbe-b1ae-ef8c54dcc1ff@kernel.org>
[not found] ` <64182937-29e9-45dc-aa2f-5f2b739056a1@me.com>
2025-03-18 13:28 ` [PATCH] iio: light: bh1750: Add hardware reset support via GPIO Krzysztof Kozlowski
2025-03-18 14:16 ` Sergio Pérez
2025-03-18 15:16 ` Krzysztof Kozlowski
2025-03-18 16:06 ` Sergio Pérez
2025-03-18 16:21 ` Krzysztof Kozlowski
2025-03-18 16:23 ` Krzysztof Kozlowski
2025-03-18 17:26 ` Sergio Pérez
2025-03-18 17:37 ` Krzysztof Kozlowski
2025-03-18 19:51 ` Sergio Pérez
2025-03-20 7:15 ` Krzysztof Kozlowski
2025-03-19 8:46 ` Krzysztof Kozlowski
2025-03-19 16:26 ` Sergio Pérez
2025-03-20 7:18 ` Krzysztof Kozlowski [this message]
[not found] ` <20250317115815.2416c741@jic23-huawei>
2025-03-18 14:35 ` Sergio Pérez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4556511-3123-4131-af2f-c4044302979e@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sergio@pereznus.es \
--cc=tduszyns@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox