From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Franklin S Cooper Jr <fcooper@ti.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-can@vger.kernel.org,
wg@grandegger.com, mkl@pengutronix.de, robh+dt@kernel.org,
quentin.schulz@free-electrons.com,
dev.kurt@vandijck-laurijssen.be, andrew@lunn.ch
Subject: Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate
Date: Thu, 20 Jul 2017 09:43:18 +0200 [thread overview]
Message-ID: <f45ea1b4-0f46-0002-a89b-b997f2693bb5@hartkopp.net> (raw)
In-Reply-To: <20170719233654.25908-2-fcooper@ti.com>
Hi Franklin,
On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote:
> +#ifdef CONFIG_OF
> +void of_transceiver_is_fixed(struct net_device *dev)
> +{
(..)
> +}
> +EXPORT_SYMBOL(of_transceiver_is_fixed);
> +#endif
I'm not sure about the naming here.
As this is a CAN transceiver related option it should be named accordingly:
E.g.
can_transceiver_is_fixed
of_can_transceiver_is_fixed
...
Especially as it is defined in include/linux/can/dev.h
Regards,
Oliver
next prev parent reply other threads:[~2017-07-20 7:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 23:36 [PATCH 0/4] can: Add new binding to limit bit rate used Franklin S Cooper Jr
2017-07-19 23:36 ` [PATCH 1/4] can: dev: Add support for limiting configured bitrate Franklin S Cooper Jr
2017-07-20 7:43 ` Oliver Hartkopp [this message]
2017-07-20 15:55 ` Franklin S Cooper Jr
2017-07-26 20:04 ` Kurt Van Dijck
2017-07-27 1:44 ` Franklin S Cooper Jr
[not found] ` <20170719233654.25908-2-fcooper-l0cyMroinI0@public.gmane.org>
2017-07-20 9:52 ` Sergei Shtylyov
[not found] ` <b04fea5c-c47b-4643-5305-090f5f17afe1-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2017-07-20 15:59 ` Franklin S Cooper Jr
2017-07-19 23:36 ` [PATCH 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings Franklin S Cooper Jr
2017-07-20 9:45 ` Sergei Shtylyov
2017-07-19 23:36 ` [PATCH 3/4] can: m_can: Update documentation to mention new fixed transceiver binding Franklin S Cooper Jr
[not found] ` <20170719233654.25908-4-fcooper-l0cyMroinI0@public.gmane.org>
2017-07-24 19:50 ` Rob Herring
2017-07-19 23:36 ` [PATCH 4/4] can: m_can: Add call to of_transceiver_is_fixed Franklin S Cooper Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f45ea1b4-0f46-0002-a89b-b997f2693bb5@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=andrew@lunn.ch \
--cc=dev.kurt@vandijck-laurijssen.be \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).