From: Dennis Gilmore <dgilmore@redhat.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
Date: Thu, 01 Jul 2021 07:59:42 -0500 [thread overview]
Message-ID: <f46b234e0aaf4356804d5e1446910bbedcbddb51.camel@redhat.com> (raw)
In-Reply-To: <01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org>
On Thu, 2021-07-01 at 11:31 +0200, Uwe Kleine-König wrote:
> Hello,
>
> On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> > Without the usbdrd_dwc3_1 node defined u-boot will throw an error
> > and
> > reset the system.
>
> I wonder if this should better be fixed in u-boot then?!
>
> > All other rk3399 systems use this format
>
> This is true for the dwc nodes, however for the usb2 nodes there are
> several that use this idiom (and even repeat the label name), see for
> example the &u2phy0 node in
> arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
>
looking at that file is where I got the idea to set it up as I have
proposed, it follows the format I have submitted
Dennis
> In my eyes it's a bit ugly to have the two nodes as separate entities
> and on the same indentation level in the machine dts given that one
> is
> the parent of the other and enabling USB needs both status settings.
>
> Best regards
> Uwe
>
next prev parent reply other threads:[~2021-07-01 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 0:40 [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup Dennis Gilmore
2021-07-01 0:40 ` [PATCH 2/4] arm64: dts: rockchip: helios64: set stdout-path Dennis Gilmore
2021-07-01 0:40 ` [PATCH 3/4] arm64: dts: rockchip: helios64: add SPI support Dennis Gilmore
2021-07-01 0:40 ` [PATCH 4/4] arm64: dts: rockchip: helios64: enable tsadc on helios64 Dennis Gilmore
2021-07-01 9:31 ` [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup Uwe Kleine-König
2021-07-01 12:59 ` Dennis Gilmore [this message]
2021-07-01 13:35 ` Uwe Kleine-König
2021-07-01 18:13 ` Dennis Gilmore
2021-07-01 9:32 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f46b234e0aaf4356804d5e1446910bbedcbddb51.camel@redhat.com \
--to=dgilmore@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).