From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6291141760; Fri, 2 Aug 2024 07:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722583852; cv=none; b=lD9CPKlndPucBeqbfzIAkWi9gegNZAeiLk9W6mL7+53Rno9dbM7fE/DXYergd0Vlg95AzCXo0/fEguCm3nVTi4HrnUsXZnucL2e36h5sLmp00hKkgybCP2VqNVi4zaxgKczVNihEsdekiylyx1kxQy2jLSuLhtvw/fwhRUDCYhc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722583852; c=relaxed/simple; bh=pe7TWTcmpQ9bqof8EtAiy+x4WhaOXrtpfoRztEhO+Q4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Elfl3scmNMgz/bsO+dC/jKuSjjhTUvaSfMh7FI5yPamh5w6kui7NHPVzyuXlcWSAi7YMpGdc5bPAwCbtPSPFoBj7UZn/M4zU7mfHIroo69pFDhz+9LfU78+gT8Yg6um/gcbpCoe8aPY/Iue2TBSjVCi+ZmrPHv4wPJf9RP4jA2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RI1xX5Wz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RI1xX5Wz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93525C32782; Fri, 2 Aug 2024 07:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722583852; bh=pe7TWTcmpQ9bqof8EtAiy+x4WhaOXrtpfoRztEhO+Q4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RI1xX5Wz2YjpzTjMRmbrPCGbJrK5d7fdL+p8YDqHWfKstQ/htzpvXzx0GtQBn+weo GFfaxSdUKaDX0AeO/vzO7YinJEQ1LhkzDPzUaLnOiUz88NxzYXqBdb4P3OqRvEUIUz zL3Rv4jeGl8awxO7Fp9zwlBYybkoSItR1uT30u21TEphP/4CVaEJ8SfAoZxsmLR1QZ qYCcOmLMXHy3blbGiuihF94sbqQiv0MG0T7oIv0GzOT/+UIJ1cKvQ+HYkmts2SGmal 2Z0AamcNgsVKQCEXXk4CSgPENVu35pxmB/SzkwUpQNs4j87nH9NSZG8Xs6dxNcMPAt 8xOCeXWROsVUw== Message-ID: Date: Fri, 2 Aug 2024 09:30:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] dt-bindings: clock: qcom,gcc-sm8450: Add SM8475 GCC bindings To: Danila Tikhonov , andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, p.zabel@pengutronix.de, vkoul@kernel.org, vladimir.zapolskiy@linaro.org, quic_jkona@quicinc.com, dmitry.baryshkov@linaro.org, konradybcio@kernel.org, quic_tdas@quicinc.com Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux@mainlining.org References: <20240731175919.20333-1-danila@jiaxyga.com> <20240731175919.20333-2-danila@jiaxyga.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240731175919.20333-2-danila@jiaxyga.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/07/2024 19:59, Danila Tikhonov wrote: > Add SM8475 GCC bindings, which are simply a symlink to the SM8450 > bindings. Update the documentation with the new compatible. > > Signed-off-by: Danila Tikhonov > --- > .../devicetree/bindings/clock/qcom,gcc-sm8450.yaml | 8 ++++++-- > include/dt-bindings/clock/qcom,gcc-sm8450.h | 2 ++ > include/dt-bindings/clock/qcom,sm8475-gcc.h | 1 + > 3 files changed, 9 insertions(+), 2 deletions(-) > create mode 120000 include/dt-bindings/clock/qcom,sm8475-gcc.h > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > index d848361beeb3..c7d75ee2a23b 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-sm8450.yaml > @@ -13,11 +13,15 @@ description: | > Qualcomm global clock control module provides the clocks, resets and power > domains on SM8450 > > - See also:: include/dt-bindings/clock/qcom,gcc-sm8450.h > + See also:: You can use one : (:: -> :). That was a mistake to use double colons. > + include/dt-bindings/clock/qcom,gcc-sm8450.h > + include/dt-bindings/clock/qcom,sm8475-gcc.h > > properties: > compatible: > - const: qcom,gcc-sm8450 > + enum: > + - qcom,gcc-sm8450 > + - qcom,sm8475-gcc > > clocks: > items: > diff --git a/include/dt-bindings/clock/qcom,gcc-sm8450.h b/include/dt-bindings/clock/qcom,gcc-sm8450.h > index 9679410843a0..5f1f9ab71a22 100644 > --- a/include/dt-bindings/clock/qcom,gcc-sm8450.h > +++ b/include/dt-bindings/clock/qcom,gcc-sm8450.h > @@ -194,6 +194,8 @@ > #define GCC_VIDEO_AXI0_CLK 182 > #define GCC_VIDEO_AXI1_CLK 183 > #define GCC_VIDEO_XO_CLK 184 > +#define GCC_GPLL2 185 > +#define GCC_GPLL3 186 Are these valid for sm8450? > > /* GCC resets */ > #define GCC_CAMERA_BCR 0 > diff --git a/include/dt-bindings/clock/qcom,sm8475-gcc.h b/include/dt-bindings/clock/qcom,sm8475-gcc.h > new file mode 120000 > index 000000000000..daafdd881892 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,sm8475-gcc.h If the bindings are the same... then why having separate header? I suggest dropping it. Best regards, Krzysztof