devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Zev Weiss" <zev@bewilderbeest.net>, "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Joel Stanley" <joel@jms.id.au>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] ARM: dts: aspeed: convert ASRock SPC621D8HM3 NVMEM content to layout syntax
Date: Tue, 04 Jun 2024 11:32:54 +0930	[thread overview]
Message-ID: <f4a891a6548461935129bb8ef4bed68c265567a1.camel@codeconstruct.com.au> (raw)
In-Reply-To: <11f0a9a0-967e-4971-8ca1-4730f2881ee1@hatter.bewilderbeest.net>

On Mon, 2024-06-03 at 18:21 -0700, Zev Weiss wrote:
> On Sun, May 19, 2024 at 11:30:44PM PDT, Rafał Miłecki wrote:
> > From: Rafał Miłecki <rafal@milecki.pl>
> > 
> > Use cleaner (and non-deprecated) bindings syntax. See commit
> > bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
> > details.
> > 
> > Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> > ---
> > .../dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dts     | 12 ++++++++----
> > 1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dts
> > index 555485871e7a..c4097e4f2ca4 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dts
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-spc621d8hm3.dts
> > @@ -110,11 +110,15 @@ eeprom@50 {
> > 		compatible = "st,24c128", "atmel,24c128";
> > 		reg = <0x50>;
> > 		pagesize = <16>;
> > -		#address-cells = <1>;
> > -		#size-cells = <1>;
> > 
> > -		eth0_macaddress: macaddress@3f80 {
> > -			reg = <0x3f80 6>;
> > +		nvmem-layout {
> > +			compatible = "fixed-layout";
> > +			#address-cells = <1>;
> > +			#size-cells = <1>;
> > +
> > +			eth0_macaddress: macaddress@3f80 {
> > +				reg = <0x3f80 6>;
> > +			};
> > 		};
> > 	};
> > 
> > -- 
> > 2.35.3
> > 
> 
> Acked-by: Zev Weiss <zev@bewilderbeest.net>
> 

Thanks, I've applied this to a tree for Joel to pick up.

Andrew

      reply	other threads:[~2024-06-04  2:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-20  6:30 [PATCH] ARM: dts: aspeed: convert ASRock SPC621D8HM3 NVMEM content to layout syntax Rafał Miłecki
2024-05-20 13:59 ` Rob Herring (Arm)
2024-06-04  1:21 ` Zev Weiss
2024-06-04  2:02   ` Andrew Jeffery [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4a891a6548461935129bb8ef4bed68c265567a1.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=rafal@milecki.pl \
    --cc=robh@kernel.org \
    --cc=zajec5@gmail.com \
    --cc=zev@bewilderbeest.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).