From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3648C47088 for ; Sat, 3 Dec 2022 10:44:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiLCKoJ (ORCPT ); Sat, 3 Dec 2022 05:44:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbiLCKoI (ORCPT ); Sat, 3 Dec 2022 05:44:08 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21D8E4218C for ; Sat, 3 Dec 2022 02:44:07 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id x6so8054716lji.10 for ; Sat, 03 Dec 2022 02:44:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VA6bgdS0eWxkTgT0XZ0SoXlx4jS/fw585JN+2qGw6LU=; b=JkYod0TCwxV83odqnX1BI8Nd4HLmNhA21w18fCZuPeRbW5BF5gMZRsztxQU2yxZD15 IX9JscIQJHdBEqSDz8WdAofRaFs7XY6Fz6i/Cbg/APN/Zwn3hXSF7hnsuuTlpgs4ilvy sQ61VmIBiuT+Eeo1L9VHIFTQN8FM2AWk+Xt/ADvxRx4tRdL4gFQrNNp6Vc4xCa4Cr6ak JEeS9QKFoi945AMiu/kZCPpMTiKxkMv69T5rYg78v8u77IDwHc3FzDW2F8pS6NgMG2QM erl2d6HprOJNtkdR/rLHHhfarJHm3/skPewUDi+6Yz5UtM3Qt4wFlKTGYj7PkraXy8oy zTcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VA6bgdS0eWxkTgT0XZ0SoXlx4jS/fw585JN+2qGw6LU=; b=OBzjRPuo/i/BeelKylRctbY6AD80igge8ESNxiO8LBAnb6GK2QsQnBDxOWSpKPzORF TJT9G215SLEy35vf1h2QUy/l2KpPTBQyrC6Yrt0wa2s5px2D3wLvCiyS/JLmZQQB+Gjy 9XwBvU8Bt6/OO3455DoZA+cgh7tQAKM4btAyk0psOygBJQGFDMY6kBCa3FJljLUF4ObN /9NMcMB31/wgIyxJ35VcPKQCvzsDGWKaAQ8HorMx6pmIUR8HUmNm8w7cMEYIgy+u0ir9 JKlSVJl6dk8gb1Jqc3plFieluC4UFNFsLm8LHAFVJCm4n2g4qyXSsvWxii8/kGRYkfRw NHuw== X-Gm-Message-State: ANoB5pllFibQ+c1pd5U6L28s95TQBg/nvcQwlgU55h9mxCHzhsVKs+9N HH4c+NkfZ9/uY0LOIzSH8qeyU6w77Qzrsiidnqw= X-Google-Smtp-Source: AA0mqf65bteWp/5x2VGymOoQTMXDSV6uq3dkYvxgSK7hCEwsZMR8HN1bOyqzRgWw+dQpYM/+lHc/tg== X-Received: by 2002:a2e:a0c2:0:b0:279:95c2:c154 with SMTP id f2-20020a2ea0c2000000b0027995c2c154mr12495316ljm.44.1670064245500; Sat, 03 Dec 2022 02:44:05 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c24-20020a056512239800b004b40c1f1c70sm1351910lfv.212.2022.12.03.02.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Dec 2022 02:44:04 -0800 (PST) Message-ID: Date: Sat, 3 Dec 2022 11:44:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v1 1/2] dt-bindings: leds: add binding for aw200xx Content-Language: en-US To: Dmitry Rokosov Cc: Martin Kurbanov , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Andy Shevchenko , "linux-leds@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , kernel References: <20221124204807.1593241-1-mmkurbanov@sberdevices.ru> <20221124204807.1593241-2-mmkurbanov@sberdevices.ru> <0a9e7d65-4ad7-b753-ec9b-8e58a549b5db@sberdevices.ru> <620b19f5-2202-21a5-7e3b-816dcd42d1b4@linaro.org> <20221202185308.zh5kesfxvyrco2cr@CAB-WSD-L081021> From: Krzysztof Kozlowski In-Reply-To: <20221202185308.zh5kesfxvyrco2cr@CAB-WSD-L081021> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 02/12/2022 19:53, Dmitry Rokosov wrote: > Hello Krzysztof, > > On Fri, Dec 02, 2022 at 05:41:37PM +0100, Krzysztof Kozlowski wrote: >> On 28/11/2022 18:43, Martin Kurbanov wrote: >>> Hi. Thank you for quick reply. >>> >>> On 25.11.2022 11:29, Krzysztof Kozlowski wrote: >>>>> + >>>>> + imax: >>>>> + maxItems: 1 >>>>> + description: >>>>> + Maximum supply current, see dt-bindings/leds/leds-aw200xx.h >>>> >>>> No. Use existing properties from common.yaml. This looks like >>>> led-max-microamp and it is per LED, not per entire device. >>> >>> The AW200XX LED chip does not support imax setup per led. >>> Imax is the global parameter over the all leds. I suppose, it's better >>> to add vendor prefix or take minimum from all subnodes? >>> How do you think? >> >> Have in mind that led-max-microamp is a required property in some cases, >> so skipping it and using per-device properties does not solve the >> problem of adjusting proper currents. What if each LED you set for >> something which in total gives more than your imax? >> > > You are right. From my point of view too, we must build our solutions from > HW capabilities. And there was no proposal to go around HW capabilities. We talk only about representation. > In the current situation, AW200XX chips support global > Imax value, so it's acceptable decision to use vendor prefix for global > imax parameter, why not? Jacek made his statement some time ago quite clear: https://lore.kernel.org/all/5785F17D.3010108@samsung.com/ "If you question the idea of having different maximum brightness per sub-LEDs controlled by the same device, then it means that you have objections to the entire idea of LED subsystem max_brightness property, whereas it has been broadly accepted and successfully used for years." Best regards, Krzysztof