From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Aakarsh Jain <aakarsh.jain@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: andrzej.hajda@intel.com, mchehab@kernel.org,
hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar,
jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com,
krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com,
smitha.t@samsung.com
Subject: Re: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC
Date: Thu, 3 Nov 2022 08:46:10 -0400 [thread overview]
Message-ID: <f4ca26c6-6c03-b7e7-3d5e-f6bc42c3a785@linaro.org> (raw)
In-Reply-To: <aadbb452-506d-89cc-28d9-497369c0018e@samsung.com>
On 03/11/2022 08:44, Marek Szyprowski wrote:
> On 03.11.2022 13:35, Krzysztof Kozlowski wrote:
>> On 02/11/2022 09:06, Aakarsh Jain wrote:
>>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for
>> Please run scripts/checkpatch.pl and fix reported warnings.
>>
>>> Exynos3250 and used the same compatible string as used by
>>> Exynos5240 but both the IPs are a bit different in terms of
>>> IP clock.
>>> Lets add variant driver data based on the new compatible string
>>> "samsung,exynos3250-mfc" for Exynos3250 SoC.
>> Aren't you just missing the clock on Exynos3250?
>
> Nope, the Exynos3250 variant indeed has only one clock and the driver
> code simply ignored the -ENOENT error while getting the clocks, see the
> code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it
> worked fine even without it.
>
> IMHO it is a good idea to clean this up.
OK, then please make the new compatible followed by old.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-03 12:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221102125810epcas5p36e6caf41f602debe17f25f13969fd6dc@epcas5p3.samsung.com>
2022-11-02 13:06 ` [PATCH 1/3] arm64: exynos: Add new compatible string for Exynos3250 SoC Aakarsh Jain
[not found] ` <CGME20221102125813epcas5p40a38f17a267276ff8b2bc5861b5d450d@epcas5p4.samsung.com>
2022-11-02 13:06 ` [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC Aakarsh Jain
2022-11-03 10:54 ` Tommaso Merciai
2022-11-03 12:35 ` Krzysztof Kozlowski
2022-11-03 12:44 ` Marek Szyprowski
2022-11-03 12:46 ` Krzysztof Kozlowski [this message]
2022-11-09 4:02 ` Aakarsh Jain
[not found] ` <CGME20221102125816epcas5p23e16fefd6b820e7dd7d9a93f0d48f40d@epcas5p2.samsung.com>
2022-11-02 13:06 ` [PATCH 3/3] arm64: dts: exynos: Rename compatible string property from version to SOC specific Aakarsh Jain
2022-11-03 10:56 ` Tommaso Merciai
2022-11-03 12:33 ` Krzysztof Kozlowski
2022-11-04 10:49 ` Aakarsh Jain
2022-11-04 12:53 ` Krzysztof Kozlowski
2022-11-03 9:24 ` [PATCH 1/3] arm64: exynos: Add new compatible string for Exynos3250 SoC Marek Szyprowski
2022-11-03 10:41 ` Tommaso Merciai
2022-11-03 12:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ca26c6-6c03-b7e7-3d5e-f6bc42c3a785@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=smitha.t@samsung.com \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).