From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A37FFC433FE for ; Thu, 3 Nov 2022 12:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231650AbiKCMqQ (ORCPT ); Thu, 3 Nov 2022 08:46:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230370AbiKCMqN (ORCPT ); Thu, 3 Nov 2022 08:46:13 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C15711162 for ; Thu, 3 Nov 2022 05:46:13 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id x15so1080436qtv.9 for ; Thu, 03 Nov 2022 05:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yGm7wbTciWDJS7qmpqQ3ufS50mFVa2yb9x+7BoqLpII=; b=qDuHKKPzpdz33t7ixNmaA5Jq4D6VNL+K147HV/FEkQB+NvN2GLYXD3q+G1n/EhyydT mc+amok9gUlQCoub6CBSQucIgTAMH7XVSeOD8nnKS8+U9dHbXKKTpgn2q829hOucW2qW boslcXZcvJmnXbE40+x56mqW3z78ORvK2F3/8T3Vn0GRYP0Hcy/w+5HiYLc0HfWWj/DG 4rwXkQCdXw2Fz5I+J5HsqkVrs+oN2sixOEnI21i36bWG8Kd/rkumxLY4+VYH0FH264Dg yUTzSrN9RwMVBWY2IAgvqS0rMaL2sITwou3TZAeGG7D2q/YFQqiawwA/jAEb4S41JsZT 93bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yGm7wbTciWDJS7qmpqQ3ufS50mFVa2yb9x+7BoqLpII=; b=XFIxl1s8HmcRyFkfDOMqpgntYWlDmwZdgXtqrNe7o4l9wuUiPb6jsSKatmOytWsB8v OkVuJfs6vrxJ9fTzdHDrXSuEyYacZsqp8rRXvuILN9qw06A8afnuC88qdwn+rbQf85Qt HZPGF/069mFlygUWy/WJPOlvN3USd2jaGlZwxP5K+fM98EEXO5EP/D+4rKSwrmXpihUZ d9kC69pM1USrjE5qVDMxowzUV/gfiZIcI6wbkZJZDIXOpJe7ZkCbZ04g9c2JZVEFegUl 4LnIkm6+sZvQ3WzYZqSRsqXF7WOuzrnWNnRxFsvtle2GT1RGzcAWhTL1vjAN4YLpRahm 5kpQ== X-Gm-Message-State: ACrzQf0z3xBecfcPrV8fJmmVwOzUFoutyEs6JSh+SHut7yDtJAaGaVKs ZIG0ADCIN/g1A3Yf9uNTPlTPrg== X-Google-Smtp-Source: AMsMyM7qSGREB3yZtzh4NB3yiFrMVNwRE3iO2Jdqd329JikQegHzwdbB8mxPOwlUSvCzLS9OKhKiww== X-Received: by 2002:a05:622a:181:b0:3a5:492b:c3af with SMTP id s1-20020a05622a018100b003a5492bc3afmr6142031qtw.383.1667479572295; Thu, 03 Nov 2022 05:46:12 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id fc11-20020a05622a488b00b00399d5d564b7sm454947qtb.56.2022.11.03.05.46.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 05:46:11 -0700 (PDT) Message-ID: Date: Thu, 3 Nov 2022 08:46:10 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 2/3] media: s5p-mfc:Add variant data for MFC v7 hardware for Exynos 3250 SOC Content-Language: en-US To: Marek Szyprowski , Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221102130602.48969-1-aakarsh.jain@samsung.com> <20221102130602.48969-2-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/11/2022 08:44, Marek Szyprowski wrote: > On 03.11.2022 13:35, Krzysztof Kozlowski wrote: >> On 02/11/2022 09:06, Aakarsh Jain wrote: >>> commit "5441e9dafdfc6dc40fa" which adds mfc v7 support for >> Please run scripts/checkpatch.pl and fix reported warnings. >> >>> Exynos3250 and used the same compatible string as used by >>> Exynos5240 but both the IPs are a bit different in terms of >>> IP clock. >>> Lets add variant driver data based on the new compatible string >>> "samsung,exynos3250-mfc" for Exynos3250 SoC. >> Aren't you just missing the clock on Exynos3250? > > Nope, the Exynos3250 variant indeed has only one clock and the driver > code simply ignored the -ENOENT error while getting the clocks, see the > code in drivers/media/platform/samsung/s5p-mfc/s5p_mfc_pm.c, so it > worked fine even without it. > > IMHO it is a good idea to clean this up. OK, then please make the new compatible followed by old. Best regards, Krzysztof