From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1 References: <20190514145605.19112-1-chris.brandt@renesas.com> <20190514145605.19112-5-chris.brandt@renesas.com> From: Sergei Shtylyov Message-ID: Date: Wed, 15 May 2019 11:39:19 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven , Chris Brandt Cc: Rob Herring , Mark Rutland , Greg Kroah-Hartman , Simon Horman , Yoshihiro Shimoda , Chunfeng Yun , USB list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas List-ID: Hello! On 15.05.2019 10:35, Geert Uytterhoeven wrote: >> Document the USB_X1 input and add clock-names to identify >> functional and USB_X1 clocks. >> >> Signed-off-by: Chris Brandt > > Reviewed-by: Geert Uytterhoeven > >> --- a/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt >> +++ b/Documentation/devicetree/bindings/phy/rcar-gen3-phy-usb2.txt >> @@ -28,7 +28,11 @@ Required properties: >> followed by the generic version. >> >> - reg: offset and length of the partial USB 2.0 Host register block. >> -- clocks: clock phandle and specifier pair(s). >> +- clocks: clock phandle and specifier pair(s). For SoCs that have a separate >> + dedicated USB_X1 input for the PLL, that is also listed. >> +- clock-names: Name of the clocks. The functional clock shall be called "fclk" > > Names? And I think the module clock name was "fck", not "fclk"... [...] > Gr{oetje,eeting}s, > > Geert MBR, Sergei