From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C4523ED5B for ; Sat, 6 Dec 2025 22:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765059086; cv=none; b=XZelDN6kIP1UNopBUzjq8vm6OCYq49cGSnAX9CYa/CHdVWmd62thL3nZFvmXRpsKsjaJS7CFcKHyZpQp8rQ7v1sMzen8q54xhHdStCpKAR0pNx3zjhuH9jG8E9eFm+tVOVtG4yoZWDAbhv0tbdipMWB6SMl72DfzuIfMjmKS6+s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765059086; c=relaxed/simple; bh=llGFQSxa+VBz3XIigaBz4RTXnirW3szmq+IQwkiEwos=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N0sWYD3M7pQKsyIFuHopc2p2hn1pNW7gjD4v0Ao/hFu1VY6Yl1xmYorlCCGow3TyjCKll5VkMWWlgXylENS+5tXShdrM7YytDzZbZtzqmcOD5EgcCoqtV8CNlVOnuwg9+0taKi5fW9ixCt39ALd/MrCrZLm80iwmiZZI1LmdXR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=dNQYMC/9; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dNQYMC/9" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4775895d69cso16375885e9.0 for ; Sat, 06 Dec 2025 14:11:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765059083; x=1765663883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PdNpP3pkyQ8Ai0z1KZFpvSslMVtLjHwOnhFCasQI2sg=; b=dNQYMC/9LqzcOWImqX9Dvy8nXdFQEnEdlT2cNdfDSbBJoy82Yi23DPqVZi45NSV4jo +e7+67zdE53vMyP6HHAkqklOQzTpfdet0fPxyzWd9mVHd37cGIje+yZOocbLF33p1B9j YbbkcS6W7q3/Vsc/rt2EdQL3aeAzMBn8W82JyocFEtQMQZUPgPdz3STckNHQNefijRsN 6BiCljB6d6iveKvozfix9GqJiwRrCP7KBiYPphCuAmmbn/SPgySm1LH0iK9oWcFi8IRP 6Uy55gtrV3TDVCWPV3u95dJMp2fvwWwj/+N9KSoSDZQ4UeEpB8zh5VJSCuh7abmAoPDc h1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765059083; x=1765663883; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PdNpP3pkyQ8Ai0z1KZFpvSslMVtLjHwOnhFCasQI2sg=; b=bRzPYsJSL3mT8zCJStW0FytM15Gdq9HVo5Iqx/zEGcvTZj4zO0fjBEdqMj6e/+0225 I2E6gBOmtDXvZ6xjNn3w/0t9CjV9GScyKhEA9wMPcnwOCO0BaRIpJy6/kR7zeTgUKQSQ ksnkdDxcGaVmiEQklYMrKdFV791jBKPkGbQAlZsrziU9Tjr6bBfdob6k/dkfBV+XCgdj rl5X9uslC792vNTr4C3UBFDmEYlMmFQDk38uf65XPAdkwsk2lW+0TDode7Xnap8zY+QK WxaEY2eaeYv1CPUObCbFp6ubioqDF0mffg3Otf7aB6yA1b3f4NB1SX+vjWrfPIsTPV9S /E/A== X-Forwarded-Encrypted: i=1; AJvYcCVd5xcXWqgyWz/6Kl35qcXJigTazBD89VkhLTxTS76nvFnxclC0icFJlqothyyMsVHl8dIbgeovfspt@vger.kernel.org X-Gm-Message-State: AOJu0YzvCANzugy5puQzkrl1sOQiKOc41OVc8d8uC282PkcINQusM33O /LJH+Rk8e9U5YL7G0vKhurBgNMbG02oNv3Vn+n4VekUHiew8Rse2kykwFTdsawxDBeE= X-Gm-Gg: ASbGncvER7Kc9Z+jbnByDMFy14Ty+IbWWzd35JQyEOFMr5nDI1mHgOG/KeZw7dHmTUl kpRK1bHzaDf8pxs39F+eRfNWD3spp7+ul1Tfcic+xh8kosOjh5UcSy+kknR/xbHsxkP4NDHEq4E 3kEY7F4i9i3QQ6VCWSvAU+gpgqEyGFkV0yEn1zfFJAyt0jUuqeCljQMQ0J3R2QFP/ovG4NeSmnU Sk9yXk/89OwQA+VGxaNVTxtU4MSZP4oZBThNIYgFMTTRh1bPIZPfSRcu1tL1Kg1qi72QD4CbLNa 7aQL6MyvlSVw+EO8YqJr0vvHVXVfRPrNU4PMEEEOMh3OOm4h63xKKyrv9JDRUVq7XQ+KXCgjDQ6 9ohgPTZ/j78oE9Qy8MlzVHhUmh9UwYuzgPssha0SNNT+Yw+DjQrlYolRYia4CQ/GAgi33mJ6XF5 5/65G755ZB6ZtostCxziB6KlIO3HFoyEEw5AX7fBS62jpRjAfsHh9u X-Google-Smtp-Source: AGHT+IGYOQHLbRPRC/EPdOR1ME0IZsoXFZxSohWUfJRKOmie/CI8rO+nUjh/c/Z+R4TW2b7owJEeCw== X-Received: by 2002:a05:600c:8719:b0:477:7bca:8b3c with SMTP id 5b1f17b1804b1-47939e2828cmr36474655e9.19.1765059082919; Sat, 06 Dec 2025 14:11:22 -0800 (PST) Received: from [192.168.0.40] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47930ca4aacsm149576055e9.14.2025.12.06.14.11.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Dec 2025 14:11:22 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2025 22:11:20 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 1/5] media: dt-bindings: Add CAMSS device for Kaanapali To: Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany , Krzysztof Kozlowski References: <20251130-add-support-for-camss-on-kaanapali-v8-0-143a8265e6e8@oss.qualcomm.com> <20251130-add-support-for-camss-on-kaanapali-v8-1-143a8265e6e8@oss.qualcomm.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20251130-add-support-for-camss-on-kaanapali-v8-1-143a8265e6e8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 01/12/2025 06:30, Hangxiang Ma wrote: > Add the compatible string "qcom,kaanapali-camss" to describe the Camera > Subsystem (CAMSS) on the Qualcomm Kaanapali platform. > > The Kaanapali platform provides: > - 3 x VFE, 5 RDI per VFE > - 2 x VFE Lite, 4 RDI per VFE Lite > - 3 x CSID > - 2 x CSID Lite > - 6 x CSIPHY > - 2 x ICP > - 1 x IPE > - 2 x JPEG DMA & Downscaler > - 2 x JPEG Encoder > - 1 x OFE > - 5 x RT CDM > - 3 x TPG > > Reviewed-by: Bryan O'Donoghue > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Hangxiang Ma > --- > .../bindings/media/qcom,kaanapali-camss.yaml | 647 +++++++++++++++++++++ > 1 file changed, 647 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml > new file mode 100644 > index 000000000000..094287c01a79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,kaanapali-camss.yaml > @@ -0,0 +1,647 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/qcom,kaanapali-camss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Kaanapali Camera Subsystem (CAMSS) > + > +maintainers: > + - Hangxiang Ma > + > +description: > + This binding describes the camera subsystem hardware found on Kaanapali > + Qualcomm SoCs. It includes submodules such as CSIPHY (CSI Physical layer) > + and CSID (CSI Decoder), which comply with the MIPI CSI2 protocol. > + > + The subsystem also integrates a set of real-time image processing engines > + and their associated configuration modules, as well as non-real-time engines. > + > + Additionally, it encompasses a test pattern generator (TPG) submodule. > + > +properties: > + compatible: > + const: qcom,kaanapali-camss > + > + reg: > + items: > + - description: Registers for CSID 0 > + - description: Registers for CSID 1 > + - description: Registers for CSID 2 > + - description: Registers for CSID Lite 0 > + - description: Registers for CSID Lite 1 > + - description: Registers for CSIPHY 0 > + - description: Registers for CSIPHY 1 > + - description: Registers for CSIPHY 2 > + - description: Registers for CSIPHY 3 > + - description: Registers for CSIPHY 4 > + - description: Registers for CSIPHY 5 > + - description: Registers for VFE (Video Front End) 0 > + - description: Registers for VFE 1 > + - description: Registers for VFE 2 > + - description: Registers for VFE Lite 0 > + - description: Registers for VFE Lite 1 > + - description: Registers for ICP (Imaging Control Processor) 0 > + - description: Registers for ICP 0 SYS > + - description: Registers for ICP 1 > + - description: Registers for ICP 1 SYS > + - description: Registers for IPE (Image Processing Engine) > + - description: Registers for JPEG DMA & Downscaler > + - description: Registers for JPEG Encoder > + - description: Registers for OFE (Offline Front End) > + - description: Registers for RT CDM (Camera Data Mover) 0 > + - description: Registers for RT CDM 1 > + - description: Registers for RT CDM 2 > + - description: Registers for RT CDM 3 > + - description: Registers for RT CDM 4 > + - description: Registers for TPG 0 > + - description: Registers for TPG 1 > + - description: Registers for TPG 2 > + > + reg-names: > + items: > + - const: csid0 > + - const: csid1 > + - const: csid2 > + - const: csid_lite0 > + - const: csid_lite1 > + - const: csiphy0 > + - const: csiphy1 > + - const: csiphy2 > + - const: csiphy3 > + - const: csiphy4 > + - const: csiphy5 > + - const: vfe0 > + - const: vfe1 > + - const: vfe2 > + - const: vfe_lite0 > + - const: vfe_lite1 > + - const: icp0 > + - const: icp0_sys > + - const: icp1 > + - const: icp1_sys > + - const: ipe > + - const: jpeg_dma > + - const: jpeg_enc > + - const: ofe > + - const: rt_cdm0 > + - const: rt_cdm1 > + - const: rt_cdm2 > + - const: rt_cdm3 > + - const: rt_cdm4 > + - const: tpg0 > + - const: tpg1 > + - const: tpg2 > + > + clocks: > + maxItems: 60 > + > + clock-names: > + items: > + - const: camnoc_nrt_axi > + - const: camnoc_rt_axi > + - const: camnoc_rt_vfe0 > + - const: camnoc_rt_vfe1 > + - const: camnoc_rt_vfe2 > + - const: camnoc_rt_vfe_lite > + - const: cam_top_ahb > + - const: cam_top_fast_ahb > + - const: csid > + - const: csid_csiphy_rx > + - const: csiphy0 > + - const: csiphy0_timer > + - const: csiphy1 > + - const: csiphy1_timer > + - const: csiphy2 > + - const: csiphy2_timer > + - const: csiphy3 > + - const: csiphy3_timer > + - const: csiphy4 > + - const: csiphy4_timer > + - const: csiphy5 > + - const: csiphy5_timer > + - const: gcc_hf_axi https://patchwork.linuxtv.org/project/linux-media/patch/20251126-add-support-for-camss-on-sm8750-v1-2-646fee2eb720@oss.qualcomm.com/ Pointed out by Krzysztof in the 8750 patches but the name of this clock is gcc_axi_hf. ~/Development/worktree/qcom-linux-next ➞ grep gcc_axi_hf * -r | wc -l [git:platform-qcom-next] ✖ 48 ~/Development/worktree/qcom-linux-next ➞ grep gcc_hf_axi * -r | wc -l [git:platform-qcom-next] ✖ 0 Please resolve the other inconsitencies pointed out by Krzysztof in that thread here also. I will have to skip application of this series in the meantime. --- bod