From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C9E2303A0B for ; Tue, 21 Oct 2025 10:39:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761043183; cv=none; b=IXqIgSZ0F6ZUMiFFSirTAtKvUjH2cOkveP+OJK6Zwc28M/1lP3u9+t1wewfLsHW+nGBU03SWTbdqXnwG+gEwt7MoPeAHA/+rfJHocPOCW0ONFnhhq04My2tD8CjxNluf4F1gwrYsXMVNonhxIDbgSK44NIsFuRzULAVmU7HEStE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761043183; c=relaxed/simple; bh=3eyts/YvSz6Z2j6Hh2fF5Du51iRzLiZUzcVSn7JWyXI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NxnCaRplCkSopscqW/jdczSZZfeYO0NhZRH/R+PHSu3P8rhQWLDUb9BBDwvwAfqTv8L48k7nxSMQQCt4UnRIoFgT9FBD4bvF39CgXmRAdco2Mdfn7a/fJYHnQW/SIz1EhSf7KMhbmzGYchRpc787ksd7FsUQngmZRKFuK7AsCQw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=inIlSqT/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="inIlSqT/" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59L8MgSq030208 for ; Tue, 21 Oct 2025 10:39:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= s7+c3xtc3nVt94h0Qqk1xzCCdoDbTh3wKr1i/jVXoiQ=; b=inIlSqT/7z1qJObo aFHVFRIbL3hSfwahrjlnoSimCr0gpopnU8SnPGbwmv9OE0ZzirnnTGANUlNrNnt1 PjPMMLhfWn4uLICAReZL82xHVlYoP9S+AfPxpka97gpNja8aGaI0ZCKPCvvOIEvI SYfBv9Pjij/Gs4YzQs6G2DFHTsJGRpO9Dnsy8a0GtI8ZtPc0nF+BSkBGMPJd+LSe MHScDvZKNOoWvz8zxvmxA3FnZeZT/wI9F+jnMAaEKUc66FZpLZKKDNO2IGNaehcP YFCD4jK9cN9/H+pINb9RjKRQYcbJWyzQ0tv9Sa0fHb0KZNxpYXmEWDEDcKL4k6JM OP1s7Q== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v2ge0cq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Oct 2025 10:39:40 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-873eac0465eso19553526d6.3 for ; Tue, 21 Oct 2025 03:39:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761043180; x=1761647980; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s7+c3xtc3nVt94h0Qqk1xzCCdoDbTh3wKr1i/jVXoiQ=; b=lsqmXdvEVhhu92xNfNXllcW6tfjeo0RoqOsLEnyVGtXZTSQcrmYIGQfLdJgdO5JxdD 1ymseyOSw+0hBbssDATxqalfGy6BrCzvJHDcjd0OrfF71wQy4qui+bbMffrirgufUw8x IB28NDzf6Veid/s0eay2Q12OilVPjIlZEgx5WXL2UdVpLb556UC5k/E9nDNep08hkUri CnWcnfLFebkeZ1WnrgTjEopnfAZYhcyvN11mAmL8N8Qvat13nfRp0wV7v2Kca14xy3GF b/figZb4wzboNB8BSv78VbupLQ4RVS0SYh42z6VkFYs6u3VxU9pBhyqrpBv642Y9U0F2 Y5TQ== X-Forwarded-Encrypted: i=1; AJvYcCUy6VHnftyIV8mQyhjQzEyiR0QpjA8XJ5ITzOANyM79HT/eMagNoT+WzgEzELasCWdhZaUYDVzgoBLy@vger.kernel.org X-Gm-Message-State: AOJu0Yx9jkm3N06bMBhY0kfaiX9Kch0cLb+GhRpQas1gf8Oa7CRFxaNZ MWTDMVeNjRbwmgYlcdAw6IEhJjcD8numG6D8/WPatgRdvhLu6Y37k8bEt5f2x7JXVelsVWQ1k3Y wH29f4xORLGyJ46NJjPPu6dfjnXvO+0L5yOhIm8du/ToQqCWKryUCDJZ6Zq5Z/ZRI X-Gm-Gg: ASbGncvggzB6XbkINMlzuoVOFtCpperzbGT5AYgpZbFCIZ2+goO1Fr+OqUTbW2N9Yut pxoQdzcJwmIR8iFfjoI7LSqBgHY7ZRc2Dql1EgG9KTHhpstJKBkxZhITcI3SnrFiuIjwYZhHjgE 1878ovTpue4SeIW8Yq+6JfsvTrjsfb5aMl2eTm4+U8lFG+oGAXfkXw7BI1uL1HmRBCB4Pl5V/d2 bPOVQxhx2m+pf7dn26dVX3Dpnc5de5DLrwu39F2s+k+mPeuRLT8AhJt7xaR4IIVneDghgydHXAg Pba3mSltVlnv67xb+3kTiJO3BAxDZLPgfZuWqN6bgHUzGX3AbhHD6VqliUFm1RpxQxsl4Oqe4rS HsEdh/PCEVkgMeJfsH+oOJwpx8J8hf8lTQsLSPYrEWN1nlWu6bZ7XN3a2 X-Received: by 2002:ac8:5f10:0:b0:4dc:cb40:706e with SMTP id d75a77b69052e-4ea117e0b30mr20960151cf.13.1761043179648; Tue, 21 Oct 2025 03:39:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAeB5jrQGCav3qSKZ0xPgQHNQotUHpiAd/WgCgMc2vlJjKdTeD+j5g4MFS9sBZG3oO/Qm9bQ== X-Received: by 2002:ac8:5f10:0:b0:4dc:cb40:706e with SMTP id d75a77b69052e-4ea117e0b30mr20959941cf.13.1761043179164; Tue, 21 Oct 2025 03:39:39 -0700 (PDT) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b65eb03649dsm1041530466b.50.2025.10.21.03.39.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 03:39:38 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 12:39:37 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: sm8550: Additionally manage MXC power domain in camcc To: Luca Weiss , Taniya Das , Dmitry Baryshkov , Vladimir Zapolskiy Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Jagadeesh Kona , Bryan O'Donoghue , Michael Turquette , Stephen Boyd , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20250303225521.1780611-1-vladimir.zapolskiy@linaro.org> <20250303225521.1780611-3-vladimir.zapolskiy@linaro.org> <3210a484-b9c3-4399-bee1-9f5bbc90034c@linaro.org> <85bf3468-24bf-4f14-afcd-28878ad84dc9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMCBTYWx0ZWRfXx6j5l51cUkFG 8/RgEFS3aI04KM3rq/9sGLby31KmVDDS27iDfcFZZaYHunLo8VeiCSnnYTXC0knoBnYG3Xgi9nm Kn0gIUmowrszWxw5+eAOcqPKmXiEBurROzEq1IH2WgtEaZbMTjyRRJE+n7Avo19pELNOz1bauIH br0aLhkDej8VRLEDtocAcs0mtUh55MqPWmNdRUZm08Wk5BycRd7wWx+KTKrstrcfxOjR607YfUb VeuIT6MkqEDWNeyvsmqvFdKU9Pb9eZPZidLyxiNs2yJmWOZ2zJCb83GoQE4X+5PWRo2wSgwbMmo f/YD6l+wvxc405zWMD4sIgrcmRacLO+2rpfKKh5OzBdzAiuuCrXZFsx+uQQ5nUygFIVZS/U944m Ghe7/03WZJyg9WFHHtrxBghn/3MLPQ== X-Authority-Analysis: v=2.4 cv=KqFAGGWN c=1 sm=1 tr=0 ts=68f762ec cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=z5B4IXqlO_MRCTr_IEYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: kbrKuugK3d7IhjhYVVDTU-wS9Uh0_Tcq X-Proofpoint-ORIG-GUID: kbrKuugK3d7IhjhYVVDTU-wS9Uh0_Tcq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_07,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180020 On 10/21/25 12:36 PM, Luca Weiss wrote: > On Mon Oct 20, 2025 at 2:21 PM CEST, Konrad Dybcio wrote: >> On 10/17/25 4:05 PM, Luca Weiss wrote: >>> Hi Taniya, >>> >>> On Thu Mar 13, 2025 at 12:57 PM CET, Taniya Das wrote: >>>> >>>> >>>> On 3/13/2025 1:22 PM, Luca Weiss wrote: >>>>> Hi Taniya, >>>>> >>>>> On Thu Mar 13, 2025 at 5:39 AM CET, Taniya Das wrote: >>>>>> >>>>>> >>>>>> On 3/4/2025 2:10 PM, Dmitry Baryshkov wrote: >>>>>>> On Tue, 4 Mar 2025 at 09:37, Vladimir Zapolskiy >>>>>>> wrote: >>>>>>>> >>>>>>>> On 3/4/25 01:53, Dmitry Baryshkov wrote: >>>>>>>>> On Tue, Mar 04, 2025 at 12:55:21AM +0200, Vladimir Zapolskiy wrote: >>>>>>>>>> SM8550 Camera Clock Controller shall enable both MXC and MMCX power >>>>>>>>>> domains. >>>>>>>>> >>>>>>>>> Are those really required to access the registers of the cammcc? Or is >>>>>>>>> one of those (MXC?) required to setup PLLs? Also, is this applicable >>>>>>>>> only to sm8550 or to other similar clock controllers? >>>>>>>> >>>>>>>> Due to the described problem I experience a fatal CPU stall on SM8550-QRD, >>>>>>>> not on any SM8450 or SM8650 powered board for instance, however it does >>>>>>>> not exclude an option that the problem has to be fixed for other clock >>>>>>>> controllers, but it's Qualcomm to confirm any other touched platforms, >>>>>>> >>>>>>> Please work with Taniya to identify used power domains. >>>>>>> >>>>>> >>>>>> CAMCC requires both MMCX and MXC to be functional. >>>>> >>>>> Could you check whether any clock controllers on SM6350/SM7225 (Bitra) >>>>> need multiple power domains, or in general which clock controller uses >>>>> which power domain. >>>>> >>>>> That SoC has camcc, dispcc, gcc, gpucc, npucc and videocc. >>>>> >>>>> That'd be highly appreciated since I've been hitting weird issues there >>>>> that could be explained by some missing power domains. >>>>> >>>> >>>> Hi Luca, >>>> >>>> The targets you mentioned does not have any have multiple rail >>>> dependency, but could you share the weird issues with respect to clock >>>> controller I can take a look. >>> >>> Coming back to this, I've taken a shot at camera on SM6350 (Fairphone 4) >>> again, but again hitting some clock issues. >>> >>> For reference, I am testing with following change: >>> https://lore.kernel.org/linux-arm-msm/20250911011218.861322-3-vladimir.zapolskiy@linaro.org/ >>> >>> Trying to enable CAMCC_MCLK1_CLK - wired up to the IMX576 camera sensor >>> on this phone - results in following error. >>> >>> [ 3.140232] ------------[ cut here ]------------ >>> [ 3.141264] camcc_mclk1_clk status stuck at 'off' >>> [ 3.141276] WARNING: CPU: 6 PID: 12 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 >>> >>> Checking the driver against downstream driver, it looks like the RCGs >>> should be using clk_rcg2_shared_ops because of enable_safe_config in >>> downstream, but changing that doesn't really improve the situation, but >>> it does change the error message to this: >>> >>> [ 2.933254] ------------[ cut here ]------------ >>> [ 2.933961] camcc_mclk1_clk_src: rcg didn't update its configuration. >>> [ 2.933970] WARNING: CPU: 7 PID: 12 at drivers/clk/qcom/clk-rcg2.c:136 update_config+0xd4/0xe4 >>> >>> I've also noticed that some camcc drivers take in GCC_CAMERA_AHB_CLK as >>> iface clk, could something like this be missing on sm6350? >>> >>> I'd appreciate any help or tips for resolving this. >> >> Is CAMCC_PLL2 online? > > I'd assume so given nothing in dmesg is complaining about that? > > But not sure how to check. Debugcc can't do PLLs, right? The PLLs have a .is_enabled, so you can take a look in debugfs > In any case adding CLK_IS_CRITICAL to the camcc_pll2 doesn't change > anything. Was worth a shot :( Konrad