From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAF6C3815A for ; Sat, 10 Oct 2020 23:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C78202087D for ; Sat, 10 Oct 2020 23:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390276AbgJJW4w (ORCPT ); Sat, 10 Oct 2020 18:56:52 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:15274 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731310AbgJJTIc (ORCPT ); Sat, 10 Oct 2020 15:08:32 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5ABD8CCF04EED35C079F; Sat, 10 Oct 2020 18:54:43 +0800 (CST) Received: from [127.0.0.1] (10.174.177.134) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Sat, 10 Oct 2020 18:54:35 +0800 Subject: Re: [PATCH v6 11/17] dt-bindings: arm: hisilicon: convert hisilicon,cpuctrl bindings to json-schema To: Krzysztof Kozlowski CC: Wei Xu , Rob Herring , "Jonathan Cameron" , devicetree , linux-arm-kernel , linux-kernel , Libin , Kefeng Wang References: <20200930031712.2365-1-thunder.leizhen@huawei.com> <20200930031712.2365-12-thunder.leizhen@huawei.com> <20201001064008.GE3018@kozik-lap> From: "Leizhen (ThunderTown)" Message-ID: Date: Sat, 10 Oct 2020 18:54:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20201001064008.GE3018@kozik-lap> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.134] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020/10/1 14:40, Krzysztof Kozlowski wrote: > On Wed, Sep 30, 2020 at 11:17:06AM +0800, Zhen Lei wrote: >> Convert the Hisilicon CPU controller binding to DT schema format using >> json-schema. >> >> Signed-off-by: Zhen Lei >> --- >> .../bindings/arm/hisilicon/controller/cpuctrl.yaml | 29 ++++++++++++++++++++++ >> .../arm/hisilicon/controller/hisilicon,cpuctrl.txt | 8 ------ >> 2 files changed, 29 insertions(+), 8 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.yaml >> delete mode 100644 Documentation/devicetree/bindings/arm/hisilicon/controller/hisilicon,cpuctrl.txt >> >> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.yaml >> new file mode 100644 >> index 000000000000000..f6a314db3a59416 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.yaml >> @@ -0,0 +1,29 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/arm/hisilicon/controller/cpuctrl.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Hisilicon CPU controller >> + >> +maintainers: >> + - Wei Xu >> + >> +description: | >> + The clock registers and power registers of secondary cores are defined >> + in CPU controller, especially in HIX5HD2 SoC. >> + >> +properties: >> + compatible: >> + items: >> + - const: hisilicon,cpuctrl >> + >> + reg: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg > > Your own DTS file (arch/arm/boot/dts/hisi-x5hd2.dtsi) does not validate > against this dtschema. OK, I saw it. I just sent out a set of patches, to clean up all Hisilicon-related errors detected by DT schema on arm32. Because many new YAML files are generated this time, so I use the dtbs_check to check all the files at a times. The error information did not contain the compatible string, So I didn't see it. > > Best regards, > Krzysztof > > . >