From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: longqi <longqi90@gmail.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Allwinner sunXi SoC support"
<linux-sunxi@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fixes the pin settings of two LEDs on board nanopi neo plus2
Date: Mon, 11 Sep 2023 16:42:40 +0200 [thread overview]
Message-ID: <f4f0ed21-1e3b-a7c5-79f8-3469c4cfc471@linaro.org> (raw)
In-Reply-To: <20230911140959.2046340-1-longqi90@gmail.com>
On 11/09/2023 16:09, longqi wrote:
> Signed-off-by: longqi <longqi90@gmail.com>
Thank you for your patch. There is something to discuss/improve.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Your commit msg is missing. Please describe the bug or the problem thus
it will be obvious why this change is needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-11 20:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 14:09 [PATCH] fixes the pin settings of two LEDs on board nanopi neo plus2 longqi
2023-09-11 14:42 ` Krzysztof Kozlowski [this message]
2023-09-15 13:14 ` Zhang LongQi
2023-09-11 14:54 ` Andre Przywara
2023-09-11 15:04 ` Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4f0ed21-1e3b-a7c5-79f8-3469c4cfc471@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=longqi90@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).