From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A005BEEB58C for ; Mon, 11 Sep 2023 20:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbjIKUsx (ORCPT ); Mon, 11 Sep 2023 16:48:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240373AbjIKOms (ORCPT ); Mon, 11 Sep 2023 10:42:48 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258E6E40 for ; Mon, 11 Sep 2023 07:42:44 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-99de884ad25so595086066b.3 for ; Mon, 11 Sep 2023 07:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694443362; x=1695048162; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=6D80ZZPlzZTYiu/9bQG8irFdtGvZCgvK+mghRHHLOSI=; b=rKdRUU+yqZbHkXY7SazbHWkcUqJr0uRUJeAH9JyXUnujnMo6e10jFtNI+Q33qnKkxf CS5pgu02fPxyKA0ykY/KN+dw85vIWyIp3Tna14seZNcUfStYwsFapgGr9bq9uATvyUR6 6FLv9khgUothNH10EpZc8oX8BzXZdWsDW9ezu8fO6VpUrmlxZYZL9mjfiYXPHCk5nLQs yGzlThC70CfL4At0yuTK5/r/sRed4xxpQHC2VQFyAJBu4rpuFtsiDOell7VcXPbrzhbt wyQN85513R9BOzHfLfWODF8i6kS6rn1CYVInb+EqUHvO47BYNruaXef6nbJPDjP9jBkc DzHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694443362; x=1695048162; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6D80ZZPlzZTYiu/9bQG8irFdtGvZCgvK+mghRHHLOSI=; b=s+zl5SOFJmT/HQ131CFJP497Ep3fGWt22ZPf2EoClxBpbscZV4bgyZyTvKbXSmw2jS gaqZZYW/CucFB0EF50VdixksRxMQZFerOdeKOj4dX5UkHZk2AZtSpMjVqe4Mo5pm+zdv 5DLxehv+2lmik4OEaYskf8WbIpMOG4XWEvR/z5+PtIQTlS7Jo53KUK4aQdLx3YN4sh5l sMumjDzMBa10FoMujStuBQ9jGoCzu0QZF0yWA3oa5EQxZBWPa8awkvtbRgVxjA6CGmRa FXanBCCzY9aSxmqgDFA+YPdnfj7BT1VtEEDtqFAq/jtpRgYFRVRD5D2y7YCqMuLd2dkK fhjw== X-Gm-Message-State: AOJu0Yz2A037y0ufLTPn7Qwclu06ksU6hTW4knDCEfPc7Jb2r9KvWrUe zuj2HCYouPUnU0JXP9JDCDU2aQ== X-Google-Smtp-Source: AGHT+IGZ6BAm+BNseM9dLIErk0Fd9vodlBsob22D6rHK/pzDdm5HODd0tU/6G4M7A+HhDA5Ec4sUJQ== X-Received: by 2002:a17:907:762d:b0:9a1:ec3d:9004 with SMTP id jy13-20020a170907762d00b009a1ec3d9004mr9036507ejc.9.1694443362588; Mon, 11 Sep 2023 07:42:42 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id k12-20020a17090646cc00b0098669cc16b2sm5429610ejs.83.2023.09.11.07.42.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 07:42:42 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 16:42:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] fixes the pin settings of two LEDs on board nanopi neo plus2 To: longqi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , "open list:ARM/Allwinner sunXi SoC support" , open list References: <20230911140959.2046340-1-longqi90@gmail.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <20230911140959.2046340-1-longqi90@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/09/2023 16:09, longqi wrote: > Signed-off-by: longqi Thank you for your patch. There is something to discuss/improve. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Your commit msg is missing. Please describe the bug or the problem thus it will be obvious why this change is needed. Best regards, Krzysztof