From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lr2-f12.google.com (mail-lr2-f12.google.com [74.125.230.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7683A7843 for ; Thu, 17 Sep 2026 04:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.76 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789620457; cv=none; b=G484AyhUDdL0ccrv8lTflb4Enftj3wjz6O3Ri/2jdVU+evZPwHa1UE8V7XE+Yk0VUcoVXhuKFAvxV8fYtcfCx7u5I3DfvCqAuvuUQ6EQ/Tq5C3JkAlnIOWjJRHaFE1slSzwQ2EZubIzTUbMfKsR/CYfaffS6n+bCcwxtOdontYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789620457; c=relaxed/simple; bh=Lrt6YFfTcQjqGuU5FoLFJmGH0jhGaULcXBP69mPmyDI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7mmUg4KytvISNOwtKAsZNAA24zF3wjwN9XG0Akdwej+RH5f8ezR8hBmWygetWQg3J3iHP9SvXu+2nRlDjd6aOG12a2fVSvTiC35j8JwzVggNsDuJAmp6FPi+qopoOaUKIrvTm89wKurWfL60adC4WGXY7rkSdQXFQzphRCt5SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WPdMPb2N; arc=none smtp.client-ip=74.125.230.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WPdMPb2N" Received: by mail-lr2-f12.google.com with SMTP id 38308e7fff4ca-3a2ff148dfdso3097951fa.1 for ; Wed, 16 Sep 2026 21:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789620453; x=1790225253; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dDYu3bsth7oi/7LPOhDffulZAY7dt7QNkv+9w7yWBC0=; b=WPdMPb2NDyFx/VSYB/zGk1kF7EV/kHr3gS31Q75FBV2ml2PiJZ7G5HKWX2Mb1O+d0Q +UOOxCDJ5mG1+0+PHRnOgZK2SuhZwZaaz+HpZFBzwuMrqcroJoW07iSpp41S5v8f1wGu 89FEguVN6c8XaNZpc9YOCwTF9sr0mhQvsXoU2R4soG8YCU2oOpcX9dRLCHLJzMt235lQ QjKV/0Eem2pDaRNS1jMvxq4LG8HBoII7LDLNDsYidKD0B+9FigcsA2YXOAQMkaph7LaD fd75Wv5vKLrFeAslhgfFMbch8txttcKS6OpsJnEX7AiLM0HLrgJNLqWtzss1jPwEfT8+ I25w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789620453; x=1790225253; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dDYu3bsth7oi/7LPOhDffulZAY7dt7QNkv+9w7yWBC0=; b=WDZAdFnOdxFOZhg+bWLDgQDtDraonCdgUy+VrKJj8w0Mej5GPqoy/GTzywkwwaQU9g 6FdPxsJ+TuQVq4UEsjsPFFN8iCIiFFl9xFla/05inTt8EVdVByIOgZfwqXTYeKCY99m5 pZL966Yghi6gJOz9GptIu21mVVZtHSQlPjegOL+UvrjXIqYaURMKoDj5j8TD+acbEf3c 3o/AG5oNiSoubUKLThHFeccrmSDBLTuLHwrwwVex+sryVfAez0y8dNfUcqApjhBlv7wp oRlDW3welm7AbzYlbMp2qH+CFDTOI9csU2ArqcBPNak653Wp/o7WNPhWLqfBEA/Vs3EW krCw== X-Forwarded-Encrypted: i=1; AKwUvByuTyYxWSR1BXTPcQ0KtwhiFGdiYqMObAW2fVCx/HKKWRn7cQp36qVtbvxpJhn7rSESWhDfQlhOKnix@vger.kernel.org X-Gm-Message-State: AFuF++n8G/q4xV9Rg2wHS8Vo3rdQGlg/++98Ten2oRfysRJ2b6+lMNCF LxDFNy4rgS/t76ghixaGkDGTJt3OsM7JFzHcEMV/W8NpHvb6KflWrxDN X-Gm-Gg: AYBFou3QfBzKw1/qHrp/OCuv21x++qnxd8Yxvo52hfAVbIf6le//Rru0EbfNlbcWhf2 fn9Aa1FU9EmSBGD+dCSyyklr6++/AzStbu/CDqnAgCFoIkH0tgCr8hVm1DNEcVxCAcxlCh78BC8 xLFNVBS/eML3YOBAec88M5xlbistEhA8GuklqUhITxysR2e67Wbp2xd7ZEm/KlJoYzJfA38gOQX ynWDfFsy2wtNLu9KczegSzxx9CtUqPDe8MkjDhhmGMkG0qTLHoBT0jXlXUZWkSE/sw/rk9kPYZ8 q5/DzxvxhlwOKNfBlJTZAR0fnf2Q8RB1tAJ3ydhezERRruN0YYJqveR6S9wcmehQJ2NMiYuIbym reoPY+/K+a1EcoAidKz8ElUcvPzE/8ZB7HxMyT6F2HX6mtWOCQRSz1XrORz15m6MV2ck7MSS+UB qOrK4svYgBnct+XN6iJsnFYacMyxhfjcnd6UzmFSRVXLIN5nV7gBfisQ+BTjHunAGwmkHzl2hm1 FNd0ziN+EOLirU2QSuWcmSgMEoT+W8JMME9ygXvfjstWfpB5DL7Dv4= X-Received: by 2002:a05:651c:2107:b0:3a5:a106:ee0 with SMTP id 38308e7fff4ca-3a5dca17909mr10468881fa.24.1789620453050; Wed, 16 Sep 2026 21:47:33 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a5dafdc6fcsm11590281fa.33.2026.09.16.21.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2026 21:47:32 -0700 (PDT) Message-ID: Date: Thu, 17 Sep 2026 07:47:29 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 09/10] gpio: bd73800: Support ROHM BD73800 PMIC GPIOs To: Linus Walleij Cc: Matti Vaittinen , Matti Vaittinen , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Stephen Boyd , Brian Masney , Jerome Brunet , Bartosz Golaszewski , Alexandre Belloni , Michael Walle , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, Sverdlin@mva-rohm.smtp.subspace.kernel.org, Alexander References: Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/09/2026 20:31, Linus Walleij wrote: > On Wed, Sep 16, 2026 at 8:12 AM Matti Vaittinen > wrote: > >> From: Matti Vaittinen >> >> The ROHM BD73800 PMIC has 4 pins (named GPIO1, CLKOUT, FAULT_B and >> EXTEN_OUT) which might have been set to operate as a GPI or GPO when OTP >> (One Time Programmable memory) is written at device manufacturing. >> Support the GPI/GPO use-case via GPIO framework. >> >> The default OTP for these pins is to not use any of them as GPI or GPO. >> (The GPIO1 defaults as an ADC input regardless the naming). Hence the >> driver assumes none of these pins is a GPI/GPO unless explicitly pointed >> as GPI or GPO via device tree. >> >> Furthermore, pin's direction can't be changed after OTP configuration is >> done. Also the default drive type for a GPO (CMOS / Open Drain) is set >> by the OTP configuration. The BD73800 has a set of undocumented test >> registers which should allow changing the drive type. Access to the test >> register area or the test registers aren't documented and so this driver >> does not support configuring the drive type even though it might be >> doable. >> >> Signed-off-by: Matti Vaittinen >> Acked-by: Bartosz Golaszewski > > Looks really nice now! > Reviewed-by: Linus Walleij Sorry Linus! I dropped your tag from v3 by mistake. I hope you didn't waste too much time re-reviewing this :( Well, thanks anyways and again! Yours, -- Matti. -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~