From: Thara Gopinath <thara.gopinath@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Amit Kucheria <amitk@kernel.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960
Date: Fri, 19 Mar 2021 09:12:27 -0400 [thread overview]
Message-ID: <f510946f-23f1-bda7-0701-870b1494bc35@linaro.org> (raw)
In-Reply-To: <20210319005228.1250-8-ansuelsmth@gmail.com>
On 3/18/21 8:52 PM, Ansuel Smith wrote:
> Drop unused define for msm8960 replaced by generic api and reg_field.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Thanks for the clean up!
Reviewed-by: Thara Gopinath <thara.gopinath@linaro.org>
Warm Regards
Thara
> ---
> drivers/thermal/qcom/tsens-8960.c | 24 +-----------------------
> 1 file changed, 1 insertion(+), 23 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c
> index 8c523b764862..31e44d17d484 100644
> --- a/drivers/thermal/qcom/tsens-8960.c
> +++ b/drivers/thermal/qcom/tsens-8960.c
> @@ -10,8 +10,6 @@
> #include <linux/thermal.h>
> #include "tsens.h"
>
> -#define CAL_MDEGC 30000
> -
> #define CONFIG_ADDR 0x3640
> #define CONFIG_ADDR_8660 0x3620
> /* CONFIG_ADDR bitmasks */
> @@ -21,39 +19,19 @@
> #define CONFIG_SHIFT_8660 28
> #define CONFIG_MASK_8660 (3 << CONFIG_SHIFT_8660)
>
> -#define STATUS_CNTL_ADDR_8064 0x3660
> #define CNTL_ADDR 0x3620
> /* CNTL_ADDR bitmasks */
> #define EN BIT(0)
> #define SW_RST BIT(1)
> -#define SENSOR0_EN BIT(3)
> +
> #define MEASURE_PERIOD BIT(18)
> #define SLP_CLK_ENA BIT(26)
> #define SLP_CLK_ENA_8660 BIT(24)
> #define SENSOR0_SHIFT 3
>
> -/* INT_STATUS_ADDR bitmasks */
> -#define MIN_STATUS_MASK BIT(0)
> -#define LOWER_STATUS_CLR BIT(1)
> -#define UPPER_STATUS_CLR BIT(2)
> -#define MAX_STATUS_MASK BIT(3)
> -
> #define THRESHOLD_ADDR 0x3624
> -/* THRESHOLD_ADDR bitmasks */
> -#define THRESHOLD_MAX_LIMIT_SHIFT 24
> -#define THRESHOLD_MIN_LIMIT_SHIFT 16
> -#define THRESHOLD_UPPER_LIMIT_SHIFT 8
> -#define THRESHOLD_LOWER_LIMIT_SHIFT 0
> -
> -/* Initial temperature threshold values */
> -#define LOWER_LIMIT_TH 0x50
> -#define UPPER_LIMIT_TH 0xdf
> -#define MIN_LIMIT_TH 0x0
> -#define MAX_LIMIT_TH 0xff
>
> #define INT_STATUS_ADDR 0x363c
> -#define TRDY_MASK BIT(7)
> -#define TIMEOUT_US 100
>
> #define S0_STATUS_OFF 0x3628
> #define S1_STATUS_OFF 0x362c
>
--
Warm Regards
Thara
next prev parent reply other threads:[~2021-03-19 13:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 0:52 [PATCH v11 0/9] Add support for ipq8064 tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 1/9] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-19 13:28 ` Ansuel Smith
2021-03-19 14:11 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 2/9] drivers: thermal: tsens: Don't hardcode sensor slope Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 3/9] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 4/9] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 5/9] drivers: thermal: tsens: Fix bug in sensor enable " Ansuel Smith
2021-03-19 13:11 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 6/9] drivers: thermal: tsens: Replace custom 8960 apis with generic apis Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath
2021-03-19 0:52 ` [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960 Ansuel Smith
2021-03-19 13:12 ` Thara Gopinath [this message]
2021-03-19 0:52 ` [PATCH v11 8/9] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2021-03-19 0:52 ` [PATCH v11 9/9] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f510946f-23f1-bda7-0701-870b1494bc35@linaro.org \
--to=thara.gopinath@linaro.org \
--cc=agross@kernel.org \
--cc=amitk@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).