From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1A03C433E0 for ; Fri, 19 Mar 2021 13:13:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8808F64EED for ; Fri, 19 Mar 2021 13:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229756AbhCSNMy (ORCPT ); Fri, 19 Mar 2021 09:12:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230134AbhCSNMa (ORCPT ); Fri, 19 Mar 2021 09:12:30 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2D1EC061760 for ; Fri, 19 Mar 2021 06:12:29 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id y5so1183481qkl.9 for ; Fri, 19 Mar 2021 06:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=/+fWO4Wa4J/MjEIX6MtHgXnTBL0daD6nOFXcsG5rZ5E=; b=whYMkM1Kw9ejBOhhiybyihLYyAlHTjngNDpaBr7xS1VELCGaE2Jl7PhFnwpQx7/32j Qhci3G5jOocPAw64DgjWIDAbggdXKLRmnVTNgCurG/4Q/L0LxJNLaqgFeManGLdK19xP alXNxhut7Jul9JWQDDgmS4TLVXORlBf/oTW/XBGmk4FFZKAgfNrbqZzh78tR9pqKHdvd j6GWKlZMvAposB1Xprzk6+moVZd+2UlrqQMbRXZi3UkeR2o52hckETQSef+wCJ2CKO8J pJYd6DKzZv51CBXDjb027gAjQItmtNzGE+H18G6qizm747hxYHp9eMWXKNerJBVTblPl dNGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/+fWO4Wa4J/MjEIX6MtHgXnTBL0daD6nOFXcsG5rZ5E=; b=BpKpU6UrzHWx+0mfMuTpka6/qhTAeYGMIFozVxKZCH8D3jWYHjLIuwrCgEFlq8yHd/ QroBOr00MDdQKS+wpWDt2yi9ia4EVvUYLNRAkUCmvsuT0GAJrTiBMi9rn7Ftl2cCBykC YgFckxg33DWHJ8LfvYLqxVK9GuzpEEF13vJ/Zx8iY4SMX0N4jvc/guQuTRlZsxUsaUei YbY4BadZSSiMzNBNqg3uvwD7eYkqwm1g5qkc2vRoLjStJ3goiek9KEa8Rgs6RwXoMf8Q 0UU+oAApR7p2JCMI4sfoP+sXzAFfiZ939+aCuZOjLyoQQyK/X76P7daa7R4q393lJFoy T/Tw== X-Gm-Message-State: AOAM533Yzxo0FaX2kmXPk3wxu3g49uHSK8rmn1USklGcR3FDL7ZbL/PE jpawhfgbde3cTA759ZGRUtJIOw== X-Google-Smtp-Source: ABdhPJyW1YeWJ48Lqbk5Lh7sGZnCPwo0t00/uUtLgo8zAZgPMUWmJ80N6Ci1shInqypKPZfh1pxWQw== X-Received: by 2002:a37:a2c8:: with SMTP id l191mr9362412qke.413.1616159549179; Fri, 19 Mar 2021 06:12:29 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id 84sm4639116qkg.8.2021.03.19.06.12.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Mar 2021 06:12:28 -0700 (PDT) From: Thara Gopinath Subject: Re: [PATCH v11 7/9] drivers: thermal: tsens: Drop unused define for msm8960 To: Ansuel Smith Cc: Amit Kucheria , Andy Gross , Bjorn Andersson , Zhang Rui , Daniel Lezcano , Rob Herring , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210319005228.1250-1-ansuelsmth@gmail.com> <20210319005228.1250-8-ansuelsmth@gmail.com> Message-ID: Date: Fri, 19 Mar 2021 09:12:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210319005228.1250-8-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/18/21 8:52 PM, Ansuel Smith wrote: > Drop unused define for msm8960 replaced by generic api and reg_field. > > Signed-off-by: Ansuel Smith Thanks for the clean up! Reviewed-by: Thara Gopinath Warm Regards Thara > --- > drivers/thermal/qcom/tsens-8960.c | 24 +----------------------- > 1 file changed, 1 insertion(+), 23 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c > index 8c523b764862..31e44d17d484 100644 > --- a/drivers/thermal/qcom/tsens-8960.c > +++ b/drivers/thermal/qcom/tsens-8960.c > @@ -10,8 +10,6 @@ > #include > #include "tsens.h" > > -#define CAL_MDEGC 30000 > - > #define CONFIG_ADDR 0x3640 > #define CONFIG_ADDR_8660 0x3620 > /* CONFIG_ADDR bitmasks */ > @@ -21,39 +19,19 @@ > #define CONFIG_SHIFT_8660 28 > #define CONFIG_MASK_8660 (3 << CONFIG_SHIFT_8660) > > -#define STATUS_CNTL_ADDR_8064 0x3660 > #define CNTL_ADDR 0x3620 > /* CNTL_ADDR bitmasks */ > #define EN BIT(0) > #define SW_RST BIT(1) > -#define SENSOR0_EN BIT(3) > + > #define MEASURE_PERIOD BIT(18) > #define SLP_CLK_ENA BIT(26) > #define SLP_CLK_ENA_8660 BIT(24) > #define SENSOR0_SHIFT 3 > > -/* INT_STATUS_ADDR bitmasks */ > -#define MIN_STATUS_MASK BIT(0) > -#define LOWER_STATUS_CLR BIT(1) > -#define UPPER_STATUS_CLR BIT(2) > -#define MAX_STATUS_MASK BIT(3) > - > #define THRESHOLD_ADDR 0x3624 > -/* THRESHOLD_ADDR bitmasks */ > -#define THRESHOLD_MAX_LIMIT_SHIFT 24 > -#define THRESHOLD_MIN_LIMIT_SHIFT 16 > -#define THRESHOLD_UPPER_LIMIT_SHIFT 8 > -#define THRESHOLD_LOWER_LIMIT_SHIFT 0 > - > -/* Initial temperature threshold values */ > -#define LOWER_LIMIT_TH 0x50 > -#define UPPER_LIMIT_TH 0xdf > -#define MIN_LIMIT_TH 0x0 > -#define MAX_LIMIT_TH 0xff > > #define INT_STATUS_ADDR 0x363c > -#define TRDY_MASK BIT(7) > -#define TIMEOUT_US 100 > > #define S0_STATUS_OFF 0x3628 > #define S1_STATUS_OFF 0x362c > -- Warm Regards Thara