* arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree
@ 2022-09-28 11:01 Lin, Meng-Bo
2022-09-28 11:06 ` [PATCH 2/3] " Lin, Meng-Bo
` (4 more replies)
0 siblings, 5 replies; 17+ messages in thread
From: Lin, Meng-Bo @ 2022-09-28 11:01 UTC (permalink / raw)
To: devicetree
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Julian Ribbeck, Stephan Gerhold,
Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm,
linux-kernel, ~postmarketos/upstreaming
The smartphones below are using the MSM8916 SoC,
which are released in 2015-2016:
Samsung Galaxy J5 2015 (SM-J500*)
Samsung Galaxy J5 2016 (SM-J510*)
Samsung Galaxy J3 2016
- SM-J3109/SM-J320Y/SM-J320YZ
- SM-J320N0/SM-J320ZN
- SM-J320P/SM-J320R4/SM-J320V/SM-S320VL
Add a common device tree for with initial support for:
- GPIO keys
- SDHCI (internal and external storage)
- USB Device Mode
- UART (on USB connector via the SM5703 MUIC)
- WCNSS (WiFi/BT)
- Regulators
The three devices (some varints of J3, all other variants of J5 released
in 2015 and J5X released in 2016) are very similar, with some differences
in display and GPIO pins. The common parts are shared in
msm8916-samsung-j5-common.dtsi to reduce duplication.
^ permalink raw reply [flat|nested] 17+ messages in thread* [PATCH 2/3] arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo @ 2022-09-28 11:06 ` Lin, Meng-Bo 2022-09-28 11:11 ` Krzysztof Kozlowski 2022-09-28 11:06 ` [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo ` (3 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 11:06 UTC (permalink / raw) To: devicetree The smartphones below are using the MSM8916 SoC, which are released in 2015-2016: Samsung Galaxy J5 2015 (SM-J500*) Samsung Galaxy J5 2016 (SM-J510*) Samsung Galaxy J3 2016 - SM-J3109/SM-J320Y/SM-J320YZ - SM-J320N0/SM-J320ZN - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL Add a common device tree for with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - UART (on USB connector via the SM5703 MUIC) - WCNSS (WiFi/BT) - Regulators The three devices (some varints of J3, all other variants of J5 released in 2015 and J5X released in 2016) are very similar, with some differences in display and GPIO pins. The common parts are shared in msm8916-samsung-j5-common.dtsi to reduce duplication. [Add j5x device tree] Co-developed-by: Josef W Menad <JosefWMenad@protonmail.ch> Signed-off-by: Josef W Menad <JosefWMenad@protonmail.ch> [Use &pm8916_usbin as USB extcon and add chassis-type for j5x] Co-developed-by: Stephan Gerhold <stephan@gerhold.net> Signed-off-by: Stephan Gerhold <stephan@gerhold.net> [Use common init device tree and add j3 device tree] Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- arch/arm64/boot/dts/qcom/Makefile | 2 + .../boot/dts/qcom/msm8916-samsung-j3.dts | 21 ++ .../dts/qcom/msm8916-samsung-j5-common.dtsi | 203 ++++++++++++++++++ .../boot/dts/qcom/msm8916-samsung-j5.dts | 196 +---------------- .../boot/dts/qcom/msm8916-samsung-j5x.dts | 11 + 5 files changed, 238 insertions(+), 195 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 1d86a33de528..357a2529fe74 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -15,7 +15,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8910.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j3.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5x.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts new file mode 100644 index 000000000000..24e77c61ca9b --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-samsung-j5-common.dtsi" + +/ { + model = "Samsung Galaxy J3 (2016)"; + compatible = "samsung,j3", "qcom,msm8916"; + chassis-type = "handset"; + + reserved-memory { + /delete-node/ tz-apps@85500000; + + /* Additional memory used by Samsung firmware modifications */ + tz-apps@85a00000 { + reg = <0x0 0x85800000 0x0 0x800000>; + no-map; + }; + }; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi new file mode 100644 index 000000000000..ea2e165c2aa4 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi @@ -0,0 +1,203 @@ +// SPDX-License-Identifier: GPL-2.0-only + +#include "msm8916-pm8916.dtsi" + +#include <dt-bindings/gpio/gpio.h> + +/ { + aliases { + serial0 = &blsp1_uart2; + }; + + chosen { + stdout-path = "serial0"; + }; + + reserved-memory { + /* Additional memory used by Samsung firmware modifications */ + tz-apps@85500000 { + reg = <0x0 0x85500000 0x0 0xb00000>; + no-map; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&gpio_keys_default>; + + label = "GPIO Buttons"; + + button-volume-up { + label = "Volume Up"; + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>; + linux,code = <KEY_VOLUMEUP>; + }; + + button-home { + label = "Home Key"; + gpios = <&msmgpio 109 GPIO_ACTIVE_LOW>; + linux,code = <KEY_HOMEPAGE>; + }; + }; +}; + +&blsp1_uart2 { + status = "okay"; +}; + +&pm8916_resin { + status = "okay"; + linux,code = <KEY_VOLUMEDOWN>; +}; + +/* FIXME: Replace with SM5703 MUIC when driver is available */ +&pm8916_usbin { + status = "okay"; +}; + +&pronto { + status = "okay"; +}; + +&sdhc_1 { + status = "okay"; + + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>; + pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>; +}; + +&sdhc_2 { + status = "okay"; + + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; + + cd-gpios = <&msmgpio 38 GPIO_ACTIVE_LOW>; +}; + +&usb { + status = "okay"; + dr_mode = "peripheral"; + extcon = <&pm8916_usbin>; +}; + +&usb_hs_phy { + extcon = <&pm8916_usbin>; +}; + +&smd_rpm_regulators { + vdd_l1_l2_l3-supply = <&pm8916_s3>; + vdd_l4_l5_l6-supply = <&pm8916_s4>; + vdd_l7-supply = <&pm8916_s4>; + + s3 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1300000>; + }; + + s4 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2100000>; + }; + + l1 { + regulator-min-microvolt = <1225000>; + regulator-max-microvolt = <1225000>; + }; + + l2 { + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <1200000>; + }; + + l4 { + regulator-min-microvolt = <2050000>; + regulator-max-microvolt = <2050000>; + }; + + l5 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + l6 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + l7 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + + l8 { + regulator-min-microvolt = <2850000>; + regulator-max-microvolt = <2900000>; + }; + + l9 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + l10 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <2800000>; + }; + + l11 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + regulator-allow-set-load; + regulator-system-load = <200000>; + }; + + l12 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <2950000>; + }; + + l13 { + regulator-min-microvolt = <3075000>; + regulator-max-microvolt = <3075000>; + }; + + l14 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + + l15 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + + l16 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + }; + + l17 { + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + }; + + l18 { + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <2700000>; + }; +}; + +&msmgpio { + gpio_keys_default: gpio-keys-default { + pins = "gpio107", "gpio109"; + function = "gpio"; + + drive-strength = <2>; + bias-pull-up; + }; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts index eabeed18cfaa..0a32d33e9778 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts @@ -2,208 +2,14 @@ /dts-v1/; -#include "msm8916-pm8916.dtsi" -#include <dt-bindings/gpio/gpio.h> +#include "msm8916-samsung-j5-common.dtsi" / { model = "Samsung Galaxy J5 (2015)"; compatible = "samsung,j5", "qcom,msm8916"; chassis-type = "handset"; - - aliases { - serial0 = &blsp1_uart2; - }; - - chosen { - stdout-path = "serial0"; - }; - - reserved-memory { - /* Additional memory used by Samsung firmware modifications */ - tz-apps@85500000 { - reg = <0x0 0x85500000 0x0 0xb00000>; - no-map; - }; - }; - - gpio-keys { - compatible = "gpio-keys"; - - pinctrl-names = "default"; - pinctrl-0 = <&gpio_keys_default>; - - label = "GPIO Buttons"; - - button-volume-up { - label = "Volume Up"; - gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>; - linux,code = <KEY_VOLUMEUP>; - }; - - button-home { - label = "Home Key"; - gpios = <&msmgpio 109 GPIO_ACTIVE_LOW>; - linux,code = <KEY_HOMEPAGE>; - }; - }; -}; - -&blsp1_uart2 { - status = "okay"; -}; - -&pm8916_resin { - status = "okay"; - linux,code = <KEY_VOLUMEDOWN>; -}; - -/* FIXME: Replace with SM5703 MUIC when driver is available */ -&pm8916_usbin { - status = "okay"; -}; - -&pronto { - status = "okay"; -}; - -&sdhc_1 { - status = "okay"; - - pinctrl-names = "default", "sleep"; - pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>; - pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>; -}; - -&sdhc_2 { - status = "okay"; - - pinctrl-names = "default", "sleep"; - pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; - pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; - - cd-gpios = <&msmgpio 38 GPIO_ACTIVE_LOW>; -}; - -&usb { - status = "okay"; - dr_mode = "peripheral"; - extcon = <&pm8916_usbin>; }; &usb_hs_phy { - extcon = <&pm8916_usbin>; qcom,init-seq = /bits/ 8 <0x1 0x19 0x2 0x0b>; }; - -&smd_rpm_regulators { - vdd_l1_l2_l3-supply = <&pm8916_s3>; - vdd_l4_l5_l6-supply = <&pm8916_s4>; - vdd_l7-supply = <&pm8916_s4>; - - s3 { - regulator-min-microvolt = <1200000>; - regulator-max-microvolt = <1300000>; - }; - - s4 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <2100000>; - }; - - l1 { - regulator-min-microvolt = <1225000>; - regulator-max-microvolt = <1225000>; - }; - - l2 { - regulator-min-microvolt = <1200000>; - regulator-max-microvolt = <1200000>; - }; - - l4 { - regulator-min-microvolt = <2050000>; - regulator-max-microvolt = <2050000>; - }; - - l5 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - }; - - l6 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - }; - - l7 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <1800000>; - }; - - l8 { - regulator-min-microvolt = <2850000>; - regulator-max-microvolt = <2900000>; - }; - - l9 { - regulator-min-microvolt = <3300000>; - regulator-max-microvolt = <3300000>; - }; - - l10 { - regulator-min-microvolt = <2700000>; - regulator-max-microvolt = <2800000>; - }; - - l11 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <2950000>; - regulator-allow-set-load; - regulator-system-load = <200000>; - }; - - l12 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <2950000>; - }; - - l13 { - regulator-min-microvolt = <3075000>; - regulator-max-microvolt = <3075000>; - }; - - l14 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; - }; - - l15 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; - }; - - l16 { - regulator-min-microvolt = <1800000>; - regulator-max-microvolt = <3300000>; - }; - - l17 { - regulator-min-microvolt = <3000000>; - regulator-max-microvolt = <3000000>; - }; - - l18 { - regulator-min-microvolt = <2700000>; - regulator-max-microvolt = <2700000>; - }; -}; - -&msmgpio { - gpio_keys_default: gpio-keys-default { - pins = "gpio107", "gpio109"; - function = "gpio"; - - drive-strength = <2>; - bias-pull-up; - }; -}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts new file mode 100644 index 000000000000..7656ac4508cf --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-samsung-j5-common.dtsi" + +/ { + model = "Samsung Galaxy J5 (2016)"; + compatible = "samsung,j5x", "qcom,msm8916"; + chassis-type = "handset"; +}; -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree 2022-09-28 11:06 ` [PATCH 2/3] " Lin, Meng-Bo @ 2022-09-28 11:11 ` Krzysztof Kozlowski 0 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 11:11 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree On 28/09/2022 13:06, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL > > Add a common device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. > > [Add j5x device tree] > Co-developed-by: Josef W Menad <JosefWMenad@protonmail.ch> > Signed-off-by: Josef W Menad <JosefWMenad@protonmail.ch> > [Use &pm8916_usbin as USB extcon and add chassis-type for j5x] > Co-developed-by: Stephan Gerhold <stephan@gerhold.net> > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> > [Use common init device tree and add j3 device tree] > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> Yet you did not Cc them... Use standard tools and CC everyone from maintainers and other developers. > --- > arch/arm64/boot/dts/qcom/Makefile | 2 + > .../boot/dts/qcom/msm8916-samsung-j3.dts | 21 ++ > .../dts/qcom/msm8916-samsung-j5-common.dtsi | 203 ++++++++++++++++++ > .../boot/dts/qcom/msm8916-samsung-j5.dts | 196 +---------------- You need to create patch which will properly detect rename/copy. See -M/-B/-C arguments,. In current format it is too difficult to review, so no. > .../boot/dts/qcom/msm8916-samsung-j5x.dts | 11 + > 5 files changed, 238 insertions(+), 195 deletions(-) > create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts > create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 1d86a33de528..357a2529fe74 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -15,7 +15,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8910.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j3.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb > +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5x.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts > new file mode 100644 > index 000000000000..24e77c61ca9b > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > + > +/dts-v1/; > + > +#include "msm8916-samsung-j5-common.dtsi" > + > +/ { > + model = "Samsung Galaxy J3 (2016)"; > + compatible = "samsung,j3", "qcom,msm8916"; > + chassis-type = "handset"; > + > + reserved-memory { > + /delete-node/ tz-apps@85500000; > + > + /* Additional memory used by Samsung firmware modifications */ > + tz-apps@85a00000 { > + reg = <0x0 0x85800000 0x0 0x800000>; > + no-map; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi > new file mode 100644 > index 000000000000..ea2e165c2aa4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi > @@ -0,0 +1,203 @@ > +// SPDX-License-Identifier: GPL-2.0-only > + > +#include "msm8916-pm8916.dtsi" > + > +#include <dt-bindings/gpio/gpio.h> > + > +/ { > + aliases { > + serial0 = &blsp1_uart2; > + }; > + > + chosen { > + stdout-path = "serial0"; > + }; > + > + reserved-memory { > + /* Additional memory used by Samsung firmware modifications */ > + tz-apps@85500000 { > + reg = <0x0 0x85500000 0x0 0xb00000>; > + no-map; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_default>; > + > + label = "GPIO Buttons"; > + > + button-volume-up { > + label = "Volume Up"; > + gpios = <&msmgpio 107 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_VOLUMEUP>; > + }; > + > + button-home { > + label = "Home Key"; > + gpios = <&msmgpio 109 GPIO_ACTIVE_LOW>; > + linux,code = <KEY_HOMEPAGE>; > + }; > + }; > +}; > + > +&blsp1_uart2 { > + status = "okay"; > +}; > + > +&pm8916_resin { > + status = "okay"; > + linux,code = <KEY_VOLUMEDOWN>; > +}; > + > +/* FIXME: Replace with SM5703 MUIC when driver is available */ > +&pm8916_usbin { > + status = "okay"; > +}; > + > +&pronto { > + status = "okay"; > +}; > + > +&sdhc_1 { > + status = "okay"; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc1_clk_on &sdc1_cmd_on &sdc1_data_on>; > + pinctrl-1 = <&sdc1_clk_off &sdc1_cmd_off &sdc1_data_off>; > +}; > + > +&sdhc_2 { > + status = "okay"; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>; > + pinctrl-1 = <&sdc2_clk_off &sdc2_cmd_off &sdc2_data_off &sdc2_cd_off>; > + > + cd-gpios = <&msmgpio 38 GPIO_ACTIVE_LOW>; > +}; > + > +&usb { > + status = "okay"; > + dr_mode = "peripheral"; > + extcon = <&pm8916_usbin>; > +}; > + > +&usb_hs_phy { > + extcon = <&pm8916_usbin>; > +}; > + > +&smd_rpm_regulators { > + vdd_l1_l2_l3-supply = <&pm8916_s3>; > + vdd_l4_l5_l6-supply = <&pm8916_s4>; > + vdd_l7-supply = <&pm8916_s4>; > + > + s3 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1300000>; > + }; > + > + s4 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2100000>; > + }; > + > + l1 { > + regulator-min-microvolt = <1225000>; > + regulator-max-microvolt = <1225000>; > + }; > + > + l2 { > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + l4 { > + regulator-min-microvolt = <2050000>; > + regulator-max-microvolt = <2050000>; > + }; > + > + l5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l6 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l7 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + l8 { > + regulator-min-microvolt = <2850000>; > + regulator-max-microvolt = <2900000>; > + }; > + > + l9 { > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l10 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <2800000>; > + }; > + > + l11 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + regulator-allow-set-load; > + regulator-system-load = <200000>; > + }; > + > + l12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2950000>; > + }; > + > + l13 { > + regulator-min-microvolt = <3075000>; > + regulator-max-microvolt = <3075000>; > + }; > + > + l14 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l15 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l16 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + l17 { > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + }; > + > + l18 { > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <2700000>; > + }; > +}; > + > +&msmgpio { > + gpio_keys_default: gpio-keys-default { missing suffix "state" > + pins = "gpio107", "gpio109"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-pull-up; > + }; Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo 2022-09-28 11:06 ` [PATCH 2/3] " Lin, Meng-Bo @ 2022-09-28 11:06 ` Lin, Meng-Bo 2022-09-28 11:08 ` Krzysztof Kozlowski 2022-09-28 11:06 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo ` (2 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 11:06 UTC (permalink / raw) To: devicetree Document the new samsung,j3/j5/j5x device tree bindings used in their device trees. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index fb1d00bcc847..b1c69d4d9a9a 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -176,7 +176,9 @@ properties: - longcheer,l8910 - samsung,a3u-eur - samsung,a5u-eur + - samsung,j3 - samsung,j5 + - samsung,j5x - samsung,serranove - wingtech,wt88047 - const: qcom,msm8916 -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices 2022-09-28 11:06 ` [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo @ 2022-09-28 11:08 ` Krzysztof Kozlowski 0 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 11:08 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree On 28/09/2022 13:06, Lin, Meng-Bo wrote: > Document the new samsung,j3/j5/j5x device tree bindings used in their > device trees. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> None of your patches were cc-ed to proper list and maintainers. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo 2022-09-28 11:06 ` [PATCH 2/3] " Lin, Meng-Bo 2022-09-28 11:06 ` [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo @ 2022-09-28 11:06 ` Lin, Meng-Bo 2022-09-28 11:08 ` Krzysztof Kozlowski 2022-09-28 11:06 ` arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Krzysztof Kozlowski 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo 4 siblings, 1 reply; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 11:06 UTC (permalink / raw) To: devicetree Samsung Galaxy J5 2015 and 2016 have a Hall sensor on GPIO pin 52. Add GPIO Hall sensor for them. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- .../boot/dts/qcom/msm8916-samsung-j3.dts | 4 +++ .../dts/qcom/msm8916-samsung-j5-common.dtsi | 26 +++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts index 24e77c61ca9b..6d4e53295c30 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts @@ -19,3 +19,7 @@ tz-apps@85a00000 { }; }; }; + +&gpio_hall_sensor { + status = "disabled"; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi index ea2e165c2aa4..2c498d3b2c83 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi @@ -3,6 +3,7 @@ #include "msm8916-pm8916.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> / { aliases { @@ -21,6 +22,23 @@ tz-apps@85500000 { }; }; + gpio_hall_sensor: gpio-hall-sensor { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&gpio_hall_sensor_default>; + + label = "GPIO Hall Effect Sensor"; + + event-hall-sensor { + label = "Hall Effect Sensor"; + gpios = <&msmgpio 52 GPIO_ACTIVE_LOW>; + linux,input-type = <EV_SW>; + linux,code = <SW_LID>; + linux,can-disable; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -193,6 +211,14 @@ l18 { }; &msmgpio { + gpio_hall_sensor_default: gpio-hall-sensor-default { + pins = "gpio52"; + function = "gpio"; + + drive-strength = <2>; + bias-disable; + }; + gpio_keys_default: gpio-keys-default { pins = "gpio107", "gpio109"; function = "gpio"; -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor 2022-09-28 11:06 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo @ 2022-09-28 11:08 ` Krzysztof Kozlowski 0 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 11:08 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree On 28/09/2022 13:06, Lin, Meng-Bo wrote: > Samsung Galaxy J5 2015 and 2016 have a Hall sensor on GPIO pin 52. > Add GPIO Hall sensor for them. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > --- > .../boot/dts/qcom/msm8916-samsung-j3.dts | 4 +++ > .../dts/qcom/msm8916-samsung-j5-common.dtsi | 26 +++++++++++++++++++ > 2 files changed, 30 insertions(+) > gpio-keys { > compatible = "gpio-keys"; > > @@ -193,6 +211,14 @@ l18 { > }; > > &msmgpio { > + gpio_hall_sensor_default: gpio-hall-sensor-default suffix "state" Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo ` (2 preceding siblings ...) 2022-09-28 11:06 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo @ 2022-09-28 11:06 ` Krzysztof Kozlowski 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo 4 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 11:06 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Julian Ribbeck, Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming On 28/09/2022 13:01, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL > > Add a common device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. > This is not a correct patch. Use `git format-patch` to create proper patches - with subject, diff etc. https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo ` (3 preceding siblings ...) 2022-09-28 11:06 ` arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Krzysztof Kozlowski @ 2022-09-28 12:19 ` Lin, Meng-Bo 2022-09-28 12:39 ` [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo ` (4 more replies) 4 siblings, 5 replies; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 12:19 UTC (permalink / raw) To: devicetree Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Julian Ribbeck, Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming v2: Reword and resend. Split common dtsi patch. Add missing suffix state in pinctrl. The smartphones below are using the MSM8916 SoC, which are released in 2015-2016: Samsung Galaxy J5 2015 (SM-J500*) Samsung Galaxy J5 2016 (SM-J510*) Samsung Galaxy J3 2016 - SM-J3109/SM-J320Y/SM-J320YZ - SM-J320N0/SM-J320ZN - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL Add a common device tree for with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - UART (on USB connector via the SM5703 MUIC) - WCNSS (WiFi/BT) - Regulators The three devices (some varints of J3, all other variants of J5 released in 2015 and J5X released in 2016) are very similar, with some differences in display and GPIO pins. The common parts are shared in msm8916-samsung-j5-common.dtsi to reduce duplication. ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo @ 2022-09-28 12:39 ` Lin, Meng-Bo 2022-09-28 14:14 ` Krzysztof Kozlowski 2022-09-28 12:39 ` [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo ` (3 subsequent siblings) 4 siblings, 1 reply; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 12:39 UTC (permalink / raw) To: devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Meng-Bo, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski Document the new samsung,j3/j5/j5x device tree bindings used in their device trees. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index fb1d00bcc847..b1c69d4d9a9a 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -176,7 +176,9 @@ properties: - longcheer,l8910 - samsung,a3u-eur - samsung,a5u-eur + - samsung,j3 - samsung,j5 + - samsung,j5x - samsung,serranove - wingtech,wt88047 - const: qcom,msm8916 -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices 2022-09-28 12:39 ` [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo @ 2022-09-28 14:14 ` Krzysztof Kozlowski 0 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 14:14 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski On 28/09/2022 14:39, Lin, Meng-Bo wrote: > Document the new samsung,j3/j5/j5x device tree bindings used in their > device trees. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++ Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo 2022-09-28 12:39 ` [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo @ 2022-09-28 12:39 ` Lin, Meng-Bo 2022-09-28 14:16 ` Krzysztof Kozlowski 2022-11-06 2:56 ` Bjorn Andersson 2022-09-28 12:39 ` [PATCH v2 3/4] arm64: dts: qcom: msm8916-samsung-j5: Use " Lin, Meng-Bo ` (2 subsequent siblings) 4 siblings, 2 replies; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 12:39 UTC (permalink / raw) To: devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Meng-Bo, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski The smartphones below are using the MSM8916 SoC, which are released in 2015-2016: Samsung Galaxy J5 2015 (SM-J500*) Samsung Galaxy J5 2016 (SM-J510*) Samsung Galaxy J3 2016 - SM-J3109/SM-J320Y/SM-J320YZ - SM-J320N0/SM-J320ZN - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL Add a common device tree for with initial support for: - GPIO keys - SDHCI (internal and external storage) - USB Device Mode - UART (on USB connector via the SM5703 MUIC) - WCNSS (WiFi/BT) - Regulators The three devices (some varints of J3, all other variants of J5 released in 2015 and J5X released in 2016) are very similar, with some differences in display and GPIO pins. The common parts are shared in msm8916-samsung-j5-common.dtsi to reduce duplication. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) rename arch/arm64/boot/dts/qcom/{msm8916-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} (94%) diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi similarity index 94% rename from arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts rename to arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi index eabeed18cfaa..4f71609bf6f8 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi @@ -1,15 +1,10 @@ // SPDX-License-Identifier: GPL-2.0-only -/dts-v1/; - #include "msm8916-pm8916.dtsi" + #include <dt-bindings/gpio/gpio.h> / { - model = "Samsung Galaxy J5 (2015)"; - compatible = "samsung,j5", "qcom,msm8916"; - chassis-type = "handset"; - aliases { serial0 = &blsp1_uart2; }; @@ -92,7 +87,6 @@ &usb { &usb_hs_phy { extcon = <&pm8916_usbin>; - qcom,init-seq = /bits/ 8 <0x1 0x19 0x2 0x0b>; }; &smd_rpm_regulators { @@ -199,7 +193,7 @@ l18 { }; &msmgpio { - gpio_keys_default: gpio-keys-default { + gpio_keys_default: gpio-keys-default-state { pins = "gpio107", "gpio109"; function = "gpio"; -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree 2022-09-28 12:39 ` [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo @ 2022-09-28 14:16 ` Krzysztof Kozlowski 2022-11-06 2:56 ` Bjorn Andersson 1 sibling, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 14:16 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski On 28/09/2022 14:39, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL No need to repeat it in every commit. > > Add a common device tree for with initial support for: > > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. The same. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > --- > ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++-------- Thanks for using proper format options. However your patch is not bisectable - kernel is broken here. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree 2022-09-28 12:39 ` [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo 2022-09-28 14:16 ` Krzysztof Kozlowski @ 2022-11-06 2:56 ` Bjorn Andersson 1 sibling, 0 replies; 17+ messages in thread From: Bjorn Andersson @ 2022-11-06 2:56 UTC (permalink / raw) To: Lin, Meng-Bo Cc: devicetree, Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Andy Gross, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski On Wed, Sep 28, 2022 at 12:39:46PM +0000, Lin, Meng-Bo wrote: > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: > > Samsung Galaxy J5 2015 (SM-J500*) > Samsung Galaxy J5 2016 (SM-J510*) > Samsung Galaxy J3 2016 > - SM-J3109/SM-J320Y/SM-J320YZ > - SM-J320N0/SM-J320ZN > - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL > > Add a common device tree for with initial support for: > I'm afraid I don't think this, or the $subject, reflects what you're actually doing in this change. This should say something about moving the J5 device definition to a common file, so that it could be reused in other related devices. > - GPIO keys > - SDHCI (internal and external storage) > - USB Device Mode > - UART (on USB connector via the SM5703 MUIC) > - WCNSS (WiFi/BT) > - Regulators > > The three devices (some varints of J3, all other variants of J5 released > in 2015 and J5X released in 2016) are very similar, with some differences > in display and GPIO pins. The common parts are shared in > msm8916-samsung-j5-common.dtsi to reduce duplication. > > Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> > --- > ...6-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > rename arch/arm64/boot/dts/qcom/{msm8916-samsung-j5.dts => msm8916-samsung-j5-common.dtsi} (94%) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi > similarity index 94% > rename from arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts > rename to arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi > index eabeed18cfaa..4f71609bf6f8 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi With this movewe have the Makefile referencing a file that doesn't exist. Please introduce msm8916-samsung-j5.dts in the same commit. > @@ -1,15 +1,10 @@ > // SPDX-License-Identifier: GPL-2.0-only > > > -/dts-v1/; > - > #include "msm8916-pm8916.dtsi" > + > #include <dt-bindings/gpio/gpio.h> > > > / { > - model = "Samsung Galaxy J5 (2015)"; > - compatible = "samsung,j5", "qcom,msm8916"; > - chassis-type = "handset"; > - > aliases { > serial0 = &blsp1_uart2; > }; > @@ -92,7 +87,6 @@ &usb { > > > &usb_hs_phy { > extcon = <&pm8916_usbin>; > - qcom,init-seq = /bits/ 8 <0x1 0x19 0x2 0x0b>; > }; > > > &smd_rpm_regulators { > @@ -199,7 +193,7 @@ l18 { > }; > > > &msmgpio { > - gpio_keys_default: gpio-keys-default { > + gpio_keys_default: gpio-keys-default-state { This is a good, but unrelated change. Thanks, Bjorn > pins = "gpio107", "gpio109"; > function = "gpio"; > > > -- > > 2.30.2 > ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 3/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo 2022-09-28 12:39 ` [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo 2022-09-28 12:39 ` [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo @ 2022-09-28 12:39 ` Lin, Meng-Bo 2022-09-28 12:40 ` [PATCH v2 4/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo 2022-09-28 14:14 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree Krzysztof Kozlowski 4 siblings, 0 replies; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 12:39 UTC (permalink / raw) To: devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Meng-Bo, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski The smartphones below are using the MSM8916 SoC, which are released in 2015-2016: Samsung Galaxy J5 2015 (SM-J500*) Samsung Galaxy J5 2016 (SM-J510*) Samsung Galaxy J3 2016 - SM-J3109/SM-J320Y/SM-J320YZ - SM-J320N0/SM-J320ZN - SM-J320P/SM-J320R4/SM-J320V/SM-S320VL The three devices (some varints of J3, all other variants of J5 released in 2015 and J5X released in 2016) are very similar, with some differences in display and GPIO pins. The common parts are shared in msm8916-samsung-j5-common.dtsi to reduce duplication. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> [Add j5x device tree] Co-developed-by: Josef W Menad <JosefWMenad@protonmail.ch> Signed-off-by: Josef W Menad <JosefWMenad@protonmail.ch> [Use &pm8916_usbin as USB extcon and add chassis-type for j5x] Co-developed-by: Stephan Gerhold <stephan@gerhold.net> Signed-off-by: Stephan Gerhold <stephan@gerhold.net> [Use common init device tree and add j3 device tree] Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- arch/arm64/boot/dts/qcom/Makefile | 2 ++ .../boot/dts/qcom/msm8916-samsung-j3.dts | 21 +++++++++++++++++++ .../boot/dts/qcom/msm8916-samsung-j5.dts | 15 +++++++++++++ .../boot/dts/qcom/msm8916-samsung-j5x.dts | 11 ++++++++++ 4 files changed, 49 insertions(+) create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts create mode 100644 arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 1d86a33de528..357a2529fe74 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -15,7 +15,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-longcheer-l8910.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a3u-eur.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-a5u-eur.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j3.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5.dtb +dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-j5x.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-samsung-serranove.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8916-wingtech-wt88047.dtb dtb-$(CONFIG_ARCH_QCOM) += msm8992-lg-bullhead-rev-10.dtb diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts new file mode 100644 index 000000000000..bf8672ebedcd --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-samsung-j5-common.dtsi" + +/ { + model = "Samsung Galaxy J3 (2016)"; + compatible = "samsung,j3", "qcom,msm8916"; + chassis-type = "handset"; + + reserved-memory { + /delete-node/ tz-apps@85500000; + + /* Additional memory used by Samsung firmware modifications */ + tz-apps@85a00000 { + reg = <0x0 0x85800000 0x0 0x800000>; + no-map; + }; + }; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts new file mode 100644 index 000000000000..0a32d33e9778 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5.dts @@ -0,0 +1,15 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-samsung-j5-common.dtsi" + +/ { + model = "Samsung Galaxy J5 (2015)"; + compatible = "samsung,j5", "qcom,msm8916"; + chassis-type = "handset"; +}; + +&usb_hs_phy { + qcom,init-seq = /bits/ 8 <0x1 0x19 0x2 0x0b>; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts new file mode 100644 index 000000000000..7656ac4508cf --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5x.dts @@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-only + +/dts-v1/; + +#include "msm8916-samsung-j5-common.dtsi" + +/ { + model = "Samsung Galaxy J5 (2016)"; + compatible = "samsung,j5x", "qcom,msm8916"; + chassis-type = "handset"; +}; -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 4/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo ` (2 preceding siblings ...) 2022-09-28 12:39 ` [PATCH v2 3/4] arm64: dts: qcom: msm8916-samsung-j5: Use " Lin, Meng-Bo @ 2022-09-28 12:40 ` Lin, Meng-Bo 2022-09-28 14:14 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree Krzysztof Kozlowski 4 siblings, 0 replies; 17+ messages in thread From: Lin, Meng-Bo @ 2022-09-28 12:40 UTC (permalink / raw) To: devicetree Cc: Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming, Lin, Meng-Bo, Lin, Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski Samsung Galaxy J5 2015 and 2016 have a Hall sensor on GPIO pin 52. Add GPIO Hall sensor for them. Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com> --- .../boot/dts/qcom/msm8916-samsung-j3.dts | 4 +++ .../dts/qcom/msm8916-samsung-j5-common.dtsi | 26 +++++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts index bf8672ebedcd..7fd357b7f728 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j3.dts @@ -19,3 +19,7 @@ tz-apps@85a00000 { }; }; }; + +&gpio_hall_sensor { + status = "disabled"; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi index 4f71609bf6f8..54190144f823 100644 --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-j5-common.dtsi @@ -3,6 +3,7 @@ #include "msm8916-pm8916.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> / { aliases { @@ -21,6 +22,23 @@ tz-apps@85500000 { }; }; + gpio_hall_sensor: gpio-hall-sensor { + compatible = "gpio-keys"; + + pinctrl-names = "default"; + pinctrl-0 = <&gpio_hall_sensor_default>; + + label = "GPIO Hall Effect Sensor"; + + event-hall-sensor { + label = "Hall Effect Sensor"; + gpios = <&msmgpio 52 GPIO_ACTIVE_LOW>; + linux,input-type = <EV_SW>; + linux,code = <SW_LID>; + linux,can-disable; + }; + }; + gpio-keys { compatible = "gpio-keys"; @@ -193,6 +211,14 @@ l18 { }; &msmgpio { + gpio_hall_sensor_default: gpio-hall-sensor-default-state { + pins = "gpio52"; + function = "gpio"; + + drive-strength = <2>; + bias-disable; + }; + gpio_keys_default: gpio-keys-default-state { pins = "gpio107", "gpio109"; function = "gpio"; -- 2.30.2 ^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo ` (3 preceding siblings ...) 2022-09-28 12:40 ` [PATCH v2 4/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo @ 2022-09-28 14:14 ` Krzysztof Kozlowski 4 siblings, 0 replies; 17+ messages in thread From: Krzysztof Kozlowski @ 2022-09-28 14:14 UTC (permalink / raw) To: Lin, Meng-Bo, devicetree Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Julian Ribbeck, Stephan Gerhold, Nikita Travkin, Josef W Menad, Markuss Broks, linux-arm-msm, linux-kernel, ~postmarketos/upstreaming On 28/09/2022 14:19, Lin, Meng-Bo wrote: > v2: Reword and resend. Split common dtsi patch. > Add missing suffix state in pinctrl. > > The smartphones below are using the MSM8916 SoC, > which are released in 2015-2016: Thanks for the changes. Do not attach further versions to some other threads, because it messes up with our inboxes. Each patchset is a separate thread. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-11-06 2:57 UTC | newest] Thread overview: 17+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-09-28 11:01 arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Lin, Meng-Bo 2022-09-28 11:06 ` [PATCH 2/3] " Lin, Meng-Bo 2022-09-28 11:11 ` Krzysztof Kozlowski 2022-09-28 11:06 ` [PATCH 1/3] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo 2022-09-28 11:08 ` Krzysztof Kozlowski 2022-09-28 11:06 ` [PATCH 3/3] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo 2022-09-28 11:08 ` Krzysztof Kozlowski 2022-09-28 11:06 ` arm64: dts: qcom: msm8916-samsung-j5: Use common init device tree Krzysztof Kozlowski 2022-09-28 12:19 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common " Lin, Meng-Bo 2022-09-28 12:39 ` [PATCH v2 1/4] dt-bindings: qcom: Document bindings for new msm8916-samsung-j5 devices Lin, Meng-Bo 2022-09-28 14:14 ` Krzysztof Kozlowski 2022-09-28 12:39 ` [PATCH v2 2/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add initial common device tree Lin, Meng-Bo 2022-09-28 14:16 ` Krzysztof Kozlowski 2022-11-06 2:56 ` Bjorn Andersson 2022-09-28 12:39 ` [PATCH v2 3/4] arm64: dts: qcom: msm8916-samsung-j5: Use " Lin, Meng-Bo 2022-09-28 12:40 ` [PATCH v2 4/4] arm64: dts: qcom: msm8916-samsung-j5-common: Add Hall sensor Lin, Meng-Bo 2022-09-28 14:14 ` [PATCH v2 0/4] arm64: dts: qcom: msm8916-samsung-j5: Use common device tree Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).