From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 959E331619D; Sat, 11 Apr 2026 07:38:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775893100; cv=none; b=Bqk3E0b/p/zZVpjBD/a1uQ81Q1PdDC5HDs70fRKPussdQVzB3zIG/jgKSE+hY98RwJiF9UJRqh50LgqGKQBUshODXQ2E2txVdedqYcQFfwbWaIbbas5nqHUfEAKvrW4GwUrc8/avtwDJ/SA+pHOUepW6ksacUc5sItpRYwCl024= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775893100; c=relaxed/simple; bh=UxUR1UItWIkt9H5KgVLJBMHBn9wkbWw0b1yVLsOGm1M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IIYbnQpvAW/oNHcQlxG0hTR/Nxt7znxxcLiG46iiKjuRqaFXQHkya6CG1+8qT+jOMMA9MnCjJuF4q+nIMWlzCFSo3yTp5HqxjP6h5MdyrF4C9BmEoI1DI/0GgiduYDWAhQvYwMu8/aG2QsS5Da5XWpXy3VUrhbExY8Q9Fr+Ss2g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rzRD5lEt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rzRD5lEt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B7FBC4CEF7; Sat, 11 Apr 2026 07:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775893100; bh=UxUR1UItWIkt9H5KgVLJBMHBn9wkbWw0b1yVLsOGm1M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rzRD5lEtFhAU1Khuutk7K1zOXYDCBDzU0UJg5cT5x3Blm/QycNZiY6f3P6X1Ir6eu /MvG469/Axg1FRmOgMcrKl/yKxUFNvGI31UFYaS8vW2c295SojbI0ZR+ah37dL/rVv xaamX1PHjX+u5pbzmFRxNVL6iOADV9SnHinSX0gDfjiwX7UZ2QvnZ3rNmJDtbgjJTS WxvIDt1HosrkNdi7W9yLod4M5ycytyGIpvuEgNGxCB5HRjR3vkdaKh97L3gh+HlPnZ /eJxbl3OYBd+g/LQ8LlGKDq3/mYf2CaoS+ESZ/UzLum1WBowEsspSL8RDu6je7wJKy iZ0lnuJHgfS/A== Message-ID: Date: Sat, 11 Apr 2026 09:38:16 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] ARM: dts: qcom: msm8960: expressatt: Sort node references and includes To: Rudraksha Gupta , David Heidelberg , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260401-expressatt_fuel_guage-v3-0-9674cfc0b5a2@gmail.com> <20260401-expressatt_fuel_guage-v3-1-9674cfc0b5a2@gmail.com> <8e4ee378-113e-463d-8b21-eeef74b84120@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/04/2026 06:01, Rudraksha Gupta wrote: > On 4/7/26 14:46, David Heidelberg wrote: >> On 07/04/2026 23:04, Krzysztof Kozlowski wrote: >>> On 07/04/2026 22:39, Rudraksha Gupta wrote: >>>> On 4/7/26 12:59, Krzysztof Kozlowski wrote: >>>>> On 01/04/2026 22:32, Rudraksha Gupta via B4 Relay wrote: >>>>>> From: Rudraksha Gupta >>>>>> >>>>>> Reorganize the DTS file for consistency with other msm8960 board >>>>>> files. >>>>>> >>>>>> Assisted-by: Claude:claude-opus-4.6 >>>>>> Signed-off-by: Rudraksha Gupta >>>>>> --- >>>>>>    .../dts/qcom/qcom-msm8960-samsung-expressatt.dts   | 408 >>>>>> +++++++++++---------- >>>>>>    1 file changed, 207 insertions(+), 201 deletions(-) >>>>>> >>>>> Sorry, but no. We are not taking Claude as one determining coding >>>>> style. >>>>> Are we going to do the work again the moment we come with proper tool? >>>> >>>> There is no tool currently to auto format DTS, and doesn't seem to be >>>> coming for a while: >>>> >>>> https://www.youtube.com/watch?v=cvoIbTL_ZQA >>>> >>>> >>>> Claude didn't determine the coding style. I did based on sony-huashan, >>>> which is already upstream: >>>> >>>> https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/qcom/qcom-msm8960-sony-huashan.dts >>>> >>>> >>>> >>>> I just used Claude to do the manual work for me. In v2, I made sure the >>>> diff before and after the change was nill. v3 included additional >>>> changes requested by Konrad and some comments that I remembered during >>>> prior attempts mainlining patch series for this device. >>> >>> IMO, it is just too risky to let Claude reorganize the nodes, but I >>> assume reviewers of your code did run dtx_diff. >> >> I think it depends on the prompt. Since I’m performing many of the >> same tasks repeatedly across multiple sdm845 devices, asking an LLM to >> do node-by-node reorganization can be reasonably reviewable (at least >> when reviewing incremental progress, not just the final diff). >> >> I would prefer to do more of the sorting myself, but I find it quite >> tedious. The diff tool struggles when similar or identical lines >> appear in different nodes, which often results in a messy final diff >> (I noticed this in Sajattack’s sdm845 LG patchset). >> >> This leads me to an idea: >> >> For these sorting cleanups, perhaps we could introduce a “squash mode”? >> >> Contributors could submit commits per node, making the reorganization >> clearly visible (and ensuring nothing is accidentally lost), and then >> the maintainer could squash them into a single commit to avoid >> cluttering the git log. >> >> What do you think? > > Easiest solution would be to get Claude to make a DTS auto formatter. I > estimate it would likely take a couple iterations to get a functional > prototype and max a week to get it into a mergable state, if the style > is agreed beforehand. Simply provide DTS'es that follow the pattern you > like to Claude, then tell Claude that you want to make a Python script Yeah, and who wants to review the Claude code? I already have a formatter to review in the pipeline... > to auto format DTS files and make functions for each different common > style pattern identified in the DTS'es. I assume it would give a good > enough base to work off of. The most painful part will be determining > what the correct style for all DTS'es as I'm sure others will have > opinions on that. > The biggest problem is that no way maintainers will run untrusted 3rd party code, co-contributed by random people with Claude. Best regards, Krzysztof