From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable
Date: Fri, 7 Apr 2023 10:27:40 +0200 [thread overview]
Message-ID: <f52524da-719b-790f-ad2c-0c3f313d9fe9@linaro.org> (raw)
In-Reply-To: <20230407-pm7250b-sid-v1-2-fc648478cc25@fairphone.com>
On 07/04/2023 09:45, Luca Weiss wrote:
> Like other Qualcomm PMICs the PM7250B can be used on different addresses
> on the SPMI bus. Use similar defines like the PMK8350 to make this
> possible.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++-------
> 1 file changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index daa6f1d30efa..eeb476edc79a 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -7,6 +7,15 @@
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/spmi/spmi.h>
>
> +/* This PMIC can be configured to be at different SIDs */
> +#ifndef PM7250B_SID
> + #define PM7250B_SID 2
Drop indentation, although anyway I am against this. Please don't bring
new patterns of this at least till we settle previous discussion.
https://lore.kernel.org/linux-arm-msm/46658cbb-fff5-e98b-fdad-88fa683a9c75@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-07 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-07 7:45 [PATCH 0/2] Make SID for PM7250B configurable (and a small fixup) Luca Weiss
2023-04-07 7:45 ` [PATCH 1/2] arm64: dts: qcom: pm7250b: add missing spmi-vadc include Luca Weiss
2023-04-07 7:45 ` [PATCH 2/2] arm64: dts: qcom: pm7250b: make SID configurable Luca Weiss
2023-04-07 8:27 ` Krzysztof Kozlowski [this message]
2023-04-07 8:29 ` Luca Weiss
2023-05-10 6:47 ` Luca Weiss
2023-05-10 6:55 ` Krzysztof Kozlowski
2023-05-10 8:07 ` Dmitry Baryshkov
2023-05-10 8:34 ` Luca Weiss
2023-05-10 8:55 ` Dmitry Baryshkov
2023-05-10 10:05 ` Krzysztof Kozlowski
2023-05-10 11:27 ` Luca Weiss
2023-08-17 7:40 ` Luca Weiss
2023-05-26 19:38 ` [PATCH 0/2] Make SID for PM7250B configurable (and a small fixup) Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f52524da-719b-790f-ad2c-0c3f313d9fe9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).