From: Stephen Boyd <sboyd@kernel.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Evan Green <evgreen@chromium.org>,
Georgi Djakov <djakov@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Leo Yan <leo.yan@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH v6 00/22] Restructure RPM SMD ICC
Date: Thu, 15 Jun 2023 10:35:12 -0700 [thread overview]
Message-ID: <f526046568e6bbc8dc567109e6911f65.sboyd@kernel.org> (raw)
In-Reply-To: <8568eead-90f6-ce15-d483-4d72dbab6294@linaro.org>
Quoting Konrad Dybcio (2023-06-15 00:52:07)
> On 15.06.2023 02:49, Stephen Boyd wrote:
> > Quoting Konrad Dybcio (2023-06-14 11:04:19)
> >> This series reshuffles things around, moving the management of SMD RPM
> >> bus clocks to the interconnect framework where they belong. This helps
> >> us solve a couple of issues:
> >>
> >> 1. We can work towards unused clk cleanup of RPMCC without worrying
> >> about it killing some NoC bus, resulting in the SoC dying.
> >> Deasserting actually unused RPM clocks (among other things) will
> >> let us achieve "true SoC-wide power collapse states", also known as
> >> VDD_LOW and VDD_MIN.
> >>
> >> 2. We no longer have to keep tons of quirky bus clock ifs in the icc
> >> driver. You either have a RPM clock and call "rpm set rate" or you
> >> have a single non-RPM clock (like AHB_CLK_SRC) or you don't have any.
> >>
> >> 3. There's less overhead - instead of going through layers and layers of
> >> the CCF, ratesetting comes down to calling max() and sending a single
> >> RPM message. ICC is very very dynamic so that's a big plus.
> >>
> >> The clocks still need to be vaguely described in the clk-smd-rpm driver,
> >> as it gives them an initial kickoff, before actually telling RPM to
> >> enable DVFS scaling. After RPM receives that command, all clocks that
> >> have not been assigned a rate are considered unused and are shut down
> >> in hardware, leading to the same issue as described in point 1.
> >
> > Why can't we move the enable of DVFS scaling call to the interconnect
> > driver as well? We want the clk driver to not reference the interconnect
> > resources at all.
> That would result in no rpmcc ratesetting on platforms without a functional
> interconnect driver. The DVFS call concerns both bus and !bus clocks.
>
That's the intent. Probe the interconnect driver to get bus clk rate
setting.
What are the !bus clocks managed by RPM?
next prev parent reply other threads:[~2023-06-15 17:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 18:04 [PATCH v6 00/22] Restructure RPM SMD ICC Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 01/22] dt-bindings: interconnect: Add Qcom RPM ICC bindings Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 02/22] soc: qcom: smd-rpm: Add QCOM_SMD_RPM_STATE_NUM Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 03/22] soc: qcom: smd-rpm: Use tabs for defines Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 04/22] clk: qcom: smd-rpm: Move some RPM resources to the common header Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 05/22] soc: qcom: smd-rpm: Move icc_smd_rpm registration to clk-smd-rpm Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 06/22] interconnect: qcom: icc-rpm: Introduce keep_alive Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 07/22] interconnect: qcom: Add missing headers in icc-rpm.h Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 08/22] interconnect: qcom: Fold smd-rpm.h into icc-rpm.h Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 09/22] interconnect: qcom: smd-rpm: Add rpmcc handling skeleton code Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 10/22] interconnect: qcom: Define RPM bus clocks Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 11/22] interconnect: qcom: sdm660: Hook up RPM bus clk definitions Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 12/22] interconnect: qcom: msm8996: " Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 13/22] interconnect: qcom: qcs404: " Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 14/22] interconnect: qcom: msm8939: " Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 15/22] interconnect: qcom: msm8916: " Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 16/22] interconnect: qcom: qcm2290: " Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 17/22] interconnect: qcom: icc-rpm: Control bus rpmcc from icc Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks Konrad Dybcio
2023-06-15 0:48 ` Stephen Boyd
2023-06-15 7:49 ` Konrad Dybcio
2023-06-16 20:27 ` Stephen Boyd
2023-06-14 18:04 ` [PATCH v6 19/22] interconnect: qcom: icc-rpm: Fix bucket number Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 20/22] interconnect: qcom: icc-rpm: Set bandwidth on both contexts Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 21/22] interconnect: qcom: icc-rpm: Set correct bandwidth through RPM bw req Konrad Dybcio
2023-06-14 18:04 ` [PATCH v6 22/22] interconnect: qcom: icc-rpm: Fix bandwidth calculations Konrad Dybcio
2023-06-15 0:49 ` [PATCH v6 00/22] Restructure RPM SMD ICC Stephen Boyd
2023-06-15 7:52 ` Konrad Dybcio
2023-06-15 17:35 ` Stephen Boyd [this message]
2023-06-15 17:37 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f526046568e6bbc8dc567109e6911f65.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=evgreen@chromium.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).