From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, shawnguo@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, eha@deif.com, angelo@sysam.it,
andrew.smirnov@gmail.com, gustavo@embeddedor.com,
weic@nvidia.com, mhosny@nvidia.com, peng.ma@nxp.com
Subject: Re: [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A
Date: Mon, 09 Mar 2020 19:03:06 +0100 [thread overview]
Message-ID: <f530a0740f34b2cf26a8055d4eae2527@walle.cc> (raw)
In-Reply-To: <20200309145624.10026-1-olteanv@gmail.com>
Am 2020-03-09 15:56, schrieb Vladimir Oltean:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> This series addresses a few issues that were missed during the previous
> series "[PATCH 00/12] TCFQ to XSPI migration for NXP DSPI driver", on
> SoCs other than LS1021A and LS1043A. DMA mode has been completely
> broken
> by that series, and XSPI mode never worked on little-endian
> controllers.
>
> Then it introduces support for the LS1028A chip, whose compatible has
> recently been documented here:
>
> https://lore.kernel.org/linux-devicetree/20200218171418.18297-1-michael@walle.cc/
If it is not compatible with the LS1021A the second compatible string
should be removed. Depending on the other remark about the endianess,
it might still be compatible, though.
> The device tree for the LS1028A SoC is extended with DMA channels
> definition, such that even though the default operating mode is XSPI,
> one can simply change DSPI_XSPI_MODE to DSPI_DMA_MODE in the
> devtype_data structure of the driver and use that instead.
wouldn't it make more sense, to use DMA is the dma node is present
in the device tree? otherwise use XSPI mode? I don't think it is
really handy to change the mode inside the driver.
-michael
>
> For testing, benchmarking and debugging, the mikroBUS connector on the
> LS1028A-RDB is made available via spidev.
>
> Vladimir Oltean (6):
> spi: spi-fsl-dspi: Don't access reserved fields in SPI_MCR
> spi: spi-fsl-dspi: Fix little endian access to PUSHR CMD and TXDATA
> spi: spi-fsl-dspi: Fix oper_word_size of zero for DMA mode
> spi: spi-fsl-dspi: Add support for LS1028A
> arm64: dts: ls1028a: Specify the DMA channels for the DSPI
> controllers
> arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS
>
> .../boot/dts/freescale/fsl-ls1028a-rdb.dts | 14 +++++
> .../arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 +++
> drivers/spi/spi-fsl-dspi.c | 54 +++++++++++++++----
> 3 files changed, 64 insertions(+), 10 deletions(-)
next prev parent reply other threads:[~2020-03-09 18:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 14:56 [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Vladimir Oltean
2020-03-09 14:56 ` [PATCH 1/6] spi: spi-fsl-dspi: Don't access reserved fields in SPI_MCR Vladimir Oltean
2020-03-09 18:05 ` Michael Walle
2020-03-09 18:09 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 2/6] spi: spi-fsl-dspi: Fix little endian access to PUSHR CMD and TXDATA Vladimir Oltean
2020-03-09 17:59 ` Michael Walle
2020-03-09 18:07 ` Vladimir Oltean
2020-03-09 18:19 ` Michael Walle
2020-03-09 18:31 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 3/6] spi: spi-fsl-dspi: Fix oper_word_size of zero for DMA mode Vladimir Oltean
2020-03-09 14:56 ` [PATCH 4/6] spi: spi-fsl-dspi: Add support for LS1028A Vladimir Oltean
2020-03-09 18:38 ` Michael Walle
2020-03-09 18:51 ` Vladimir Oltean
2020-03-09 14:56 ` [PATCH 5/6] arm64: dts: ls1028a: Specify the DMA channels for the DSPI controllers Vladimir Oltean
2020-03-09 19:06 ` Michael Walle
2020-03-09 19:59 ` Vladimir Oltean
2020-03-09 20:17 ` Michael Walle
2020-03-09 14:56 ` [PATCH 6/6] arm64: dts: ls1028a-rdb: Add a spidev node for the mikroBUS Vladimir Oltean
2020-03-09 18:35 ` Michael Walle
2020-03-09 18:50 ` Vladimir Oltean
2020-03-09 18:58 ` Michael Walle
2020-03-09 18:03 ` Michael Walle [this message]
2020-03-09 18:14 ` [PATCH 0/6] NXP DSPI bugfixes and support for LS1028A Vladimir Oltean
2020-03-09 18:31 ` Michael Walle
2020-03-09 18:48 ` Vladimir Oltean
2020-03-09 18:59 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f530a0740f34b2cf26a8055d4eae2527@walle.cc \
--to=michael@walle.cc \
--cc=andrew.smirnov@gmail.com \
--cc=angelo@sysam.it \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eha@deif.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhosny@nvidia.com \
--cc=olteanv@gmail.com \
--cc=peng.ma@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=weic@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).