From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCB55CA6F for ; Wed, 22 Jul 2026 08:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708890; cv=none; b=bRWVbVYx/1ur1B85fwzAiApXtCEgHGAj8vurfoBFKmTzxcXXVLKqNsUB6Z410+vsudxzRGjckPdlarpzaxqK0eX+15vohdr3075ZFKfy/5CWo5dP0klxCpl9gl3HMC/nBS0WhMpirQE+GtWVly9gyUemrQMpjwbCR+C1IeBiTWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784708890; c=relaxed/simple; bh=TkK8+LPz3NLYgchZpLtTgVE409WX1AzhZy1O6ggVhyQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LOPWIXEHbzwMbRWA6KodfYPz7Xe37tfAEIPCNInxPQ964ogAgwXVD3oXMrZ3diuHAm9DQpHsrSlOiTQ2ai+f0RAz1EsTeZkjpkgwB1yAx2IXXuEusIZha6R8VoaxB/LGqXTxV1FcNX9pvmvrKMZlFA3mxp4BLx8765lv89VUm5Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TkhDpZ4t; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KuFeEGAg; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TkhDpZ4t"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KuFeEGAg" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M6fojO200347 for ; Wed, 22 Jul 2026 08:28:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=TkhDpZ4tS7+g6FSu V7hA31jvtXYwG8KYuedqPWY2GzKy10BPTSi76qlCpspHrBvRIpDD6sZjr8tRdJyD 5SgMYd+5tUtvFIDkcPUR89Kej60q2/cRRhTMCmLCdTGmXacX8Skz6H3KSqYwF02E KuQS5Tw5yjxdY3+IWY3rCoYvAyp+VLz4uO6svqk8oRV7umNEedPcP4tytvgAQ/D6 2L7ulhngw4C6rA7P4W1zZzCJSAOhIa+TEDiJ/ZJ1zEQZoXZfCdMyndzNnV5CGCcy GjBKW7wLRhJIDe4XFZThZM03+utPhHYrJrUFW5giJBeoVJdGpBvbwVvGmPqzednG 3SExMA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fjrtt0eat-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 22 Jul 2026 08:28:03 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-9309b0f05fcso114741785a.1 for ; Wed, 22 Jul 2026 01:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784708882; x=1785313682; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=KuFeEGAgvF+vZl5wdpo+I3s3KtYfiXzcl1ww7ofB4rGIEgf1f4lKntUwH8+Qodz/38 iZ5+iwh6+7VbQ8XPb5uL/L7hDYXCFszuGXUP+UwYcxygBKByO9F+Tp3jWNuiR/FrnGSO EgGWaCUOA4NUqqjnbERY4WysIH1tNTvrb3DePTQtHBoyQN1D20jFU9RwRrjzgxMHeS8U /wk6z9pcd/oY0fR7jhHmM68Es5TWt1h5SBUthFkp99/bixn2+ng4Jc2LAUW3RmNuFPSY Rl+MprY+5WFtKYMvg5KEXjmh5wcClNCrvBNp/uoJBCwx4M7d0erpjZx85N97yHecmvtR Zg5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784708882; x=1785313682; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mIsymjFuprG4so7Q98HuwxLOIzy0qsmeHV37HSxMH4Q=; b=PuIHTN03DcL7jwL64lzfdUxPuvxZh6DFaMy1lLipKUqU5rsqOFH1qg4vvz+NQDZT6t YV4r52+mf47KTSuxVJz6WYCRvLkPJzJTJgsa4o9+JSHLTerSZTAY3Gwpr2x3fH5zrK9w EXDSJzmr7k+HMx4EUarxFQ9gNpw0jcLKrLGWxMvif7fYFp4ZsXyEe9gCwJZxe/kYSjKn lgj0GBy7Q2ZDPWOtwZI/c+wEpOMP0Osp3k4v17j8yFM2VXnLfjgLLlov60qXAEwuw/56 T4MbSIdQczTb5z5nmhZvfRsdcXwT7dN5/eKdzVPXviwI7/rkZBvv88y5K01zFNcw1Bsg vp2A== X-Forwarded-Encrypted: i=1; AHgh+RqCUX673cwzAl4c+SZWy8AA/8Yd6qbnPY+qqy3WpyxiteTRy1E4vnl6gjFlQmA8hGFOoGXE+ZWvN/gP@vger.kernel.org X-Gm-Message-State: AOJu0Yx8G/XVYjj5jT/Seo/lcjSPUg7omdu4DJFi0m/wf5BTnph5uB+2 chxXobbfCRNFXaepNtHjoWmxHvt2Aa+coaySDfIBkKKAZnae/XFIcNuxWc74R3BHQF9H6CC4Vw9 VxNng8XbD3l6AvI1xQQNwjjQecU8UFwkG5NQZIt6GGwLR0pFHUMo+JRJIiQF2dMf3 X-Gm-Gg: AR+sD11rgBA+CDKQm8OH4vtJ9BrWK+1MDUxvUOKmiIBy6YJe8I50g49au1uE/qyMVP6 KzrbeQq6QRdPKzGCsE/MxclP5TPmal/g96PTcjfBTOESQjsXZuLz+X9so2aCl9RV5HE4IVRHYYz WpSB0NUQryqbYkP8IA6YssBFieGF71zDlRkOK3xkgK4HSQmNuLlGF7WtgAuQ7WCv3XcJX0D9Hg0 1GfVIHC8E2raKeL1JEJnmgm84cMKkTCbsryga/RaxqopNnnI2SgDYsceE5vqaY2shD4hEtwrArR Ueuz4k0zx0CJ3+Mc3rF65EM2FhztNpHoPoKYhDcFngW6vWUTpSFv4NaJeR1pgKzffl2ObvuAt2E jI0tUTjm1FvYxYyXmDJDM8Yef X-Received: by 2002:a05:620a:1709:b0:92e:705f:1626 with SMTP id af79cd13be357-930f458fd0emr196446485a.6.1784708882432; Wed, 22 Jul 2026 01:28:02 -0700 (PDT) X-Received: by 2002:a05:620a:1709:b0:92e:705f:1626 with SMTP id af79cd13be357-930f458fd0emr196445785a.6.1784708882047; Wed, 22 Jul 2026 01:28:02 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69f34ba67f0sm621763a12.12.2026.07.22.01.27.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2026 01:28:00 -0700 (PDT) Message-ID: Date: Wed, 22 Jul 2026 10:27:57 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/5] usb: typec: ps883x: fixes for older Thunderbolt 4 / USB4 docks To: Sebastian Reichel , "Dr. David Alan Gilbert" Cc: jens.glathe@oldschoolsolutions.biz, Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Heikki Krogerus , Bjorn Andersson , Konrad Dybcio , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org References: <20260718-ps883x-disable-usb4-v1-0-cec86d0b909e@oldschoolsolutions.biz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: 7T6itlOq92s8Jjo4Sz_DZui58e6nnWCe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDA3OCBTYWx0ZWRfXxH934D7Lon9c 1R0FfvUNgtGPf7tggTMqPQT+JBPOVEYZxmezfFMl8AqFcZ4EttRlfkmC/Uu+iHWEW78J0h2TK/h fOxVn231xrop8UtLw5SCWaaiJUqbZvbqfxMmgu9LYiymovBNg/NBYbJtbKTQFg7hXGhDcMpGIKu pMZGK2XMZOQgSlmnphx/umdrXkJY1AZ2F2wZ+C+3cR/fYTla7meSSZJRa2ZpRpdtRTV33sGwnGD JurFcyhLJqTkciI0xVnMb/fJBjnxZOId+xWDYHOdM9TZpejHpnhuZ2jp9R5dsjgqn3UIFdL6sB+ LkxmKtj1fQFs+PtOlS33nmFA/4pqvu4KP7QrP2uqGCSmCGvADjMP6qIRP5/5xVgWdwJPbooB7ZR vJATyV6qqf7ykYBn2bi7oE6HvIrYwTMtwmQNDdBCQPZjzuGRml/mYm9yZyxFAa2AxWO81llTn+8 9cEgjR/nTMAMzN9JfkQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDA3OCBTYWx0ZWRfX2lqECHnSliH8 zCtSXnUbiqVPKLMvIzDVaRsNntGPDeC1X3Oen7h3h/BWVl14wOPF7IIxek5QBEivf1AhE5N/0KH ajoTewBYtOGpe6rWw56aPrRbaZ9tFNc= X-Proofpoint-GUID: 7T6itlOq92s8Jjo4Sz_DZui58e6nnWCe X-Authority-Analysis: v=2.4 cv=V8lNF+ni c=1 sm=1 tr=0 ts=6a607f13 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=B0dxQpQml5LPzYmAcjoA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=lhd_8Stf4_Oa5sg58ivl:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-22_02,2026-07-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607220078 On 7/22/26 1:34 AM, Sebastian Reichel wrote: > Hi, > > On Tue, Jul 21, 2026 at 04:24:06PM +0000, Dr. David Alan Gilbert wrote: >> * Sebastian Reichel (sre@kernel.org) wrote: >>> On Sat, Jul 18, 2026 at 07:06:28PM +0200, Jens Glathe via B4 Relay wrote: >>>> On Qualcomm X1E80100 platforms (e.g. Lenovo ThinkPad T14s Gen 6) >>>> using the Parade PS883x retimer, connecting USB4-capable docks such >>>> as the Lenovo 40B0 via a regular Type-C cable (which forces the dock >>>> into Type-C fallback mode) often results in working USB but no >>>> DisplayPort output. [...] > AFAIK only Qcom and Apple M series support it. A quick search > suggsts Apple used an Intel retimer in the past and a custom one > nowadays. From the looks of it the x86 world cannot use this driver > either and probably handles retimers transparently in ACPI, so it's > effectively Qcom specific until other vendors start adding USB4 > support. The only thing announced potentially running into this > would be the Nvidia RTX Spark, which first needs to be released, > then find a bunch of people motivated to implement upstream support. > Nothing with USB4 capabilities has been announced from Mediatek or > Rockchip. So I wouldn't hold my breath for another user and still > suggested adding the machine check instead of simply disabling USB4 > for everyone ;) The PS883x is used on x86 machines too. Apart from I2C, it also ""speaks thunderbolt"" - the bus has a way for retimers to enumerate and communicate with the routers (controllers) through a sideband UART-like interface. But for that, it still probably needs the platform firmware to program it into the right mode over I2C, which Linux is unaware of (as it effectively should be). FWIW, we do the same on X2. An MCU takes care of setting it up. Konrad