From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A10E16EC0B for ; Tue, 6 Aug 2024 23:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722985626; cv=none; b=nxx+4klcFhq0sdV3+7rUOfdNTmJ+I5RrEFw1K3GDDhmdLt3NWc7AvgDX9YCUUgf3EuV8Yr6mnvpGHqajLr50IOEqFzEnPxdKUA2lCx86OqSPqokYe8JcuFMb3SeJAE1tNo5md+aJr+d+BPAvPtfr0zg+Di8fTnlrqQa6KLqfVFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722985626; c=relaxed/simple; bh=0J/AdXiVvWShheGvPmUlMjBN3kfV+t5JnxiCk1W3uBM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=st8llYzOft1OgBVnaMWpYV6iaSIVhIlhk4DSiBxj+/HZtmyUjHQXs66sNgQAnrQc/PWkcYiJwURcp2fvhwlHZjozXbOTCpl7lCCAA7A+k6DDLQlDliu41h/HNewZr0iaa2/OHiSBY0leIdwXAGq5pPB6q+BraOugCBZ2CIiwvYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=J3zwoikl; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J3zwoikl" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4280c55e488so1888195e9.0 for ; Tue, 06 Aug 2024 16:07:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722985622; x=1723590422; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=lRTZ4GySlfkCXEPTYyeONrIuCjnP06hZmIkMCl/2KwE=; b=J3zwoiklg4reVR1bfIj4orhh1W919oFjAVgDDuAVxZgkfYIHHMNK2dRBqNAsVReTcq MlAGB+FHdyzZsAF+bABxA3ABN4542ICLbk2fhnwiyLJ6CoVravJd7O4CQF7KuHagOr+L otKPfQun2i44LtumLA4nB4YKPhgUHsslEHs58HAVJuA9GoM5fECSAO23B/5AinOh6rNp uZpbrwTc6WGnYciqjbJmm8dF7P5H5OjHrqJ07DfnE7oDwY3gL+WgU0tdaxPxJLwoZEZJ 04XQvUE3Dgx4q0YXTjp3t8qRMAXbQebrWNGQ4vmYfPaVkReKqzoh6gHK7MlPnOUIC0c0 oDeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722985622; x=1723590422; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lRTZ4GySlfkCXEPTYyeONrIuCjnP06hZmIkMCl/2KwE=; b=fbX4zSy9l/hLhIo8Blo7nc+iUsnpwyaIGb7irmhKwZWVdTf5tp83ePQqZnHCiUOqUj Mtf0fajfiP7hs+CSU4DHzHSHeQ+JCFAue4sdWX2RROUgD9rncs0VD3SvbPdsJPBHRxiG Xzdt3bCprUqJ8FBN03BijaQfqoSQXIPda5P+dBTpoWVTrVlzTXsLK2Nzip//GpjpOiU6 /UyiImeWgVD2U5rtVwLyL8/uk/lI0fn54a0f3xGm9juaK1uAIOJgOjffJIg4STHVakNR L5QpkXeg6d3FsqDvr1G+E9w/VK5VMLIeCii/flt+eWTFzOMKRCx0ALPsnBckvyxwnAQQ fnLA== X-Forwarded-Encrypted: i=1; AJvYcCUAasaGT7D1VZW+tDB56Z8Bk0xb1Fq3SxYVX3N2riGesL9pGAjlujUk637oHoV5tAdsFXTvJHaT6B0FH21hs1RjjNMTjoPOIwb6ng== X-Gm-Message-State: AOJu0Yw4JjBSYJBu2gBGpZ2xYpjFQXbBIafgNiN8SwdcYQA1lbH9PFA1 AybgmbnI23acyB9v4VCEjShchOTXgnxahA8b5Dc+kjMTFAoGldKLN1tR1/XnxPg= X-Google-Smtp-Source: AGHT+IHVkAyWkxha6j6qpZF3mUMmg3Wku7DOp4M2iAUcjBVgKEazfg96PdMW9g2QjN+9IAXzecctXg== X-Received: by 2002:a05:600c:5129:b0:426:5cc7:82f with SMTP id 5b1f17b1804b1-429052cfb3dmr1682185e9.13.1722985621679; Tue, 06 Aug 2024 16:07:01 -0700 (PDT) Received: from [192.168.0.25] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429059713adsm1284205e9.11.2024.08.06.16.07.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 16:07:01 -0700 (PDT) Message-ID: Date: Wed, 7 Aug 2024 00:07:00 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] media: camss: add support for SDM670 camss To: Richard Acayan , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org References: <20240806224219.71623-7-mailingradian@gmail.com> <20240806224219.71623-10-mailingradian@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240806224219.71623-10-mailingradian@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 06/08/2024 23:42, Richard Acayan wrote: > The camera subsystem for the Snapdragon 670 is like on SDM845, but with > 3 CSIPHY ports instead of 4. Add support for the SDM670 camera > subsystem. "The camera subsystem for the SDM670 is the same as on SDM845 but, " The naming should be consistent and the comma if you're using it should come after not before the but. > Signed-off-by: Richard Acayan > --- > drivers/media/platform/qcom/camss/camss.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c > index 51b1d3550421..05a47b82c012 100644 > --- a/drivers/media/platform/qcom/camss/camss.c > +++ b/drivers/media/platform/qcom/camss/camss.c > @@ -2403,6 +2403,17 @@ static const struct camss_resources sdm660_resources = { > .link_entities = camss_link_entities > }; > > +static const struct camss_resources sdm670_resources = { > + .version = CAMSS_845, > + .csiphy_res = csiphy_res_845, > + .csid_res = csid_res_845, > + .vfe_res = vfe_res_845, > + .csiphy_num = 3, > + .csid_num = ARRAY_SIZE(csid_res_845), > + .vfe_num = ARRAY_SIZE(vfe_res_845), > + .link_entities = camss_link_entities > +}; > + > static const struct camss_resources sdm845_resources = { > .version = CAMSS_845, > .csiphy_res = csiphy_res_845, > @@ -2447,6 +2458,7 @@ static const struct of_device_id camss_dt_match[] = { > { .compatible = "qcom,msm8916-camss", .data = &msm8916_resources }, > { .compatible = "qcom,msm8996-camss", .data = &msm8996_resources }, > { .compatible = "qcom,sdm660-camss", .data = &sdm660_resources }, > + { .compatible = "qcom,sdm670-camss", .data = &sdm670_resources }, > { .compatible = "qcom,sdm845-camss", .data = &sdm845_resources }, > { .compatible = "qcom,sm8250-camss", .data = &sm8250_resources }, > { .compatible = "qcom,sc8280xp-camss", .data = &sc8280xp_resources }, Nice work, please fixup the commit long and add. Reviewed-by: Bryan O'Donoghue