devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sricharan Ramabadhran <quic_srichara@quicinc.com>,
	agross@kernel.org, andersson@kernel.org,
	konrad.dybcio@linaro.org, srinivas.kandagatla@linaro.org,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org, thara.gopinath@gmail.com, rafael@kernel.org,
	daniel.lezcano@linaro.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: Re: [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible
Date: Fri, 15 Sep 2023 14:45:14 +0200	[thread overview]
Message-ID: <f5aee51d-0345-1294-a85b-ea96ed937685@linaro.org> (raw)
In-Reply-To: <03b0cafa-49c7-8838-b116-927c9649cbd3@linaro.org>

On 15/09/2023 14:43, Krzysztof Kozlowski wrote:
> On 15/09/2023 14:15, Sricharan Ramabadhran wrote:
>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt.
>>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>> ---
>>  [v2] Sorted the compatible and removed example
>>
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

No, unreviewed. Your driver says it is not compatible with
qcom,tsens-v1. This does not look right :/

Best regards,
Krzysztof


  reply	other threads:[~2023-09-15 12:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15 12:15 [PATCH V2 0/4] Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-09-15 12:15 ` [PATCH V2 1/4] dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible Sricharan Ramabadhran
2023-09-15 12:43   ` Krzysztof Kozlowski
2023-09-15 12:45     ` Krzysztof Kozlowski [this message]
2023-09-19  7:22       ` Sricharan Ramabadhran
2023-09-19 12:32         ` Krzysztof Kozlowski
2023-09-19 12:48           ` Sricharan Ramabadhran
2023-09-19 12:56             ` Krzysztof Kozlowski
2023-09-19 16:26               ` Sricharan Ramabadhran
2023-09-15 12:15 ` [PATCH V2 2/4] thermal/drivers/qcom: Add new feat for soc without rpm Sricharan Ramabadhran
2023-09-15 18:45   ` Dmitry Baryshkov
2023-09-15 12:15 ` [PATCH V2 3/4] thermal/drivers/tsens: Add support for IPQ5018 tsens Sricharan Ramabadhran
2023-09-15 18:44   ` Dmitry Baryshkov
2023-09-19  7:26     ` Sricharan Ramabadhran
2023-09-15 12:15 ` [PATCH V2 4/4] arm64: dts: qcom: ipq5018: Add tsens node Sricharan Ramabadhran
2023-09-15 12:46   ` Krzysztof Kozlowski
2023-09-19  7:28     ` Sricharan Ramabadhran
2023-09-19 12:37       ` Krzysztof Kozlowski
2023-09-19 16:15         ` Sricharan Ramabadhran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5aee51d-0345-1294-a85b-ea96ed937685@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=quic_srichara@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=thara.gopinath@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).