From: Sricharan R <sricharan@codeaurora.org>
To: Vinod <vkoul@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: ohad@wizery.com, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, sibis@codeaurora.org
Subject: Re: [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver
Date: Thu, 7 Jun 2018 15:02:12 +0530 [thread overview]
Message-ID: <f5b05d4f-29d6-c698-3618-4ad6e42aef54@codeaurora.org> (raw)
In-Reply-To: <20180607084348.GG16230@vkoul-mobl>
Hi Vinod,
On 6/7/2018 2:13 PM, Vinod wrote:
> On 06-06-18, 21:24, Bjorn Andersson wrote:
>> On Wed 06 Jun 21:11 PDT 2018, Vinod wrote:
>>
>>> So, wouldn't Kconfig syntax something like where we say:
>>> M if RPMSG_QCOM_GLINK_SMEM=m
>>> bool if RPMSG_QCOM_GLINK_SMEM=y
>>>
>>
>> If we ignore SMD for a while we have the following combinations:
>>
>> glink/wcss
>> y y - valid
>> y m - valid
>> y n - valid
>> m y - link failure (invalid)
>> m m - valid
>> m n - valid
>> n y - valid (platform uses wcss, but not glink)
>> n m - valid (-----"-----)
>> n n - valid
>>
>> So to distill this we have the two valid cases:
>> module/no if RPMSG_QCOM_GLINK_SMEM=m
>> yes/module/no if RPMSG_QCOM_GLINK_SMEM=y
>>
>> and the way you express that in Kconfig is the somewhat awkward
>>
>> depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
>
> Understood now :) Yes it is awkward..
>
> Btw we seem to have issue with link fail here when glink is m and wcss
> is y. Why don't we see link fail for glink being n? Yes I understand that
> platform uses wcss but am curious how that works out :)
For glink being n, the stub functions gets linked, and not for glink=m.
Regards,
Sricharan
--
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus
prev parent reply other threads:[~2018-06-07 9:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-05 5:42 [PATCH] remoteproc: qcom: Introduce Hexagon V5 based WCSS driver Sricharan R
2018-06-05 6:19 ` Vinod
2018-06-05 12:56 ` Sricharan R
2018-06-05 16:40 ` Vinod Koul
2018-06-06 6:39 ` Sricharan R
2018-06-06 6:49 ` Vinod
2018-06-06 9:51 ` Sricharan R
2018-06-06 16:17 ` Bjorn Andersson
2018-06-07 4:11 ` Vinod
2018-06-07 4:24 ` Bjorn Andersson
2018-06-07 5:29 ` Sricharan R
2018-06-07 5:48 ` Bjorn Andersson
2018-06-07 6:36 ` Sricharan R
2018-06-07 8:43 ` Vinod
2018-06-07 9:32 ` Sricharan R [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b05d4f-29d6-c698-3618-4ad6e42aef54@codeaurora.org \
--to=sricharan@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).