From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Adam Ford <aford173@gmail.com>, linux-arm-kernel@lists.infradead.org
Cc: aford@beaconembedded.com, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Shengjiu Wang <shengjiu.wang@nxp.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: fsl_easrc: Add support for imx8mp-easrc
Date: Sun, 20 Aug 2023 22:32:17 +0200 [thread overview]
Message-ID: <f5b16676-04b9-7864-ffa7-1c48f3c2ca9c@linaro.org> (raw)
In-Reply-To: <20230820175655.206723-1-aford173@gmail.com>
On 20/08/2023 19:56, Adam Ford wrote:
> The i.MX8MP appears to have the same easrc support as the Nano, so
> add imx8mp as an option with a fallback to imx8mn.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> index bdde68a1059c..2d53b3b10f2c 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,easrc.yaml
> @@ -14,7 +14,11 @@ properties:
> pattern: "^easrc@.*"
>
> compatible:
> - const: fsl,imx8mn-easrc
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx8mp-easrc
> + - const: fsl,imx8mn-easrc
You need here also const for fsl,imx8mn-easrc, otherwise you do not
allow it alone. Test it for fsl,imx8mn-easrc DTS - you will notice warnings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-20 20:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 17:56 [PATCH 1/3] ASoC: dt-bindings: fsl_easrc: Add support for imx8mp-easrc Adam Ford
2023-08-20 17:56 ` [PATCH 2/3] arm64: dts: imx8mp: Add easrc node Adam Ford
2023-08-20 17:56 ` [PATCH 3/3] arm64: dts: imx8mp: Add micfil node Adam Ford
2023-08-20 18:28 ` [PATCH 1/3] ASoC: dt-bindings: fsl_easrc: Add support for imx8mp-easrc Rob Herring
2023-08-20 20:32 ` Krzysztof Kozlowski [this message]
2023-08-20 20:33 ` Krzysztof Kozlowski
2023-08-20 21:05 ` Adam Ford
2023-08-21 6:18 ` Krzysztof Kozlowski
2023-08-21 14:06 ` Rob Herring
2023-08-21 15:03 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5b16676-04b9-7864-ffa7-1c48f3c2ca9c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).