From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6A9D1946AB for ; Thu, 27 Jun 2024 13:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719495606; cv=none; b=oW/8jLBpKil7FM/2tTpbfQOscz/Z6uXUQaQmX8DFmuqEArwqW4wh35VQE6TQSD62vqU0AvzMHgdsexwDv83mAuO+jg2kMSaQxQz47YTWGqHh25eUSGeTOcjgWULRyFBW4315bdhVnYhSueR4XbhpEqnaVGRQIh8/71C6l/TN0fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719495606; c=relaxed/simple; bh=aGc8aFwRyyZj5ciH2IgK5k1zc3vRQs8wEk0o8RJm4uY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SRNs0ikz54x+d9nKb6arX2Sq59tr/ruITqyfZQJr2gg8HpynXA7a647j8RY2+NNaVwqzM8RvK4qsSovqHjI1Zw6KQdsSiMmNRw4e0M/c/OcwxME5s1CMxiXO5eTYhmaKvrWYUAWk4TsbLLcDMHjDzd5psfGWXuA+QOeKK7i8Cv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=X5dkkpkb; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X5dkkpkb" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-57d044aa5beso1754042a12.2 for ; Thu, 27 Jun 2024 06:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719495603; x=1720100403; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=eyQnqPkrN/PCWoa6AOkfJ9CNY96pT7M4vjPSBgYrrI4=; b=X5dkkpkbp2GFgV+BtGyHBWMcxiXXxamFahzeg0909f1nFEH26iGzkz9eKzCn9uB5gl dSwUuzTXNE6n5MBFrJtlwfvDLq8gehJgCgrB3xsq/LrTzzYXm3MLD5Lkbi4g6SjjUkZ1 chWse9hcqYMrfvKSh75Kz0KVc/Cygy8A41+ntVNei7UI1yhFR+uakOqNjdb+b4ySE7th kdjw6N+oF6pDbguffn+1eOHI5DTJE8HpAO3y2BRAVqVeixXCCU03guE+kh6tfnxkL6I1 /Q/3/q9iQlKrfN7OF6rQYxXKDN4tfvsNw2+TWKAKu2+8uQW2k33LEF7qJbtAArRHPByk VloA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719495603; x=1720100403; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eyQnqPkrN/PCWoa6AOkfJ9CNY96pT7M4vjPSBgYrrI4=; b=Xvj62z4YHmz3lqwsBN/OFZwkSikSvUYHSTBK/NrF1eIvEutFiQNh3n26DT7fV/f3Jq iLEbbVZr4uCLqw6k/hSE+CCciz5ZSdiSPoDGJm1QNlEsPfgtGMzTEkAfLUgACAM3sFhD 73hM9YIAMx5b4nW6iwK0PGcbZho1sUax9SghV1sBTUAhcdneZilPh8msFWySKjRcP1Nq +YJGDRniJoAynDncs7ufW/PRXzMkd2cKqYGlEm/ejS5IYT3sJJ8r4WUoIxECSYX7wN4y u/sMIdcRzpIIa5XSYa5XP10E3uWaS/ynzxBFvKoZJIRYpafJg1mIb+5KZeSou4bEX6j0 oPhw== X-Forwarded-Encrypted: i=1; AJvYcCVzSphkpBX2sYtz44oegDpXVIr5m4CXWHVMliZiRJEJb5lNKnwn+fIG38KHbWoBrtSVgvkG2l4Rx9kpnw5NPTY/FxEb3a1kkljlig== X-Gm-Message-State: AOJu0YzSzYUOrb+C+Q4kTaYPZEVlOWorAL9gbjG/YWFhNkhUwWcOrg1n qEp1PgIix1cto/TPaN80Fk5Im1Oqz2QwlkQRClIfHJT76poyHUtGWbWrg0f+FF4= X-Google-Smtp-Source: AGHT+IFQohyU7wQtUze4hfJ87FjGhz8kuXwcq542ocg5SMq50ay+AdU0n/55RAAiAJFH68bxmEhoDA== X-Received: by 2002:a50:bb06:0:b0:57d:38c:8102 with SMTP id 4fb4d7f45d1cf-57d4bd71020mr9427112a12.12.1719495603071; Thu, 27 Jun 2024 06:40:03 -0700 (PDT) Received: from [192.168.215.29] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-584d2c599d7sm878128a12.87.2024.06.27.06.40.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jun 2024 06:40:02 -0700 (PDT) Message-ID: Date: Thu, 27 Jun 2024 15:40:00 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8650-hdk: add port mapping to speakers To: Neil Armstrong , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240627-topic-sm8650-upstream-was-port-mapping-v1-0-4700bcc2489a@linaro.org> <20240627-topic-sm8650-upstream-was-port-mapping-v1-1-4700bcc2489a@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20240627-topic-sm8650-upstream-was-port-mapping-v1-1-4700bcc2489a@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27.06.2024 2:57 PM, Neil Armstrong wrote: > Add appropriate mappings of Soundwire ports of WSA8845 speaker > to correctly map the Speaker ports to the WSA macro ports. > > Signed-off-by: Neil Armstrong > --- > arch/arm64/boot/dts/qcom/sm8650-hdk.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > index eb2f910b4f58..591e6ab9bf5b 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > +++ b/arch/arm64/boot/dts/qcom/sm8650-hdk.dts > @@ -1137,6 +1137,16 @@ north_spkr: speaker@0,0 { > sound-name-prefix = "SpkrLeft"; > vdd-1p8-supply = <&vreg_l15b_1p8>; > vdd-io-supply = <&vreg_l3c_1p2>; > + > + /* > + * WSA8845 Port 1 (DAC) <=> SWR0 Port 1 (SPKR_L) > + * WSA8845 Port 2 (COMP) <=> SWR0 Port 2 (SPKR_L_COMP) > + * WSA8845 Port 3 (BOOST) <=> SWR0 Port 3 (SPKR_L_BOOST) > + * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR) > + * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 10 (SPKR_L_VI) > + * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS) > + */ > + qcom,port-mapping = <1 2 3 7 10 13>; > }; > > /* WSA8845, Speaker South */ > @@ -1150,6 +1160,16 @@ south_spkr: speaker@0,1 { > sound-name-prefix = "SpkrRight"; > vdd-1p8-supply = <&vreg_l15b_1p8>; > vdd-io-supply = <&vreg_l3c_1p2>; > + > + /* > + * WSA8845 Port 1 (DAC) <=> SWR0 Port 4 (SPKR_R) > + * WSA8845 Port 2 (COMP) <=> SWR0 Port 5 (SPKR_R_COMP) > + * WSA8845 Port 3 (BOOST) <=> SWR0 Port 6 (SPKR_R_BOOST) > + * WSA8845 Port 4 (PBR) <=> SWR0 Port 7 (PBR) > + * WSA8845 Port 5 (VISENSE) <=> SWR0 Port 11 (SPKR_R_VI) > + * WSA8845 Port 6 (CPS) <=> SWR0 Port 13 (CPS) > + */ > + qcom,port-mapping = <4 5 6 7 11 13>; I'm assuming PBR and CPS being common is intentional Reviewed-by: Konrad Dybcio Konrad