From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8A8EB64D9 for ; Wed, 12 Jul 2023 08:32:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232658AbjGLIcb (ORCPT ); Wed, 12 Jul 2023 04:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbjGLIcE (ORCPT ); Wed, 12 Jul 2023 04:32:04 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB35B198A for ; Wed, 12 Jul 2023 01:27:40 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-51e43473ee0so6726659a12.3 for ; Wed, 12 Jul 2023 01:27:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689150459; x=1691742459; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xRswFWEq5Q0hoPRcdiuVBaZQX0PfVAZ2UDfle8aIlUE=; b=fJZ9RA/TOfW/IC7fCyPAJeek5s+alQxRdIrfd0JYbwONJWEN5wgmVtQk/uBwGvgMPi Ekj0s1QiHEf7pKE5viNqe93nyRpPCdXldCvPsxmA519pZqq+UG8khASlq2SKM7vxZS+A G/+H1qGbvFQ2nlo0bt0O41Lfl4tFxGyVZqXVI8eHmJAiA6JcnzGWqxcIPM3jYn0uVpv7 B3nw6Qt1EApCxDwi8CHa9MXoWpa9FyU3I5jiNmROM9TalQCXSZ9xgvEKVBIJT9SFFpvH R5ZtzbqiKnI15Leik+DjJQm67U2RxOnoK1V3ONK9ToRnfJjI3pbuxgAAnTbpy9yoJsTQ R7wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689150459; x=1691742459; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xRswFWEq5Q0hoPRcdiuVBaZQX0PfVAZ2UDfle8aIlUE=; b=ZR6Fy3XHSQDeXClnQUtNdRIakTRcSRA7AE19mrp6PsetUVfDhE0vuyx8O0E2iP8IZS lD33phvYqlhhd8cc7XUqVB9R3kmMsEC3GOANF8dM88uco084pt31x63HSH4TkJeOuJna MVC3h8heCO3xiGmciVcWIgwZJ6PaiXi2Pk14NCOIQufBOt3OBmUQ4O76DCX5HmxiqKs4 t3tWXRxEmHsT6fcDwuRp3Hzy08Bk/X4A4q5Nrxnql/ofjBtK7N/G3A3PMfNf+UOFOUjs rKf2I7KKRj/4dqXQSybppm/xOsokTK1DrJaZ6VTdS46/LGmBR5A0AAqP4fNdDWdk2kDH OA2A== X-Gm-Message-State: ABy/qLaSxI+gYrMxKVqUpFXBoSM61WAAPyiL820DKgWKCHu9y2vdRP8H Td3RuE3D5P7WaHaMXrEQVD5H1eQ7FDZAmuR/1Zo= X-Google-Smtp-Source: APBJJlEB4GoTE616vRIXj8Fp6PjJajwca+FvJsVzLvw34glvBUNUVw6JKLoiRI+Op/NRBLNlScckxg== X-Received: by 2002:aa7:d741:0:b0:51d:a483:6089 with SMTP id a1-20020aa7d741000000b0051da4836089mr18195659eds.24.1689150459132; Wed, 12 Jul 2023 01:27:39 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id j4-20020a50ed04000000b0051e2a6cef4fsm2397601eds.36.2023.07.12.01.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 01:27:38 -0700 (PDT) Message-ID: Date: Wed, 12 Jul 2023 10:27:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Content-Language: en-US To: Delphine CC Chiu , patrick@stwcx.xyz, Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley , Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230712073752.54624-1-Delphine_CC_Chiu@wiwynn.com> <20230712073752.54624-3-Delphine_CC_Chiu@wiwynn.com> From: Krzysztof Kozlowski In-Reply-To: <20230712073752.54624-3-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/07/2023 09:37, Delphine CC Chiu wrote: > Add linux device tree entry related to > Yosemite V4 specific devices connected to BMC SoC. > > Signed-off-by: Delphine CC Chiu > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-yosemitev4.dts | 570 ++++++++++++++++++ > 2 files changed, 571 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..871e6d271262 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-galaxy100.dtb \ > aspeed-bmc-facebook-greatlakes.dtb \ > aspeed-bmc-facebook-minipack.dtb \ > + aspeed-bmc-facebook-yosemitev4.dtb \ > aspeed-bmc-facebook-tiogapass.dtb \ > aspeed-bmc-facebook-wedge40.dtb \ > aspeed-bmc-facebook-wedge100.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > new file mode 100644 > index 000000000000..1df151fb6ff3 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > @@ -0,0 +1,570 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2022 Facebook Inc. > + > +/dts-v1/; > +#include "aspeed-g6.dtsi" > +#include > +#include > +#include > + > +/ { > + model = "Facebook Yosemite V4 BMC"; > + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; > + > + aliases { > + serial4 = &uart5; > + serial5 = &uart6; > + serial6 = &uart7; > + serial7 = &uart8; > + serial8 = &uart9; > + }; > + > + chosen { > + bootargs = "console=ttyS4,57600n8"; Use stdout-path > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; ... > + > +&i2c0 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; > + reg = <0x40>; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Look, you already got such comment so you are repeating same mistakes. https://lore.kernel.org/all/a8854c8e-8868-461d-9f7b-d5b44f7288c7@linaro.org/ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; > + reg = <0x40>; > + }; > +}; > + > +&i2c2 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; I stop here, there is no point to review same mistakes. Best regards, Krzysztof