* [PATCH v1 0/2] Add Facebook Yosemite V4 (AST2600) BMC @ 2023-07-12 7:37 Delphine CC Chiu 2023-07-12 7:37 ` [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu 2023-07-12 7:37 ` [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 0 siblings, 2 replies; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-12 7:37 UTC (permalink / raw) To: patrick Cc: Delphine CC Chiu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel v1 - Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu (2): dt-bindings: arm: aspeed: add Facebook Yosemite V4 board ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-yosemitev4.dts | 570 ++++++++++++++++++ 3 files changed, 572 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts -- 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board 2023-07-12 7:37 [PATCH v1 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu @ 2023-07-12 7:37 ` Delphine CC Chiu 2023-07-12 8:23 ` Krzysztof Kozlowski 2023-07-12 7:37 ` [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 1 sibling, 1 reply; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-12 7:37 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Document the new compatibles used on Facebook Yosemite V4. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index e0eff4c05879..2ef6821e3648 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,yosemitev4-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board 2023-07-12 7:37 ` [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu @ 2023-07-12 8:23 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2023-07-12 8:23 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 12/07/2023 09:37, Delphine CC Chiu wrote: > Document the new compatibles used on Facebook Yosemite V4. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC 2023-07-12 7:37 [PATCH v1 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 2023-07-12 7:37 ` [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu @ 2023-07-12 7:37 ` Delphine CC Chiu 2023-07-12 8:27 ` Krzysztof Kozlowski 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 1 sibling, 2 replies; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-12 7:37 UTC (permalink / raw) To: patrick, Arnd Bergmann, Olof Johansson, soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-yosemitev4.dts | 570 ++++++++++++++++++ 2 files changed, 571 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 59829fc90315..871e6d271262 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-galaxy100.dtb \ aspeed-bmc-facebook-greatlakes.dtb \ aspeed-bmc-facebook-minipack.dtb \ + aspeed-bmc-facebook-yosemitev4.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file mode 100644 index 000000000000..1df151fb6ff3 --- /dev/null +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts @@ -0,0 +1,570 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// Copyright 2022 Facebook Inc. + +/dts-v1/; +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/leds-pca955x.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "Facebook Yosemite V4 BMC"; + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; + + aliases { + serial4 = &uart5; + serial5 = &uart6; + serial6 = &uart7; + serial7 = &uart8; + serial8 = &uart9; + }; + + chosen { + bootargs = "console=ttyS4,57600n8"; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 0>, <&adc1 1>; + }; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; + +&uart4 { + status = "okay"; +}; + +&uart5 { + status = "okay"; +}; + +&uart6 { + status = "okay"; +}; + +&uart7 { + status = "okay"; +}; + +&uart8 { + status = "okay"; +}; + +&uart9 { + status = "okay"; +}; + +&wdt1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdtrst1_default>; + aspeed,reset-type = "soc"; + aspeed,external-signal; + aspeed,ext-push-pull; + aspeed,ext-active-high; + aspeed,ext-pulse-duration = <256>; +}; + +&mac2 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii3_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&rtc { + status = "okay"; +}; + +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; + flash@1 { + status = "okay"; + m25p,fast-read; + label = "bmc2"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; + }; +}; + +&i2c0 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c1 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c2 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c3 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c4 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c5 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c6 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c7 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + adm1278@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c8 { + status = "okay"; + bus-frequency = <400000>; + i2cswitch@70 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x70>; + }; +}; + +&i2c9 { + status = "okay"; + bus-frequency = <400000>; + i2cswitch@71 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + }; +}; + +&i2c10 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c11 { + status = "okay"; + bus-frequency = <400000>; + adm1272@10 { + compatible = "adi, adm1272"; + reg = <0x10>; + }; + + adm1272@12 { + compatible = "adi, adm1272"; + reg = <0x12>; + }; + + pca9555@20 { + compatible = "nxp,pca9555"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + }; + + pca9555@21 { + compatible = "nxp,pca9555"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + pca9555@22 { + compatible = "nxp,pca9555"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + pca9555@23 { + compatible = "nxp,pca9555"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; + + tmp75@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + tmp75@49 { + compatible = "ti,tmp75"; + reg = <0x49>; + }; + + tmp75@4a { + compatible = "ti,tmp75"; + reg = <0x4a>; + }; + + tmp75@4b { + compatible = "ti,tmp75"; + reg = <0x4b>; + }; + + eeprom@54 { + compatible = "atmel,24c256"; + reg = <0x54>; + }; +}; + +&i2c12 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c13 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c14 { + status = "okay"; + bus-frequency = <400000>; + adc128d818@1d { + compatible = "ti,adc128d818"; + reg = <0x1d>; + ti,mode = /bits/ 8 <2>; + }; + + adc128d818@35 { + compatible = "ti,adc128d818"; + reg = <0x35>; + ti,mode = /bits/ 8 <2>; + }; + + adc128d818@37 { + compatible = "ti,adc128d818"; + reg = <0x37>; + ti,mode = /bits/ 8 <2>; + }; + + ina230@40 { + compatible = "ti,ina230"; + reg = <0x40>; + }; + + ina230@41 { + compatible = "ti,ina230"; + reg = <0x41>; + }; + + ina230@42 { + compatible = "ti,ina230"; + reg = <0x42>; + }; + + ina230@41 { + compatible = "ti,ina230"; + reg = <0x43>; + }; + + ina230@44 { + compatible = "ti,ina230"; + reg = <0x44>; + }; + + tmp75@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + tmp75@4e { + compatible = "ti,tmp75"; + reg = <0x4e>; + }; + + tmp75@4f { + compatible = "ti,tmp75"; + reg = <0x4f>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + i2cswitch@71 { + compatible = "nxp,pca9846"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc128d818@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + max31790@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + tca6424@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + max31790@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + max11615@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + pca9552@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc128d818@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + max31790@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + tca6424@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + max31790@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + max11615@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + pca9552@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + }; + + i2cswitch@73 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x73>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + max11617@6a { + compatible = "maxim,max11617"; + reg = <0x6a>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + max11617@6a { + compatible = "maxim,max11617"; + reg = <0x6a>; + }; + }; + }; +}; + +&i2c15 { + status = "okay"; + bus-frequency = <400000>; +}; + +&adc0 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default>; +}; + + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC 2023-07-12 7:37 ` [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu @ 2023-07-12 8:27 ` Krzysztof Kozlowski 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 1 sibling, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2023-07-12 8:27 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Arnd Bergmann, Olof Johansson, soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 12/07/2023 09:37, Delphine CC Chiu wrote: > Add linux device tree entry related to > Yosemite V4 specific devices connected to BMC SoC. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-yosemitev4.dts | 570 ++++++++++++++++++ > 2 files changed, 571 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..871e6d271262 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-galaxy100.dtb \ > aspeed-bmc-facebook-greatlakes.dtb \ > aspeed-bmc-facebook-minipack.dtb \ > + aspeed-bmc-facebook-yosemitev4.dtb \ > aspeed-bmc-facebook-tiogapass.dtb \ > aspeed-bmc-facebook-wedge40.dtb \ > aspeed-bmc-facebook-wedge100.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > new file mode 100644 > index 000000000000..1df151fb6ff3 > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > @@ -0,0 +1,570 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2022 Facebook Inc. > + > +/dts-v1/; > +#include "aspeed-g6.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > +#include <dt-bindings/leds/leds-pca955x.h> > +#include <dt-bindings/i2c/i2c.h> > + > +/ { > + model = "Facebook Yosemite V4 BMC"; > + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; > + > + aliases { > + serial4 = &uart5; > + serial5 = &uart6; > + serial6 = &uart7; > + serial7 = &uart8; > + serial8 = &uart9; > + }; > + > + chosen { > + bootargs = "console=ttyS4,57600n8"; Use stdout-path > + }; > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; ... > + > +&i2c0 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; > + reg = <0x40>; > + }; > +}; > + > +&i2c1 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Look, you already got such comment so you are repeating same mistakes. https://lore.kernel.org/all/a8854c8e-8868-461d-9f7b-d5b44f7288c7@linaro.org/ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; > + reg = <0x40>; > + }; > +}; > + > +&i2c2 { > + status = "okay"; > + bus-frequency = <400000>; > + multi-master; > + adm1278@40 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "adi,adm1278"; I stop here, there is no point to review same mistakes. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC 2023-07-12 7:37 ` [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 2023-07-12 8:27 ` Krzysztof Kozlowski @ 2023-07-14 2:34 ` Delphine CC Chiu 2023-07-14 2:34 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu ` (2 more replies) 1 sibling, 3 replies; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-14 2:34 UTC (permalink / raw) To: patrick Cc: Delphine CC Chiu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel v2 - Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu (2): dt-bindings: arm: aspeed: add Facebook Yosemite V4 board ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-yosemitev4.dts | 577 ++++++++++++++++++ 3 files changed, 579 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts -- 2.25.1 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu @ 2023-07-14 2:34 ` Delphine CC Chiu 2023-07-14 4:12 ` Krzysztof Kozlowski 2023-07-14 2:35 ` [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 2023-07-14 4:12 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Krzysztof Kozlowski 2 siblings, 1 reply; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-14 2:34 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Document the new compatibles used on Facebook Yosemite V4. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml index e0eff4c05879..2ef6821e3648 100644 --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml @@ -79,6 +79,7 @@ properties: - facebook,elbert-bmc - facebook,fuji-bmc - facebook,greatlakes-bmc + - facebook,yosemitev4-bmc - ibm,everest-bmc - ibm,rainier-bmc - ibm,tacoma-bmc -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board 2023-07-14 2:34 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu @ 2023-07-14 4:12 ` Krzysztof Kozlowski 0 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2023-07-14 4:12 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 14/07/2023 04:34, Delphine CC Chiu wrote: > Document the new compatibles used on Facebook Yosemite V4. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. https://elixir.bootlin.com/linux/v6.4/source/Documentation/process/submitting-patches.rst#L552 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 2023-07-14 2:34 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu @ 2023-07-14 2:35 ` Delphine CC Chiu 2023-07-14 4:13 ` Krzysztof Kozlowski 2023-07-14 4:12 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Krzysztof Kozlowski 2 siblings, 1 reply; 12+ messages in thread From: Delphine CC Chiu @ 2023-07-14 2:35 UTC (permalink / raw) To: patrick, Arnd Bergmann, Olof Johansson, soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel Add linux device tree entry related to Yosemite V4 specific devices connected to BMC SoC. Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- arch/arm/boot/dts/Makefile | 1 + .../dts/aspeed-bmc-facebook-yosemitev4.dts | 577 ++++++++++++++++++ 2 files changed, 578 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 59829fc90315..871e6d271262 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ aspeed-bmc-facebook-galaxy100.dtb \ aspeed-bmc-facebook-greatlakes.dtb \ aspeed-bmc-facebook-minipack.dtb \ + aspeed-bmc-facebook-yosemitev4.dtb \ aspeed-bmc-facebook-tiogapass.dtb \ aspeed-bmc-facebook-wedge40.dtb \ aspeed-bmc-facebook-wedge100.dtb \ diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts new file mode 100644 index 000000000000..cfe4838fae5a --- /dev/null +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts @@ -0,0 +1,577 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +// Copyright 2022 Facebook Inc. + +/dts-v1/; +#include "aspeed-g6.dtsi" +#include <dt-bindings/gpio/aspeed-gpio.h> +#include <dt-bindings/leds/leds-pca955x.h> +#include <dt-bindings/i2c/i2c.h> + +/ { + model = "Facebook Yosemite V4 BMC"; + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; + + aliases { + serial4 = &uart5; + serial5 = &uart6; + serial6 = &uart7; + serial7 = &uart8; + serial8 = &uart9; + }; + + chosen { + bootargs = "console=ttyS4,57600n8"; + }; + + memory@80000000 { + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + + iio-hwmon { + compatible = "iio-hwmon"; + io-channels = <&adc0 0>, <&adc0 1>, <&adc0 2>, <&adc0 3>, + <&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>, + <&adc1 0>, <&adc1 1>; + }; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; + +&uart4 { + status = "okay"; +}; + +&uart5 { + status = "okay"; +}; + +&uart6 { + status = "okay"; +}; + +&uart7 { + status = "okay"; +}; + +&uart8 { + status = "okay"; +}; + +&uart9 { + status = "okay"; +}; + +&wdt1 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_wdtrst1_default>; + aspeed,reset-type = "soc"; + aspeed,external-signal; + aspeed,ext-push-pull; + aspeed,ext-active-high; + aspeed,ext-pulse-duration = <256>; +}; + +&mac2 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii3_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&mac3 { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rmii4_default>; + no-hw-checksum; + use-ncsi; + mlx,multi-host; + ncsi-ctrl,start-redo-probe; + ncsi-ctrl,no-channel-monitor; + ncsi-package = <1>; + ncsi-channel = <1>; + ncsi-rexmit = <1>; + ncsi-timeout = <2>; +}; + +&rtc { + status = "okay"; +}; + +&fmc { + status = "okay"; + flash@0 { + status = "okay"; + m25p,fast-read; + label = "bmc"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; +#include "openbmc-flash-layout-64.dtsi" + }; + flash@1 { + status = "okay"; + m25p,fast-read; + label = "bmc2"; + spi-rx-bus-width = <4>; + spi-max-frequency = <50000000>; + }; +}; + +&i2c0 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c1 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c2 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c3 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c4 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c5 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c6 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c7 { + status = "okay"; + bus-frequency = <400000>; + multi-master; + power-sensor@40 { + compatible = "adi,adm1278"; + reg = <0x40>; + }; +}; + +&i2c8 { + status = "okay"; + bus-frequency = <400000>; + i2c-mux@70 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x70>; + }; +}; + +&i2c9 { + status = "okay"; + bus-frequency = <400000>; + i2c-mux@71 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + }; +}; + +&i2c10 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c11 { + status = "okay"; + bus-frequency = <400000>; + power-sensor@10 { + compatible = "adi, adm1272"; + reg = <0x10>; + }; + + power-sensor@12 { + compatible = "adi, adm1272"; + reg = <0x12>; + }; + + gpio@20 { + compatible = "nxp,pca9555"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@21 { + compatible = "nxp,pca9555"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@22 { + compatible = "nxp,pca9555"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@23 { + compatible = "nxp,pca9555"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@24 { + compatible = "nxp,pca9555"; + reg = <0x24>; + gpio-controller; + #gpio-cells = <2>; + }; + + temperature-sensor@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + temperature-sensor@49 { + compatible = "ti,tmp75"; + reg = <0x49>; + }; + + temperature-sensor@4a { + compatible = "ti,tmp75"; + reg = <0x4a>; + }; + + temperature-sensor@4b { + compatible = "ti,tmp75"; + reg = <0x4b>; + }; + + eeprom@54 { + compatible = "atmel,24c256"; + reg = <0x54>; + }; +}; + +&i2c12 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c13 { + status = "okay"; + bus-frequency = <400000>; +}; + +&i2c14 { + status = "okay"; + bus-frequency = <400000>; + adc@1d { + compatible = "ti,adc128d818"; + reg = <0x1d>; + ti,mode = /bits/ 8 <2>; + }; + + adc@35 { + compatible = "ti,adc128d818"; + reg = <0x35>; + ti,mode = /bits/ 8 <2>; + }; + + adc@37 { + compatible = "ti,adc128d818"; + reg = <0x37>; + ti,mode = /bits/ 8 <2>; + }; + + power-sensor@40 { + compatible = "ti,ina230"; + reg = <0x40>; + }; + + power-sensor@41 { + compatible = "ti,ina230"; + reg = <0x41>; + }; + + power-sensor@42 { + compatible = "ti,ina230"; + reg = <0x42>; + }; + + power-sensor@41 { + compatible = "ti,ina230"; + reg = <0x43>; + }; + + power-sensor@44 { + compatible = "ti,ina230"; + reg = <0x44>; + }; + + temperature-sensor@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + temperature-sensor@4e { + compatible = "ti,tmp75"; + reg = <0x4e>; + }; + + temperature-sensor@4f { + compatible = "ti,tmp75"; + reg = <0x4f>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + i2c-mux@71 { + compatible = "nxp,pca9846"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x71>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + temperature-sensor@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + gpio@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + temperature-sensor@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + adc@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + gpio@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@1f { + compatible = "ti,adc128d818"; + reg = <0x1f>; + ti,mode = /bits/ 8 <2>; + }; + + temperature-sensor@20{ + compatible = "max31790"; + reg = <0x20>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + gpio@22{ + compatible = "ti,tca6424"; + reg = <0x22>; + }; + + temperature-sensor@23{ + compatible = "max31790"; + reg = <0x23>; + #address-cells = <1>; + #size-cells = <0>; + fan-mode = "pwm"; + fanconfig = /bits/ 8 <0x19 0x19 0x19 0x18 0x18 0x18>; + }; + + adc@33 { + compatible = "maxim,max11615"; + reg = <0x33>; + }; + + eeprom@52 { + compatible = "atmel,24c128"; + reg = <0x52>; + }; + + gpio@61 { + compatible = "nxp,pca9552"; + reg = <0x61>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + }; + + i2c-mux@73 { + compatible = "nxp,pca9544"; + idle-state = <0>; + i2c-mux-idle-disconnect; + reg = <0x73>; + + i2c@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@6a { + compatible = "maxim,max11617"; + reg = <0x6a>; + }; + }; + + i2c@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + adc@6a { + compatible = "maxim,max11617"; + reg = <0x6a>; + }; + }; + }; +}; + +&i2c15 { + status = "okay"; + bus-frequency = <400000>; +}; + +&adc0 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc0_default &pinctrl_adc1_default + &pinctrl_adc2_default &pinctrl_adc3_default + &pinctrl_adc4_default &pinctrl_adc5_default + &pinctrl_adc6_default &pinctrl_adc7_default>; +}; + +&adc1 { + ref_voltage = <2500>; + status = "okay"; + pinctrl-0 = <&pinctrl_adc8_default &pinctrl_adc9_default>; +}; + + +&ehci0 { + status = "okay"; +}; + +&ehci1 { + status = "okay"; +}; + +&uhci { + status = "okay"; +}; -- 2.25.1 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC 2023-07-14 2:35 ` [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu @ 2023-07-14 4:13 ` Krzysztof Kozlowski 2023-07-18 5:19 ` Delphine_CC_Chiu/WYHQ/Wiwynn 0 siblings, 1 reply; 12+ messages in thread From: Krzysztof Kozlowski @ 2023-07-14 4:13 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Arnd Bergmann, Olof Johansson, soc, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 14/07/2023 04:35, Delphine CC Chiu wrote: > Add linux device tree entry related to > Yosemite V4 specific devices connected to BMC SoC. > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-yosemitev4.dts | 577 ++++++++++++++++++ > 2 files changed, 578 insertions(+) > create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..871e6d271262 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > aspeed-bmc-facebook-galaxy100.dtb \ > aspeed-bmc-facebook-greatlakes.dtb \ > aspeed-bmc-facebook-minipack.dtb \ > + aspeed-bmc-facebook-yosemitev4.dtb \ > aspeed-bmc-facebook-tiogapass.dtb \ > aspeed-bmc-facebook-wedge40.dtb \ > aspeed-bmc-facebook-wedge100.dtb \ > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > new file mode 100644 > index 000000000000..cfe4838fae5a > --- /dev/null > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > @@ -0,0 +1,577 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later > +// Copyright 2022 Facebook Inc. > + > +/dts-v1/; > +#include "aspeed-g6.dtsi" > +#include <dt-bindings/gpio/aspeed-gpio.h> > +#include <dt-bindings/leds/leds-pca955x.h> > +#include <dt-bindings/i2c/i2c.h> > + > +/ { > + model = "Facebook Yosemite V4 BMC"; > + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; > + > + aliases { > + serial4 = &uart5; > + serial5 = &uart6; > + serial6 = &uart7; > + serial7 = &uart8; > + serial8 = &uart9; > + }; > + > + chosen { > + bootargs = "console=ttyS4,57600n8"; Nothing improved, so you just ignored entire feedback and resent the same. Sorry, that's not how responding to feedback works. NAK Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* RE: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC 2023-07-14 4:13 ` Krzysztof Kozlowski @ 2023-07-18 5:19 ` Delphine_CC_Chiu/WYHQ/Wiwynn 0 siblings, 0 replies; 12+ messages in thread From: Delphine_CC_Chiu/WYHQ/Wiwynn @ 2023-07-18 5:19 UTC (permalink / raw) To: Krzysztof Kozlowski, Delphine_CC_Chiu/WYHQ/Wiwynn, patrick@stwcx.xyz, Arnd Bergmann, Olof Johansson, soc@kernel.org, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Friday, July 14, 2023 12:13 PM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>; > patrick@stwcx.xyz; Arnd Bergmann <arnd@arndb.de>; Olof Johansson > <olof@lixom.net>; soc@kernel.org; Rob Herring <robh+dt@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley > <conor+dt@kernel.org>; Joel Stanley <joel@jms.id.au>; Andrew Jeffery > <andrew@aj.id.au> > Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook > Yosemite V4 BMC > > Security Reminder: Please be aware that this email is sent by an external > sender. > > On 14/07/2023 04:35, Delphine CC Chiu wrote: > > Add linux device tree entry related to Yosemite V4 specific devices > > connected to BMC SoC. > > > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > > --- > > arch/arm/boot/dts/Makefile | 1 + > > .../dts/aspeed-bmc-facebook-yosemitev4.dts | 577 > ++++++++++++++++++ > > 2 files changed, 578 insertions(+) > > create mode 100644 > > arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > index 59829fc90315..871e6d271262 100644 > > --- a/arch/arm/boot/dts/Makefile > > +++ b/arch/arm/boot/dts/Makefile > > @@ -1631,6 +1631,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \ > > aspeed-bmc-facebook-galaxy100.dtb \ > > aspeed-bmc-facebook-greatlakes.dtb \ > > aspeed-bmc-facebook-minipack.dtb \ > > + aspeed-bmc-facebook-yosemitev4.dtb \ > > aspeed-bmc-facebook-tiogapass.dtb \ > > aspeed-bmc-facebook-wedge40.dtb \ > > aspeed-bmc-facebook-wedge100.dtb \ diff --git > > a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > new file mode 100644 > > index 000000000000..cfe4838fae5a > > --- /dev/null > > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev4.dts > > @@ -0,0 +1,577 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later // Copyright 2022 > > +Facebook Inc. > > + > > +/dts-v1/; > > +#include "aspeed-g6.dtsi" > > +#include <dt-bindings/gpio/aspeed-gpio.h> #include > > +<dt-bindings/leds/leds-pca955x.h> > > +#include <dt-bindings/i2c/i2c.h> > > + > > +/ { > > + model = "Facebook Yosemite V4 BMC"; > > + compatible = "facebook,yosemitev4-bmc", "aspeed,ast2600"; > > + > > + aliases { > > + serial4 = &uart5; > > + serial5 = &uart6; > > + serial6 = &uart7; > > + serial7 = &uart8; > > + serial8 = &uart9; > > + }; > > + > > + chosen { > > + bootargs = "console=ttyS4,57600n8"; > > Nothing improved, so you just ignored entire feedback and resent the same. I lost stdout-path feedback, so I'll revise to following format in next version contribute: chosen { stdout-path = "serial4:57600n8"; }; As former feedback mentioned, I also revise the i2c device node names by referencing DT specification. The only node name I used that not on the list is "power-sensor", which is following the example under Documentation/devicetree/bindings. Most of the other partition in DTS is same as the recent-contributed project. Would you please to tell if there's still some omissions I made. Thank you for reviewing. > > Sorry, that's not how responding to feedback works. > > NAK > > Best regards, > Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 2023-07-14 2:34 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu 2023-07-14 2:35 ` [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu @ 2023-07-14 4:12 ` Krzysztof Kozlowski 2 siblings, 0 replies; 12+ messages in thread From: Krzysztof Kozlowski @ 2023-07-14 4:12 UTC (permalink / raw) To: Delphine CC Chiu, patrick Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery, Arnd Bergmann, Olof Johansson, soc, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On 14/07/2023 04:34, Delphine CC Chiu wrote: > v2 - Add Facebook Yosemite V4 (AST2600) BMC > Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-07-18 5:19 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-07-12 7:37 [PATCH v1 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 2023-07-12 7:37 ` [PATCH v1 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu 2023-07-12 8:23 ` Krzysztof Kozlowski 2023-07-12 7:37 ` [PATCH v1 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 2023-07-12 8:27 ` Krzysztof Kozlowski 2023-07-14 2:34 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Delphine CC Chiu 2023-07-14 2:34 ` [PATCH v2 1/2] dt-bindings: arm: aspeed: add Facebook Yosemite V4 board Delphine CC Chiu 2023-07-14 4:12 ` Krzysztof Kozlowski 2023-07-14 2:35 ` [PATCH v2 2/2] ARM: dts: aspeed: yosemitev4: add Facebook Yosemite V4 BMC Delphine CC Chiu 2023-07-14 4:13 ` Krzysztof Kozlowski 2023-07-18 5:19 ` Delphine_CC_Chiu/WYHQ/Wiwynn 2023-07-14 4:12 ` [PATCH v2 0/2] Add Facebook Yosemite V4 (AST2600) BMC Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).