devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Lechner <david@lechnology.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Peter Rosin <peda@axentia.se>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Javier Martinez Canillas <javier@dowhile0.org>,
	Divagar Mohandass <divagar.mohandass@intel.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: at24: consistently document the compatible property
Date: Thu, 21 Dec 2017 11:24:22 -0600	[thread overview]
Message-ID: <f5d14ee3-1f80-6709-c5e5-36f65c1a9b84@lechnology.com> (raw)
In-Reply-To: <0c2455ae-2f68-5342-14c6-14706d6f0e66@axentia.se>

On 12/21/2017 10:20 AM, Peter Rosin wrote:
> On 2017-12-21 14:48, Bartosz Golaszewski wrote:
>> Current description of the compatible property for at24 is quite vague.
>>
>> Specify an exact list of accepted compatibles and document the - now
>> deprecated - strings which were previously used in device tree files.
> 
> Why is it suddenly deprecated to correctly specify what hardware you
> have, e.g. "nxp,24c32". In this case the manufacturer is nxp, damnit.
> Sure, it happens to be compatible with "atmel,24c32", but that is
> supposed to be written with a fallback as
> 
> 	"nxp,24c32", "atmel,24c32"
> 
> if I understand correctly. So, why is that deprecated in this case?
> 
> What if (a few years down the line) it is discovered that some weird
> quirk is needed that is only appropriate for nxp chips?
> 
> nxp is of course just an example, pick any manufacturer of eeproms
> (supposedly) compatible with the atmel interface.
> 

So now I am supposed to change my device tree from "microchip,24c128" to 
"atmel,24c128"?

Also, at,24c08 is listed in 
Documentation/devicetree/bindings/trivial-devices.txt. It should 
probably be removed.

  reply	other threads:[~2017-12-21 17:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-21 13:48 [PATCH v2 0/5] eeprom: at24: device tree support fixes Bartosz Golaszewski
     [not found] ` <20171221134842.31287-1-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 13:48   ` [PATCH v2 1/5] dt-bindings: at24: consistently document the compatible property Bartosz Golaszewski
     [not found]     ` <20171221134842.31287-2-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 14:09       ` Andy Shevchenko
2017-12-21 16:20     ` Peter Rosin
2017-12-21 17:24       ` David Lechner [this message]
     [not found]         ` <f5d14ee3-1f80-6709-c5e5-36f65c1a9b84-nq/r/kbU++upp/zk7JDF2g@public.gmane.org>
2017-12-21 17:25           ` David Lechner
2017-12-21 20:27       ` Javier Martinez Canillas
2017-12-21 23:07         ` Peter Rosin
2017-12-21 23:38           ` Javier Martinez Canillas
     [not found]             ` <CABxcv=kkp_Ck_JdDGomAGmSsTiCg82X67j5hEsvRnnY3RDMMfg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-22 16:58               ` Peter Rosin
2017-12-26 21:32                 ` Rob Herring
2017-12-26 22:21                   ` Bartosz Golaszewski
2017-12-21 13:48   ` [PATCH v2 4/5] dt-bindings: at24: extend the list of supported chips Bartosz Golaszewski
     [not found]     ` <20171221134842.31287-5-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 14:12       ` Andy Shevchenko
2017-12-21 13:48   ` [PATCH v2 5/5] eeprom: at24: extend the list of chips supported in DT Bartosz Golaszewski
     [not found]     ` <20171221134842.31287-6-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 14:13       ` Andy Shevchenko
2017-12-21 13:48 ` [PATCH v2 2/5] dt-bindings: at24: add a missing compatible Bartosz Golaszewski
     [not found]   ` <20171221134842.31287-3-brgl-ARrdPY/1zhM@public.gmane.org>
2017-12-21 14:08     ` Andy Shevchenko
2017-12-21 14:18       ` Bartosz Golaszewski
     [not found]         ` <CAMRc=MdkF9tioOqDwWFKWCRU832BZPMD1GjK+BonDbhEH0CCnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-21 14:25           ` Andy Shevchenko
2017-12-21 14:58             ` Bartosz Golaszewski
2017-12-21 13:48 ` [PATCH v2 3/5] dt-bindings: at24: fix formatting and style Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5d14ee3-1f80-6709-c5e5-36f65c1a9b84@lechnology.com \
    --to=david@lechnology.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=divagar.mohandass@intel.com \
    --cc=javier@dowhile0.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).