From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AB313112AB; Tue, 14 Oct 2025 12:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.161 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760443373; cv=none; b=LA/Q45RCbN44Ocs5lQnBreOQZeJg1g+SbYLluYX/VCHbwRdwE2NhRi7OJaasq1YSltevo8mmgDTsc98s+2kOhXWlo9K83dHHOn6QjKYfJBWZyR3LtEKo9/RuwEF8Br592845v7fNcDflh1ernVQV5nzd3ZM3gUVwKOFl/OfO6Fc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760443373; c=relaxed/simple; bh=Nybxa+p9NqNQhgsHzyX9inTtoUZ76g5EyUTzCC1rUjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YLW6gfPcsovIx/GcHbdnnEQ9ZvLWA9B6MjuIlKx9vA7XZx/PSEWcIajPLPYiaIMpS0JnemihaQ/bWMv+eOlrDaZeom/Jxe6UCUw78F5vK5McTatCFRpz2Swohf4B8/XW4XZ0uhn4bm4fuUfBiVv+49nyC6uPs7zuGLuXeREn3vs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=aiqICYOz; arc=none smtp.client-ip=80.241.56.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="aiqICYOz" Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4cmCX207CPz9ssn; Tue, 14 Oct 2025 14:02:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1760443362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o/k03sYntLq8Zfi4yO8/asoWJl9UlmpXJOixmGdXcyI=; b=aiqICYOzVOtRvf45kCUN9D3ePfh9PDjsWLq321JNC/20zo7IUdO0LnT+lmtSBjy4l0mLfL QBctdxgpYAdDupOqxL527XAV8FmE5GVKUQP+YgvzP7GBsu8vCQDqRTcQM4bz9mK616XeHX SF0kvrHLR7CntlilUs1dyeRIn3RFkey0s3aiTr9dOIQiUfawS6dVLWBMp7SJwIEiEJiY3Y H58vSGv9p9lYxw/qEP4TDKIKHQjWTMr2I8ZDE4J/HNWI4BH7KSStlCqLMo8n/1+fQhRkOm GIJUyKKh8RFSgKM3b6tftTIekpOBxU4y6EL6MGDqlbz/YmJtx5/iVvx9Q/IyvQ== Message-ID: Date: Tue, 14 Oct 2025 14:02:37 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 04/39] drm/imx: dc: Use bulk clock To: Frank Li Cc: dri-devel@lists.freedesktop.org, Abel Vesa , Conor Dooley , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , Liu Ying , Lucas Stach , Peng Fan , Pengutronix Kernel Team , Rob Herring , Shawn Guo , Thomas Zimmermann , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20251011170213.128907-1-marek.vasut@mailbox.org> <20251011170213.128907-5-marek.vasut@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-ID: 211e7aa255b7d3d8ef5 X-MBO-RS-META: bkw6rpy7gkkayzw1g5i6hemzbnb81gy6 On 10/13/25 6:54 PM, Frank Li wrote: > On Sat, Oct 11, 2025 at 06:51:19PM +0200, Marek Vasut wrote: >> Switch to bulk clock operations, as many of the blocks present in DC > > s/operations/API > >> use multiple clock on i.MX95. The use of bulk clock operations allows >> the driver to seamlessly handle one or multiple clock. >> >> Signed-off-by: Marek Vasut >> --- >> Cc: Abel Vesa >> Cc: Conor Dooley >> Cc: Fabio Estevam >> Cc: Krzysztof Kozlowski >> Cc: Laurent Pinchart >> Cc: Liu Ying >> Cc: Lucas Stach >> Cc: Peng Fan >> Cc: Pengutronix Kernel Team >> Cc: Rob Herring >> Cc: Shawn Guo >> Cc: Thomas Zimmermann >> Cc: devicetree@vger.kernel.org >> Cc: dri-devel@lists.freedesktop.org >> Cc: imx@lists.linux.dev >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-clk@vger.kernel.org >> --- >> drivers/gpu/drm/imx/dc/dc-drv.c | 14 ++++++++------ >> drivers/gpu/drm/imx/dc/dc-ic.c | 14 ++++++++------ >> drivers/gpu/drm/imx/dc/dc-pe.c | 12 ++++++------ >> drivers/gpu/drm/imx/dc/dc-pe.h | 3 ++- >> 4 files changed, 24 insertions(+), 19 deletions(-) >> >> diff --git a/drivers/gpu/drm/imx/dc/dc-drv.c b/drivers/gpu/drm/imx/dc/dc-drv.c >> index f108964bf89f4..2717c92aba6c5 100644 >> --- a/drivers/gpu/drm/imx/dc/dc-drv.c >> +++ b/drivers/gpu/drm/imx/dc/dc-drv.c >> @@ -31,7 +31,8 @@ >> >> struct dc_priv { >> struct drm_device *drm; >> - struct clk *clk_cfg; >> + struct clk_bulk_data *clk_cfg; >> + int clk_cfg_count; >> }; >> >> DEFINE_DRM_GEM_DMA_FOPS(dc_drm_driver_fops); >> @@ -163,10 +164,11 @@ static int dc_probe(struct platform_device *pdev) >> if (!priv) >> return -ENOMEM; >> >> - priv->clk_cfg = devm_clk_get(&pdev->dev, NULL); >> - if (IS_ERR(priv->clk_cfg)) >> - return dev_err_probe(&pdev->dev, PTR_ERR(priv->clk_cfg), >> + ret = devm_clk_bulk_get_all(&pdev->dev, &priv->clk_cfg); >> + if (ret < 0) >> + return dev_err_probe(&pdev->dev, ret, >> "failed to get cfg clock\n"); >> + priv->clk_cfg_count = ret; >> >> dev_set_drvdata(&pdev->dev, priv); >> >> @@ -201,7 +203,7 @@ static int dc_runtime_suspend(struct device *dev) >> { >> struct dc_priv *priv = dev_get_drvdata(dev); >> >> - clk_disable_unprepare(priv->clk_cfg); >> + clk_bulk_disable_unprepare(priv->clk_cfg_count, priv->clk_cfg); >> >> return 0; >> } >> @@ -211,7 +213,7 @@ static int dc_runtime_resume(struct device *dev) >> struct dc_priv *priv = dev_get_drvdata(dev); >> int ret; >> >> - ret = clk_prepare_enable(priv->clk_cfg); >> + ret = clk_bulk_prepare_enable(priv->clk_cfg_count, priv->clk_cfg); >> if (ret) >> dev_err(dev, "failed to enable cfg clock: %d\n", ret); >> >> diff --git a/drivers/gpu/drm/imx/dc/dc-ic.c b/drivers/gpu/drm/imx/dc/dc-ic.c >> index a270ae4030cdc..67441b349a7d2 100644 >> --- a/drivers/gpu/drm/imx/dc/dc-ic.c >> +++ b/drivers/gpu/drm/imx/dc/dc-ic.c >> @@ -30,7 +30,8 @@ >> >> struct dc_ic_data { >> struct regmap *regs; >> - struct clk *clk_axi; >> + struct clk_bulk_data *clk_axi; > > I am not sure if "axi' is good name for bulk clks. Maybe use 'clks'. _axi > quite specific to special 'axi' clocks. Fixed both, thanks.