From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: PJ Chen <chen.pj@inventec.com>, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
soc@kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org
Cc: ye.vic@inventec.com, Huang.Alang@inventec.com
Subject: Re: [PATCH v5 2/2] ARM: dts: aspeed: Adding Inventec Starscream BMC
Date: Mon, 19 Jun 2023 08:58:53 +0200 [thread overview]
Message-ID: <f5e6a29f-6df7-b56c-c7b2-9914008eaa33@linaro.org> (raw)
In-Reply-To: <20230619064249.3623-2-chen.pj@inventec.com>
On 19/06/2023 08:42, PJ Chen wrote:
> From: Chen PJ <Chen.pj@inventec.com>
>
> Initial introduction of Inventec Starscream x86 family
> equipped with AST2600 BMC SoC.
>
> Signed-off-by: Chen PJ <Chen.pj@inventec.com>
>
...
> + reserved-memory {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + video_engine_memory: video {
> + size = <0x04000000>;
> + alignment = <0x01000000>;
> + compatible = "shared-dma-pool";
> + reusable;
> + };
> + };
> +
> +
Drop stray blank lines. Only one blank line, not two. Comment applies to
multiple places.
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels =
> + <&adc_u74 0>, // P0_VDD11
> + <&adc_u74 1>, // P1_VDD11
> + <&adc_u74 2>, // P0_3V3_S5
> + <&adc_u74 3>, // P1_3V3_S5
> + <&adc_u74 4>, // P3V3
> + <&adc_u74 5>, // VBAT
> + <&adc_u74 6>, // P3V3_STBY
> + <&adc_u74 7>, // P5V_STBY
> + <&adc_u74 8>, // P5V
> + <&adc_u74 9>, // P12V
> + <&adc_u74 10>, // P1_VDD18_S5
> + <&adc_u74 11> // P0_VDD18_S5
> + ;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + uid {
No improvements. Still not fixed and not tested.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-19 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 6:42 [PATCH v5 1/2] dt-bindings: arm: aspeed: add Inventec starscream-bmc PJ Chen
2023-06-19 6:42 ` [PATCH v5 2/2] ARM: dts: aspeed: Adding Inventec Starscream BMC PJ Chen
2023-06-19 6:58 ` Krzysztof Kozlowski [this message]
2023-06-26 3:15 ` [PATCH v6 " Chen.PJ 陳柏任 TAO
2023-06-19 6:56 ` [PATCH v5 1/2] dt-bindings: arm: aspeed: add Inventec starscream-bmc Krzysztof Kozlowski
2023-06-19 7:47 ` Chen.PJ 陳柏任 TAO
2023-06-19 8:03 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-06-09 5:59 [PATCH v5 2/2] ARM: dts: aspeed: Adding Inventec Starscream BMC Chen.PJ 陳柏任 TAO
2023-06-09 11:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5e6a29f-6df7-b56c-c7b2-9914008eaa33@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Huang.Alang@inventec.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=chen.pj@inventec.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=ye.vic@inventec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).