From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63450C41513 for ; Mon, 14 Aug 2023 10:07:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbjHNKHL (ORCPT ); Mon, 14 Aug 2023 06:07:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbjHNKGm (ORCPT ); Mon, 14 Aug 2023 06:06:42 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19E88133; Mon, 14 Aug 2023 03:06:40 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id AFFA71BF209; Mon, 14 Aug 2023 10:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arinc9.com; s=gm1; t=1692007599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0CPBiqpkD56xdLSiPejjVYwV1Sq+6r1HWFGOkdNUC+E=; b=pmVZ7/v4e3/2MPQjoPucXGAIJRWmIdPGxlHTMR0et+tb7GZcPeX4c+ZBZNOW4iStCN/FoH /RPBJjKHlyVdQpaF80MzOP+H8EiGPZAJA6UyyZpxEvsZgqpOwhgczXfkL+GDCO1o4pws8M 4w0IQE6XsGpxcyQp/RvVFkcTrLLCuK6QPQQMTq1ynP/im39jJN3liVA/PxfmL/2jMkR14e HaT5pR1rIx/E3PUEyzmVNn2wcVuf/aoUf8n0oa+1k5gYZnGee0+N8NUvIbvIsbbRjGVI2S ogoLa2U8CPylVpn6V0KxSkCrCauZs5CYsQPwbzoqtaHYgEjUxekMpM1yRuMtdQ== Message-ID: Date: Mon, 14 Aug 2023 13:06:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] dt-bindings: net: dsa: document internal MDIO bus To: Vladimir Oltean Cc: Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , =?UTF-8?Q?Alvin_=C5=A0ipraga?= , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230812091708.34665-1-arinc.unal@arinc9.com> <20230812091708.34665-3-arinc.unal@arinc9.com> <20230812091708.34665-1-arinc.unal@arinc9.com> <20230812091708.34665-3-arinc.unal@arinc9.com> <47b61929-5c2d-4906-b153-2046a94858c8@arinc9.com> <47b61929-5c2d-4906-b153-2046a94858c8@arinc9.com> <20230813112026.ohsx6srbt2staxma@skbuf> <8a8e14f1-0493-4298-a2cc-6e7ae7929334@arinc9.com> <20230813190157.4y3zoro53qsz43pe@skbuf> Content-Language: en-US From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20230813190157.4y3zoro53qsz43pe@skbuf> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Sasl: arinc.unal@arinc9.com Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 13.08.2023 22:01, Vladimir Oltean wrote: > On Sun, Aug 13, 2023 at 03:59:11PM +0300, Arınç ÜNAL wrote: >>> sja1105 does not support an "mdio" child property. I haven't checked the >>> others. Don't add properties that aren't supported. >> >> Adding the mdio property to the dsa.yaml schema will allow it on all of the >> schemas that refer to dsa.yaml such as this one. This addition here is only >> to disallow additional properties under the mdio property for this specific >> schema. >> >> That said, my understanding is that the internal MDIO bus exists on all of >> the switches controlled by DSA. > > How come? > >> Whether each individual DSA subdriver supports registering it does not >> matter in terms of documenting the internal MDIO bus for all DSA >> switches. >> >> SJA1110 uses the mdios property instead because it's got two internal mdio >> buses, which is why I invalidate the mdio property for it. If SJA1105 has >> also got two internal mdio buses, let me know. > > SJA1105 has zero internal MDIO buses and zero internal PHYs. Ah okay. I didn't consider the switch architecture where the data interface of the PHY is connected to the switch, and the PHY management interface is connected to the mdio bus that the switch is connected to. The schemas of the switches which already utilise the mdio property: - /schemas/net/dsa/microchip,lan937x.yaml - /schemas/net/dsa/qca8k.yaml - /schemas/net/dsa/realtek.yaml - /schemas/net/dsa/renesas,rzn1-a5psw.yaml The schemas of the switches which don't have an internal MDIO bus, meaning the mdio property must be invalid: - /schemas/net/mscc,vsc7514-switch.yaml - /schemas/net/dsa/nxp,sja1105.yaml The schemas of the switches which I don't know if the switch has got an internal MDIO bus: - /schemas/net/dsa/arrow,xrs700x.yaml - I believe, because there's phy-handle defined on every port without the mdio node on the example, the PHYs are not connected to the internal MDIO bus. Therefore, we can invalidate the mdio property for this schema. - /schemas/net/dsa/brcm,b53.yaml - Seems ok to keep it valid. - /schemas/net/dsa/brcm,sf2.yaml - Seems ok to keep it valid. - /schemas/net/dsa/hirschmann,hellcreek.yaml - Same as /schemas/net/dsa/arrow,xrs700x.yaml. - /schemas/net/dsa/microchip,ksz.yaml - Seems ok to keep it valid. - /schemas/net/dsa/mscc,ocelot.yaml - Same as /schemas/net/dsa/arrow,xrs700x.yaml. Not json-schema documentation, don't care about: - ar9331.txt - lan9303.txt - lantiq-gswip.txt - marvell.txt - vitesse,vsc73xx.txt Arınç