[PATCH v5 0/2] support PWM for exynosautov9

[PATCH v5 0/2] support PWM for exynosautov9

[Jaewon Kim]

Add pwm nodes to support PWM fan on exynosautov9-sadk board.

---
Changes in v5:
 - change const to enum in dt-bindings document
 - remove comment for exynosautov9

Changes in v4:
 - add document file.

Changes in v3:
 - removed adding compatible to driver.

Changes in v2:
 - add compatible string to driver.


Jaewon Kim (2):
  dt-bindings: pwm: samsung: add exynosautov9 compatible
  arm64: dts: exynos: add pwm node for exynosautov9-sadk

 .../devicetree/bindings/pwm/pwm-samsung.yaml    | 17 +++++++++++------
 .../arm64/boot/dts/exynos/exynosautov9-sadk.dts |  6 ++++++
 arch/arm64/boot/dts/exynos/exynosautov9.dtsi    | 10 ++++++++++
 3 files changed, 27 insertions(+), 6 deletions(-)

-- 
2.17.1

[PATCH v5 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible

[Jaewon Kim]

Add samsung,exynosautov9-pwm compatible string to binding document.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
 .../devicetree/bindings/pwm/pwm-samsung.yaml    | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
index fe603fb1b2cc..2162f661ed5a 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
@@ -20,12 +20,17 @@ description: |+
 
 properties:
   compatible:
-    enum:
-      - samsung,s3c2410-pwm             # 16-bit, S3C24xx
-      - samsung,s3c6400-pwm             # 32-bit, S3C64xx
-      - samsung,s5p6440-pwm             # 32-bit, S5P64x0
-      - samsung,s5pc100-pwm             # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
-      - samsung,exynos4210-pwm          # 32-bit, Exynos
+    oneOf:
+      - enum:
+          - samsung,s3c2410-pwm             # 16-bit, S3C24xx
+          - samsung,s3c6400-pwm             # 32-bit, S3C64xx
+          - samsung,s5p6440-pwm             # 32-bit, S5P64x0
+          - samsung,s5pc100-pwm             # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
+          - samsung,exynos4210-pwm          # 32-bit, Exynos
+      - items:
+          - enum:
+              - samsung,exynosautov9-pwm
+          - const: samsung,exynos4210-pwm
 
   reg:
     maxItems: 1
-- 
2.17.1

[PATCH v5 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk

[Jaewon Kim]

Add pwm node to support fan on exynosautov9-sadk board.
PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
in SADK board.

Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
---
 arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts |  6 ++++++
 arch/arm64/boot/dts/exynos/exynosautov9.dtsi     | 10 ++++++++++
 2 files changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
index 101f51bf565a..bc1815f6ada2 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
+++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
@@ -49,6 +49,12 @@
 	};
 };
 
+&pwm {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pwm_tout3>;
+	status = "okay";
+};
+
 &serial_0 {
 	pinctrl-0 = <&uart0_bus_dual>;
 	status = "okay";
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
index d3c5cdeff47f..3b906f4db907 100644
--- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi
@@ -1560,6 +1560,16 @@
 			samsung,syscon-phandle = <&pmu_system_controller>;
 			samsung,cluster-index = <1>;
 		};
+
+		pwm: pwm@103f0000 {
+			compatible = "samsung,exynosautov9-pwm",
+				     "samsung,exynos4210-pwm";
+			reg = <0x103f0000 0x100>;
+			samsung,pwm-outputs = <0>, <1>, <2>, <3>;
+			#pwm-cells = <3>;
+			clocks = <&xtcxo>;
+			clock-names = "timers";
+		};
 	};
 };
 
-- 
2.17.1

Re: [PATCH v5 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible

[Krzysztof Kozlowski]

On 18/07/2023 05:42, Jaewon Kim wrote:
> Add samsung,exynosautov9-pwm compatible string to binding document.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v5 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk

[Krzysztof Kozlowski]

On 18/07/2023 05:42, Jaewon Kim wrote:
> Add pwm node to support fan on exynosautov9-sadk board.
> PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
> in SADK board.
> 
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts |  6 ++++++
>  arch/arm64/boot/dts/exynos/exynosautov9.dtsi     | 10 ++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> index 101f51bf565a..bc1815f6ada2 100644
> --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
> @@ -49,6 +49,12 @@
>  	};
>  };
>  
> +&pwm {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pwm_tout3>;
> +	status = "okay";

I think you miss disabling it.

> +};

Best regards,
Krzysztof

Re: [PATCH v5 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk

[Jaewon Kim]

On 23. 7. 18. 15:06, Krzysztof Kozlowski wrote:
> On 18/07/2023 05:42, Jaewon Kim wrote:
>> Add pwm node to support fan on exynosautov9-sadk board.
>> PWM channel 3 of ExynosAutov9 is connected to fan for SoC cooling
>> in SADK board.
>>
>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>> ---
>>   arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts |  6 ++++++
>>   arch/arm64/boot/dts/exynos/exynosautov9.dtsi     | 10 ++++++++++
>>   2 files changed, 16 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
>> index 101f51bf565a..bc1815f6ada2 100644
>> --- a/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynosautov9-sadk.dts
>> @@ -49,6 +49,12 @@
>>   	};
>>   };
>>   
>> +&pwm {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&pwm_tout3>;
>> +	status = "okay";
> I think you miss disabling it.

Okay, I will add disable status to soc dtsi.


>
>> +};
> Best regards,
> Krzysztof
>
>

Thanks

Jaewon Kim

Re: [PATCH v5 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

On Tue, Jul 18, 2023 at 08:04:51AM +0200, Krzysztof Kozlowski wrote:
> On 18/07/2023 05:42, Jaewon Kim wrote:
> > Add samsung,exynosautov9-pwm compatible string to binding document.
> > 
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > ---
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Do you prefer to take this through the Samsung tree for DT validation
and whatnot, or should I pick this up via the PWM tree?

In case of the former:

Acked-by: Thierry Reding <thierry.reding@gmail.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v5 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible

[Krzysztof Kozlowski]

On 18/07/2023 09:40, Thierry Reding wrote:
> On Tue, Jul 18, 2023 at 08:04:51AM +0200, Krzysztof Kozlowski wrote:
>> On 18/07/2023 05:42, Jaewon Kim wrote:
>>> Add samsung,exynosautov9-pwm compatible string to binding document.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>>> ---
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Do you prefer to take this through the Samsung tree for DT validation
> and whatnot, or should I pick this up via the PWM tree?
> 
> In case of the former:
> 
> Acked-by: Thierry Reding <thierry.reding@gmail.com>


Since there is no driver change, I can grab it via Samsung Soc. Thanks.

Best regards,
Krzysztof