From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: jonas.gorski@gmail.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maxime Ripard <maxime@cerno.tech>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions
Date: Sun, 7 Mar 2021 11:08:20 +0100 [thread overview]
Message-ID: <f60cc3a8-9629-3659-c3e5-4a42a588b63e@gmail.com> (raw)
In-Reply-To: <20210306211731.GA1217377@robh.at.kernel.org>
Hi Rob,
El 06/03/2021 a las 22:17, Rob Herring escribió:
> On Thu, Feb 25, 2021 at 08:41:59PM +0100, Álvaro Fernández Rojas wrote:
>> Add missing timer reset definitions for BCM63268.
>>
>> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
>> ---
>> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
>> index 6a6403a4c2d5..d87a7882782a 100644
>> --- a/include/dt-bindings/reset/bcm63268-reset.h
>> +++ b/include/dt-bindings/reset/bcm63268-reset.h
>> @@ -23,4 +23,8 @@
>> #define BCM63268_RST_PCIE_HARD 17
>> #define BCM63268_RST_GPHY 18
>>
>> +#define BCM63268_TRST_SW 29
>> +#define BCM63268_TRST_HW 30
>> +#define BCM63268_TRST_POR 31
>
> Numbering should be local to the provider, so shouldn't this be 0-2?
> Unless these numbers correspond to something in the h/w (bit positions
> for example).
Numbering corresponds to bit positions in the HW:
uint32 ClkRstCtl;
#define POR_RESET_STATUS (1 << 31)
#define HW_RESET_STATUS (1 << 30)
#define SW_RESET_STATUS (1 << 29)
#define USB_REF_CLKEN (1 << 18)
#define UTO_EXTIN_CLKEN (1 << 17)
#define UTO_CLK50_SEL (1 << 16)
#define FAP2_PLL_CLKEN (1 << 15)
#define FAP2_PLL_FREQ_SHIFT 12
#define FAP1_PLL_CLKEN (1 << 11)
#define FAP1_PLL_FREQ_SHIFT 8
#define WAKEON_DSL (1 << 7)
#define WAKEON_EPHY (1 << 6)
#define DSL_ENERGY_DETECT_ENABLE (1 << 4)
#define GPHY_1_ENERGY_DETECT_ENABLE (1 << 3)
#define EPHY_3_ENERGY_DETECT_ENABLE (1 << 2)
#define EPHY_2_ENERGY_DETECT_ENABLE (1 << 1)
#define EPHY_1_ENERGY_DETECT_ENABLE (1 << 0)
http://datashed.science/misc/bcm/gpl/broadcom-sdk-416L05/shared/opensource/include/bcm963xx/63268_map_part.h
>
>> +
>> #endif /* __DT_BINDINGS_RESET_BCM63268_H */
>> --
>> 2.20.1
>>
Best regards,
Álvaro.
next prev parent reply other threads:[~2021-03-07 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 19:41 [PATCH 0/4] clk: add BCM63268 timer clock and reset Álvaro Fernández Rojas
2021-02-25 19:41 ` [PATCH 1/4] mips: bmips: add BCM63268 timer clock definitions Álvaro Fernández Rojas
2021-03-06 21:09 ` Rob Herring
2021-03-13 22:55 ` Stephen Boyd
2021-02-25 19:41 ` [PATCH 2/4] mips: bmips: add BCM63268 timer reset definitions Álvaro Fernández Rojas
2021-03-06 21:17 ` Rob Herring
2021-03-07 10:08 ` Álvaro Fernández Rojas [this message]
2021-03-09 19:21 ` Rob Herring
2021-02-25 19:42 ` [PATCH 3/4] dt-bindings: clock: Add BCM63268 timer binding Álvaro Fernández Rojas
2021-03-06 21:18 ` Rob Herring
2021-02-25 19:42 ` [PATCH 4/4] clk: bcm: Add BCM63268 timer clock and reset driver Álvaro Fernández Rojas
2021-03-13 22:54 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f60cc3a8-9629-3659-c3e5-4a42a588b63e@gmail.com \
--to=noltari@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonas.gorski@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=mturquette@baylibre.com \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).