From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C778ECAAA1 for ; Tue, 30 Aug 2022 09:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231436AbiH3J2p (ORCPT ); Tue, 30 Aug 2022 05:28:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231867AbiH3J2i (ORCPT ); Tue, 30 Aug 2022 05:28:38 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CE87D9EA1 for ; Tue, 30 Aug 2022 02:28:36 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id br21so8919865lfb.0 for ; Tue, 30 Aug 2022 02:28:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=FmzIDD4Pa7+MmcfVJAwljvGaSQDMssbd6GqQpiHG2xs=; b=l/RBizF6kzePEfcYyZqRb6nMeIozE3Plc6MK0BE1z9FSW6eEoTADB7lH50rjVtKVQq aTqmCKBtnm6wV5Kxht5W+Ewwq+uFCzHlcHlgGiTPkWOJdSETsWYLh61oYlnGg5owVOt4 gTgRcao62+Di9UQGpr8ywKs/U7T16LOlJPS3gfiRUCGgQ1t+mGhWOrabo3LCkRdrlRhV LGOm4OsQsPsCD1yoyrc1650LghtiO8wVRy/t2PRKP/bbZ8GUCFO4sCcWknY7m03qo9ei zhMZEP9GT1iqij0GtA82IvCC+xLVClsJgUcZzL92rTS+HteejrYHKWXXwNnafYTLpewu Yppg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=FmzIDD4Pa7+MmcfVJAwljvGaSQDMssbd6GqQpiHG2xs=; b=utAoSHVRjqFPtna81CmB3KyspCRN3rSOk0kx/XqZNh19wYBq/34xtsnLI3CpHXGxjl Y2aszWC9Hu0wHwmoYgwWWj+vr2JyLHX2Q6t0NL5b5I08RaJwMVHZviyWJf/FkipmMg00 UW1z+p04yUIeX449zgXkKuTJN5ROPOE/O0CHiAVFiShgKNLkVD1tT7yXHb7SYyVM+N0F AouOCFNOkcY78H0nlwlUpV2MaOyb3Pw7yekPXKdqCVNaSGohU67FYPBQPKvDTCYGEsbm WJfKjb8YHeBR1km0gGM7aIO3DGKhGWfEHsOo+BPjl1DJK65pfut4oycq1hMZR5AlONEI +QRg== X-Gm-Message-State: ACgBeo2T1r9BIf44qXLh91rA3q+b6oAZuBpS56whuifoP9nu5kfmrEry mfZuHrbzbZGn0gYNcSOJUQ9bsQ== X-Google-Smtp-Source: AA6agR4+KSqYDLnziLnnQeT1r6I0LXNAxazi5IGv/j87wuVt+YLGrV9a67iwU0YcX+hsxrZFnxmBBw== X-Received: by 2002:a05:6512:10d4:b0:492:ede1:ec75 with SMTP id k20-20020a05651210d400b00492ede1ec75mr7014503lfg.146.1661851713946; Tue, 30 Aug 2022 02:28:33 -0700 (PDT) Received: from [192.168.28.124] (balticom-73-99-134.balticom.lv. [109.73.99.134]) by smtp.gmail.com with ESMTPSA id t28-20020a056512031c00b00492e4c97ca3sm85446lfp.246.2022.08.30.02.28.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Aug 2022 02:28:33 -0700 (PDT) Message-ID: Date: Tue, 30 Aug 2022 12:28:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/5] ASoC: dt-bindings: fsl_rpmsg: Add a property to assign platform driver name Content-Language: en-US To: Chancel Liu , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org, shengjiu.wang@nxp.com, Xiubo.Lee@gmail.com, festevam@gmail.com, nicoleotsuka@gmail.com, linuxppc-dev@lists.ozlabs.org References: <20220829075144.2405000-1-chancel.liu@nxp.com> <20220829075144.2405000-2-chancel.liu@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220829075144.2405000-2-chancel.liu@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/08/2022 10:51, Chancel Liu wrote: > Add a string property to assign ASoC platform driver name. It also > represents the rpmsg channel this sound card sits on. This property > can be omitted if there is only one sound card and it sits on > "rpmsg-audio-channel". > > Signed-off-by: Chancel Liu > --- > .../devicetree/bindings/sound/fsl,rpmsg.yaml | 34 +++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > index d370c98a62c7..35e3cb9f768b 100644 > --- a/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > +++ b/Documentation/devicetree/bindings/sound/fsl,rpmsg.yaml > @@ -11,8 +11,11 @@ maintainers: > > description: | > fsl_rpmsg is a virtual audio device. Mapping to real hardware devices > - are SAI, DMA controlled by Cortex M core. What we see from Linux > - side is a device which provides audio service by rpmsg channel. > + are SAI, MICFIL, DMA controlled by Cortex M core. What we see from > + Linux side is a device which provides audio service by rpmsg channel. > + We can create different sound cards which access different hardwares > + such as SAI, MICFIL, .etc through building rpmsg channels between > + Cortex-A and Cortex-M. > > properties: > compatible: > @@ -85,6 +88,14 @@ properties: > This is a boolean property. If present, the receiving function > will be enabled. > > + fsl,platform: > + $ref: /schemas/types.yaml#/definitions/string > + description: | > + A string property to assign ASoC platform driver name. No, this is not a property of hardware. Naming of some drivers in some systems does not fit DTS and bindings. > It also > + represents the rpmsg channel this sound card sits on. This property > + can be omitted if there is only one sound card and it sits on > + "rpmsg-audio-channel". > + > required: > - compatible > - model > @@ -107,3 +118,22 @@ examples: > <&clk IMX8MN_AUDIO_PLL2_OUT>; > clock-names = "ipg", "mclk", "dma", "pll8k", "pll11k"; > }; > + > + - | > + #include > + > + rpmsg_micfil: rpmsg_micfil { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Also: no underscores in node names. Best regards, Krzysztof